mirror of
https://github.com/lingble/twenty.git
synced 2025-10-29 11:52:28 +00:00
Something changed, which affected the Favorite folder picker checkbox styles -- fixed it! Cleaned up code in `CurrentWorkspaceMemberFavoritesFolders` - removed redundant filtering since favorites are already filtered in `usePrefetchedFavoritesData`. Regarding issue #8569 - I am not sure what to do in this case. Since Folders data is gated by a feature flag, we can't use it in `CurrentWorkspaceMemberFavoritesFolders` to ensure the favorite section renders with empty folders. Currently, the section only appears when at least one favorite exists - may be leave this section open at all times or fix this bug after removal of the feature flag? --------- Co-authored-by: Nitin Koche <nitinkoche@Nitins-MacBook-Pro.local> Co-authored-by: Charles Bochet <charles@twenty.com>
52 lines
1.8 KiB
TypeScript
52 lines
1.8 KiB
TypeScript
import { PageFavoriteButton } from '@/favorites/components/PageFavoriteButton';
|
|
import { FavoriteFolderPicker } from '@/favorites/favorite-folder-picker/components/FavoriteFolderPicker';
|
|
import { FavoriteFolderPickerEffect } from '@/favorites/favorite-folder-picker/components/FavoriteFolderPickerEffect';
|
|
import { FavoriteFolderPickerComponentInstanceContext } from '@/favorites/favorite-folder-picker/scopes/FavoriteFolderPickerScope';
|
|
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
|
|
import { Dropdown } from '@/ui/layout/dropdown/components/Dropdown';
|
|
import { useDropdown } from '@/ui/layout/dropdown/hooks/useDropdown';
|
|
import { DropdownScope } from '@/ui/layout/dropdown/scopes/DropdownScope';
|
|
|
|
type PageFavoriteFoldersDropdownProps = {
|
|
dropdownId: string;
|
|
isFavorite: boolean;
|
|
record?: ObjectRecord;
|
|
objectNameSingular: string;
|
|
};
|
|
|
|
export const PageFavoriteFoldersDropdown = ({
|
|
dropdownId,
|
|
isFavorite,
|
|
record,
|
|
objectNameSingular,
|
|
}: PageFavoriteFoldersDropdownProps) => {
|
|
const { closeDropdown } = useDropdown(dropdownId);
|
|
|
|
return (
|
|
<FavoriteFolderPickerComponentInstanceContext
|
|
favoriteFoldersScopeId={dropdownId}
|
|
>
|
|
<DropdownScope dropdownScopeId={dropdownId}>
|
|
<Dropdown
|
|
dropdownId={dropdownId}
|
|
dropdownPlacement="bottom-start"
|
|
clickableComponent={<PageFavoriteButton isFavorite={isFavorite} />}
|
|
dropdownComponents={
|
|
<>
|
|
<FavoriteFolderPickerEffect record={record} />
|
|
<FavoriteFolderPicker
|
|
onSubmit={closeDropdown}
|
|
record={record}
|
|
objectNameSingular={objectNameSingular}
|
|
/>
|
|
</>
|
|
}
|
|
dropdownHotkeyScope={{
|
|
scope: dropdownId,
|
|
}}
|
|
/>
|
|
</DropdownScope>
|
|
</FavoriteFolderPickerComponentInstanceContext>
|
|
);
|
|
};
|