api: make ListPlugins parse only known plugin types (#15434)

api/sys_plugins_test.go

@@ -0,0 +1,79 @@
+package api
+
+import (
+	"context"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/hashicorp/vault/sdk/helper/consts"
+)
+
+func TestListPlugins(t *testing.T) {
+	mockVaultServer := httptest.NewServer(http.HandlerFunc(mockVaultHandler))
+	defer mockVaultServer.Close()
+
+	cfg := DefaultConfig()
+	cfg.Address = mockVaultServer.URL
+	client, err := NewClient(cfg)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	resp, err := client.Sys().ListPluginsWithContext(context.Background(), &ListPluginsInput{})
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	expectedPlugins := map[consts.PluginType][]string{
+		consts.PluginTypeCredential: {"alicloud"},
+		consts.PluginTypeDatabase:   {"cassandra-database-plugin"},
+		consts.PluginTypeSecrets:    {"ad", "alicloud"},
+	}
+
+	for pluginType, expected := range expectedPlugins {
+		actualPlugins := resp.PluginsByType[pluginType]
+		if len(expected) != len(actualPlugins) {
+			t.Fatal("Wrong number of plugins", expected, actualPlugins)
+		}
+		for i := range actualPlugins {
+			if expected[i] != actualPlugins[i] {
+				t.Fatalf("Expected %q but got %q", expected[i], actualPlugins[i])
+			}
+		}
+	}
+}
+
+func mockVaultHandler(w http.ResponseWriter, _ *http.Request) {
+	_, _ = w.Write([]byte(listUntypedResponse))
+}
+
+const listUntypedResponse = `{
+  "request_id": "82601a91-cd7a-718f-feca-f573449cc1bb",
+  "lease_id": "",
+  "renewable": false,
+  "lease_duration": 0,
+  "data": {
+    "auth": [
+      "alicloud"
+    ],
+    "database": [
+      "cassandra-database-plugin"
+    ],
+    "secret": [
+      "ad",
+      "alicloud"
+    ],
+    "some_other_unexpected_key": [
+      {
+        "objectKey": "objectValue"
+      },
+      {
+        "arbitraryData": 7
+      }
+    ]
+  },
+  "wrap_info": null,
+  "warnings": null,
+  "auth": null
+}`