scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-11-26 14:55:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update Type() to return an error

Browse Source
This commit is contained in:
Brian Kassouf
2017-04-12 16:41:06 -07:00
parent f2401c0128
commit 03e2bcbc79
6 changed files with 26 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
builtin/logical/database/dbplugin/client.go
View File

@@ -52,10 +52,11 @@ func newPluginClient(sys pluginutil.Wrapper, pluginRunner *pluginutil.PluginRunn
return nil, err
}
// We should have a Greeter now! This feels like a normal interface
// We should have a database type now. This feels like a normal interface
// implementation but is in fact over an RPC connection.
databaseRPC := raw.(*databasePluginRPCClient)
// Wrap RPC implimentation in DatabasePluginClient
return &DatabasePluginClient{
client: client,
databasePluginRPCClient: databaseRPC,
@@ -70,12 +71,11 @@ type databasePluginRPCClient struct {
client *rpc.Client
}
func (dr *databasePluginRPCClient) Type() string {
func (dr *databasePluginRPCClient) Type() (string, error) {
var dbType string
//TODO: catch error
dr.client.Call("Plugin.Type", struct{}{}, &dbType)
err := dr.client.Call("Plugin.Type", struct{}{}, &dbType)
return fmt.Sprintf("plugin-%s", dbType)
return fmt.Sprintf("plugin-%s", dbType), err
}
func (dr *databasePluginRPCClient) CreateUser(statements Statements, usernamePrefix string, expiration time.Time) (username string, password string, err error) {