Rename feature-flag service and include activation-flags state (#26476)

* rename

* move activation-flags state to the flags service

* clean up descriptions of services

* fix naming that I missed

* Update secrets.ts

* add test coverage

* services/flags: rearrage getters

---------

Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com>
This commit is contained in:
Angel Garbarino
2024-04-22 16:37:11 -06:00
committed by GitHub
parent 4cf7a4464f
commit 069975413f
17 changed files with 211 additions and 108 deletions

View File

@@ -19,7 +19,7 @@ export { ERROR_WINDOW_CLOSED, ERROR_MISSING_PARAMS, ERROR_JWT_LOGIN };
export default Component.extend({
store: service(),
featureFlagService: service('featureFlag'),
flagsService: service('flags'),
selectedAuthPath: null,
selectedAuthType: null,
@@ -133,7 +133,7 @@ export default Component.extend({
// The namespace can be either be passed as a query parameter, or be embedded
// in the state param in the format `<state_id>,ns=<namespace>`. So if
// `namespace` is empty, check for namespace in state as well.
if (namespace === '' || this.featureFlagService.managedNamespaceRoot) {
if (namespace === '' || this.flagsService.managedNamespaceRoot) {
const i = state.indexOf(',ns=');
if (i >= 0) {
// ",ns=" is 4 characters