From 2c6a3e72d52297e71a5606fc71ce1a8781dc94aa Mon Sep 17 00:00:00 2001
From: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
Date: Thu, 17 Aug 2023 09:47:35 -0700
Subject: [PATCH] UI: remove default setting for `max_versions` in kv metadata
 (#22394)

* remove default setting for max versions - leave unset with a value of 0

* add changelog
---
 changelog/22394.txt        | 3 +++
 ui/app/models/secret-v2.js | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 changelog/22394.txt

diff --git a/changelog/22394.txt b/changelog/22394.txt
new file mode 100644
index 0000000000..4f5a2b9c89
--- /dev/null
+++ b/changelog/22394.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+ui: fixes `max_versions` default for secret metadata unintentionally overriding kv engine defaults
+```
\ No newline at end of file
diff --git a/ui/app/models/secret-v2.js b/ui/app/models/secret-v2.js
index 406ea4a522..4f273c40cb 100644
--- a/ui/app/models/secret-v2.js
+++ b/ui/app/models/secret-v2.js
@@ -35,7 +35,7 @@ export default SecretV2Model.extend(KeyMixin, {
     subText: 'An optional set of informational key-value pairs that will be stored with all secret versions.',
   }),
   maxVersions: attr('number', {
-    defaultValue: 10,
+    defaultValue: 0,
     label: 'Maximum number of versions',
     subText:
       'The number of versions to keep per key. Once the number of keys exceeds the maximum number set here, the oldest version will be permanently deleted.',