mirror of
				https://github.com/optim-enterprises-bv/vault.git
				synced 2025-10-31 02:28:09 +00:00 
			
		
		
		
	Displays Auth Method description on Vault UI login page (#11795)
* Displays Auth Method description on login page * working on auth login form * Keeps path name as LinkTo label adds description to paths * removes commented and unused code * removes trailing white space * removes prettier package * adds test for description * removes extra white spaces * adds changelog file
This commit is contained in:
		
							
								
								
									
										3
									
								
								changelog/11795.txt
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										3
									
								
								changelog/11795.txt
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,3 @@ | ||||
| ```release-note:improvement | ||||
| ui: Added auth method descriptions to UI login page | ||||
| ``` | ||||
| @@ -178,7 +178,16 @@ export default Component.extend(DEFAULTS, { | ||||
|           unauthenticated: true, | ||||
|         }, | ||||
|       }); | ||||
|       this.set('methods', methods.map(m => m.serialize({ includeId: true }))); | ||||
|       this.set( | ||||
|         'methods', | ||||
|         methods.map(m => { | ||||
|           const method = m.serialize({ includeId: true }); | ||||
|           return { | ||||
|             ...method, | ||||
|             mountDescription: method.description, | ||||
|           }; | ||||
|         }) | ||||
|       ); | ||||
|       next(() => { | ||||
|         store.unloadAll('auth-method'); | ||||
|       }); | ||||
|   | ||||
| @@ -26,6 +26,10 @@ | ||||
|       @errorMessage={{if (and cluster.standby hasCSPError) cspErrorText error}} | ||||
|       data-test-auth-error | ||||
|     /> | ||||
|     <div class="has-bottom-margin-s "> | ||||
|       <p class="is-label">{{this.selectedAuthBackend.path}}</p> | ||||
|       <span class="description has-text-grey" data-test-description={{true}}>{{this.selectedAuthBackend.mountDescription}}</span> | ||||
|     </div> | ||||
|     {{#if (or (not hasMethodsWithPath) (not selectedAuthIsPath))}} | ||||
|       <Select | ||||
|         @label='Method' | ||||
|   | ||||
| @@ -150,6 +150,25 @@ module('Integration | Component | auth form', function(hooks) { | ||||
|     server.shutdown(); | ||||
|   }); | ||||
|  | ||||
|   test('it renders the description', async function(assert) { | ||||
|     let methods = { | ||||
|       'approle/': { | ||||
|         type: 'userpass', | ||||
|         description: 'app description', | ||||
|       }, | ||||
|     }; | ||||
|     let server = new Pretender(function() { | ||||
|       this.get('/v1/sys/internal/ui/mounts', () => { | ||||
|         return [200, { 'Content-Type': 'application/json' }, JSON.stringify({ data: { auth: methods } })]; | ||||
|       }); | ||||
|     }); | ||||
|     this.set('cluster', EmberObject.create({})); | ||||
|     await render(hbs`{{auth-form cluster=cluster }}`); | ||||
|     await settled(); | ||||
|     assert.equal(component.descriptionText, 'app description', 'renders a description for auth methods'); | ||||
|     server.shutdown(); | ||||
|   }); | ||||
|  | ||||
|   test('it calls authenticate with the correct path', async function(assert) { | ||||
|     this.owner.unregister('service:auth'); | ||||
|     this.owner.register('service:auth', workingAuthService); | ||||
|   | ||||
| @@ -11,5 +11,6 @@ export default { | ||||
|   tokenValue: value('[data-test-token]'), | ||||
|   password: fillable('[data-test-password]'), | ||||
|   errorText: text('[data-test-auth-error]'), | ||||
|   descriptionText: text('[data-test-description]'), | ||||
|   login: clickable('[data-test-auth-submit]'), | ||||
| }; | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 claire bontempo
					claire bontempo