VAULT-24798: audit - improve error messages (#26312)

* audit: remove 'op' from error messages and do some clean up

* Allow early error checking to be concerned with vault/Core vs. audit
This commit is contained in:
Peter Wilson
2024-04-11 09:09:32 +01:00
committed by GitHub
parent 82eda875dd
commit 3dc16db87e
40 changed files with 645 additions and 547 deletions

View File

@@ -30,19 +30,19 @@ func TestNewSinkMetricTimer(t *testing.T) {
"no-name": {
name: "",
isErrorExpected: true,
expectedErrorMessage: "audit.NewSinkMetricTimer: name is required: invalid parameter",
expectedErrorMessage: "name is required: invalid internal parameter",
},
"no-node": {
name: "foo",
node: nil,
isErrorExpected: true,
expectedErrorMessage: "audit.NewSinkMetricTimer: sink node is required: invalid parameter",
expectedErrorMessage: "sink node is required: invalid internal parameter",
},
"bad-node": {
name: "foo",
node: &EntryFormatter{},
isErrorExpected: true,
expectedErrorMessage: "audit.NewSinkMetricTimer: sink node must be of type 'sink': invalid parameter",
expectedErrorMessage: "sink node must be of type 'sink': invalid internal parameter",
},
}