Ember-cli upgrade from ~3.8 to ~3.20 (#9972)

* Update ember-cli to ~3.20

* Remove bad optional-feature

* Remove ember-fetch dep

* re-install ember-fetch

* update model fragments pr

* update ember model fragments correct package name

* update ember composable helpers to solve array helper error

* update ember-concurrency

* add back engine dependencies, automatically removed during ember-cli-upgrade

* make author-form-options component js file otherwise error

* for now comment out withTestWaiter

* add eslint-node and fix if not with unless in templates

* fix linting for tab index of false is now -1 and add type button to all buttons without types

* fix href errors for linting, likely have to come back and fix

* using eslint fix flag to fix all this.gets

* ember modules codemode removed files that had module twice, will fix in next commit

* finish codemode ember-data-codemod needed to rename const model

* more this.get removal codemode did not work

* cont. removal of this.get

* stop mixin rules until figure out how to reconfig them all

* smaller eslint ignores

* get codemode

* testing app small fixes to bring it back after all the changes

* small changes to eslint

* test removal of getProperties

* fix issue with baseKey because value could be unknown needed to add a question mark in nested get

* smaller linting fixes

* get nested fixes

* small linting error fixes

* small linting changes

* working through more small linting changes

* another round of linting modifications

* liniting fixes

* ember module codemod

* quinit dom codemod

* angle bracket codemod

* discovered that components must have js files

* ran all codemods this is all that's left

* small changes to fix get needs two object, should not have been using get.

* fix issue with one input in form field

* fun times with set and onChange from oninput

* fix issue with model not being passed through on secret-edit-display

* fix issue with yarn run test not working, revert without npm run all

* linting and small fix when loading without a selectAuthBackend

* fix failing test with ui-wizard issue

* fix test failure due to model not being asked for correctly with new changes, probably run into this more.

* fix issue with component helper and at props specific to wizard

* rename log to clilog due to conflict with new eslint rule

* small changes for test failures

* component helper at fixes

* Revert to old component style something with new one broke this and can't figure it out for now

* small fishy smelling test fixes will revisit

* small test changes

* more small test changes, appears upgrade treats spaces differently

* comment out code and test that no longer seems relevant but confirm

* clean run on component test though still some potential timing issues on ui-console test

* fixing one auth test issue and timing issue on enable-test

* small mods

* fix this conditional check from upgrade

* linting fixes after master merge

* package updates using yarn upgrade-interactive

* update libraries that did not effect any of the test failures.

* update ember truth helpers library

* settling tests

* Fix ui-panel control group output

* fix features selection test failures

* Fix auth tests (x-vault-token)

* fix shared test

* fix issue with data null on backend

* Revert "Fix auth tests (x-vault-token)"

This reverts commit 89cb174b2f.

* Fix auth tests (x-vault-token) without updating this.set

* Update redirect-to tests

* fix wrapped token test

* skip some flaky test

* fix issue with href and a tags vs buttons

* fix linting

* updates to get tests running (#10409)

* yarn isntall

* increasing resource_class

* whoops

* trying large

* back to xlarge

* Fix param issue on transform item routes

* test fixes

* settle on policies (old) test

* fix browserstack test warning and skips of test confirmed worked

* Fix redirect-to test

* skips

* fix transformation test and skip some kmip

* Skip tests

* Add meep marker to remaining failing tests

* Skip test with failing component

* rever skip on secret-create test

* Skip piece of test that fails due to navigation-input

* fix settings test where can and skip in others after confirming

* fix circle ci test failures

* ssh role settle

* Fix navigate-input and add settled to test

* Remove extra import

* secret cubbyhole and alicloud

* Add settled to gcpkms test

* settles on redirect to test

* Bump browserstack test resource to large

* Update browserstack resource size to xlarge

* update todos

* add back in withTestWaiter

* try and fix credentials conditional action added comment instead

* Update volatile computed properies to get functions

* this step was never reached and we never defined secretType anywhere so I removed

* add settled to policy old test

* Fix navigate-input on policies and leases

* replace ssh test with no var hoping that helps and add settled to other failing tests, unskip console tests

* kmip, transit, role test remove a skip and add in settled

* fix hover copy button, had to remove some testing functionality

* Remove private router service

* remove skip on control ssh and ui panel, fix search select by restructuring how to read the error

* final bit of working through skipped test

* Replace clearNonGlobalModels by linking directly to namespace with href-to

* Remove unused var

* Fix role-ssh id bug by updating form-field-from-model to form-field-group-loop

* Fix transit create id would not update

* Update option toggle selector for ssh-role

* Fix ssh selector

* cleanup pt1

* small clean up

* cleanup part2

* Fix computed on pricing-metrics-form

* small cleanup based on chelseas comments.

Co-authored-by: Chelsea Shaw <chelshaw.dev@gmail.com>
Co-authored-by: Sarah Thompson <sthompson@hashicorp.com>
This commit is contained in:
Angel Garbarino
2020-12-03 16:00:22 -07:00
committed by GitHub
parent 0e82a4f12d
commit 403b94eb34
584 changed files with 6266 additions and 5106 deletions

View File

@@ -59,13 +59,13 @@ module('Integration | Component | transit key actions', function(hooks) {
{{transit-key-actions selectedAction="encrypt" key=key}}
<div id="modal-wormhole"></div>
`);
assert.equal(findAll('[data-test-transit-action="encrypt"]').length, 1, 'renders encrypt');
assert.dom('[data-test-transit-action="encrypt"]').exists({ count: 1 }, 'renders encrypt');
this.set('key', { backend: 'transit', supportedActions: ['sign'] });
await render(hbs`
{{transit-key-actions selectedAction="sign" key=key}}
<div id="modal-wormhole"></div>`);
assert.equal(findAll('[data-test-transit-action="sign"]').length, 1, 'renders sign');
assert.dom('[data-test-transit-action="sign"]').exists({ count: 1 }, 'renders sign');
});
test('it renders: signature_algorithm field', async function(assert) {
@@ -75,17 +75,13 @@ module('Integration | Component | transit key actions', function(hooks) {
{{transit-key-actions selectedAction=selectedAction key=key}}
<div id="modal-wormhole"></div>
`);
assert.equal(
findAll('[data-test-signature-algorithm]').length,
0,
'does not render signature_algorithm field on sign'
);
assert
.dom('[data-test-signature-algorithm]')
.doesNotExist('does not render signature_algorithm field on sign');
this.set('selectedAction', 'verify');
assert.equal(
findAll('[data-test-signature-algorithm]').length,
0,
'does not render signature_algorithm field on verify'
);
assert
.dom('[data-test-signature-algorithm]')
.doesNotExist('does not render signature_algorithm field on verify');
this.set('selectedAction', 'sign');
this.set('key', {
@@ -94,17 +90,13 @@ module('Integration | Component | transit key actions', function(hooks) {
backend: 'transit',
supportedActions: ['sign', 'verify'],
});
assert.equal(
findAll('[data-test-signature-algorithm]').length,
1,
'renders signature_algorithm field on sign with rsa key'
);
assert
.dom('[data-test-signature-algorithm]')
.exists({ count: 1 }, 'renders signature_algorithm field on sign with rsa key');
this.set('selectedAction', 'verify');
assert.equal(
findAll('[data-test-signature-algorithm]').length,
1,
'renders signature_algorithm field on verify with rsa key'
);
assert
.dom('[data-test-signature-algorithm]')
.exists({ count: 1 }, 'renders signature_algorithm field on verify with rsa key');
});
test('it renders: rotate', async function(assert) {
@@ -114,14 +106,12 @@ module('Integration | Component | transit key actions', function(hooks) {
<div id="modal-wormhole"></div>
`);
assert.equal(find('*').textContent.trim(), '', 'renders an empty div');
assert.dom('*').hasText('', 'renders an empty div');
this.set('key.canRotate', true);
assert.equal(
find('button').textContent.trim(),
'Rotate encryption key',
'renders confirm-button when key.canRotate is true'
);
assert
.dom('button')
.hasText('Rotate encryption key', 'renders confirm-button when key.canRotate is true');
});
async function doEncrypt(assert, actions = [], keyattrs = {}) {
@@ -139,7 +129,7 @@ module('Integration | Component | transit key actions', function(hooks) {
find('#plaintext-control .CodeMirror').CodeMirror.setValue('plaintext');
await click('button[type="submit"]');
assert.deepEqual(
this.get('storeService.callArgs'),
this.storeService.callArgs,
{
action: 'encrypt',
backend: 'transit',
@@ -162,7 +152,7 @@ module('Integration | Component | transit key actions', function(hooks) {
await click('button[type="submit"]');
assert.deepEqual(
this.get('storeService.callArgs'),
this.storeService.callArgs,
{
action: 'encrypt',
backend: 'transit',
@@ -189,12 +179,12 @@ module('Integration | Component | transit key actions', function(hooks) {
`);
findAll('.CodeMirror')[0].CodeMirror.setValue('plaintext');
assert.equal(findAll('#key_version').length, 1, 'it renders the key version selector');
assert.dom('#key_version').exists({ count: 1 }, 'it renders the key version selector');
await triggerEvent('#key_version', 'change');
await click('button[type="submit"]');
assert.deepEqual(
this.get('storeService.callArgs'),
this.storeService.callArgs,
{
action: 'encrypt',
backend: 'transit',
@@ -221,11 +211,7 @@ module('Integration | Component | transit key actions', function(hooks) {
// await fillIn('#plaintext', 'plaintext');
find('#plaintext-control .CodeMirror').CodeMirror.setValue('plaintext');
assert.equal(
findAll('#key_version').length,
0,
'it does not render the selector when there is only one key'
);
assert.dom('#key_version').doesNotExist('it does not render the selector when there is only one key');
});
test('it does not carry ciphertext value over to decrypt', async function(assert) {
@@ -261,7 +247,7 @@ module('Integration | Component | transit key actions', function(hooks) {
await click('button[type="submit"]');
assert.deepEqual(
this.get('storeService.callArgs'),
this.storeService.callArgs,
{
action: 'export',
backend: 'transit',
@@ -272,7 +258,7 @@ module('Integration | Component | transit key actions', function(hooks) {
},
'passes expected args to the adapter'
);
assert.equal(this.get('storeService.callArgsOptions.wrapTTL'), '30m', 'passes value for wrapTTL');
assert.equal(this.storeService.callArgsOptions.wrapTTL, '30m', 'passes value for wrapTTL');
assert.equal(find('[data-test-encrypted-value="export"]').innerText, 'wrapped-token', 'wraps by default');
});
@@ -305,7 +291,7 @@ module('Integration | Component | transit key actions', function(hooks) {
'prints json response'
);
assert.deepEqual(
this.get('storeService.callArgs'),
this.storeService.callArgs,
{
action: 'export',
backend: 'transit',
@@ -333,7 +319,7 @@ module('Integration | Component | transit key actions', function(hooks) {
await blur('#algorithm');
await click('button[type="submit"]');
assert.deepEqual(
this.get('storeService.callArgs'),
this.storeService.callArgs,
{
action: 'hmac',
backend: 'transit',