scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-11-01 11:08:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

VAULT-28281: Pass in accountName variable into validation function (#27563)

Browse Source 
* pass in correct accountName variable into validation function

* modify test fixture to better test validation functionality

* pass in accountName variable into error message

* changelog
This commit is contained in:
davidadeleon
2024-06-21 15:09:07 -04:00
committed by GitHub
parent 7187b6f2c3
commit 45682dc090
3 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
changelog/27563.txt Normal file
View File

@@ -0,0 +1,3 @@
```release-note:bug
storage/azure: Fix invalid account name initialization bug
```

4
physical/azure/azure.go
View File

@@ -68,8 +68,8 @@ func NewAzureBackend(conf map[string]string, logger log.Logger) (physical.Backen
return nil, fmt.Errorf("'accountName' must be set") return nil, fmt.Errorf("'accountName' must be set")
} }
} }
if err := validateAccountName(name); err != nil { if err := validateAccountName(accountName); err != nil {
return nil, fmt.Errorf("invalid account name %s: %w", name, err) return nil, fmt.Errorf("invalid account name %s: %w", accountName, err)
} }
accountKey := os.Getenv("AZURE_ACCOUNT_KEY") accountKey := os.Getenv("AZURE_ACCOUNT_KEY")

2
physical/azure/azure_test.go
View File

@@ -35,7 +35,7 @@ func testFixture(t *testing.T) (*AzureBackend, func()) {
t.Helper() t.Helper()
ts := time.Now().UnixNano() ts := time.Now().UnixNano()
name := fmt.Sprintf("vlt%d", ts) name := fmt.Sprintf("vlt-%d", ts)
_ = os.Setenv("AZURE_BLOB_CONTAINER", name) _ = os.Setenv("AZURE_BLOB_CONTAINER", name)
cleanup := func() {} cleanup := func() {}