Eslint prefer-const (#17864)

* adds prefer-const to eslint config and runs fixer

* reverts unintended change
This commit is contained in:
Jordan Reimer
2022-11-09 16:15:31 -07:00
committed by GitHub
parent 96d623d3fc
commit 483ef19946
464 changed files with 1701 additions and 1714 deletions

View File

@@ -32,14 +32,14 @@ module('Integration | Component | control group', function (hooks) {
});
const setup = (modelData = {}, authData = {}) => {
let modelDefaults = {
const modelDefaults = {
approved: false,
requestPath: 'foo/bar',
id: 'accessor',
requestEntity: { id: 'requestor', name: 'entity8509' },
reload: sinon.stub(),
};
let authDataDefaults = { entity_id: 'requestor' };
const authDataDefaults = { entity_id: 'requestor' };
return {
model: {
@@ -54,7 +54,7 @@ module('Integration | Component | control group', function (hooks) {
};
test('requestor rendering', async function (assert) {
let { model, authData } = setup();
const { model, authData } = setup();
this.set('model', model);
this.set('auth.authData', authData);
await render(hbs`{{control-group model=this.model}}`);
@@ -68,7 +68,7 @@ module('Integration | Component | control group', function (hooks) {
});
test('requestor rendering: with token', async function (assert) {
let { model, authData } = setup();
const { model, authData } = setup();
this.set('model', model);
this.set('auth.authData', authData);
this.set('controlGroup.wrapInfo', { token: 'token' });
@@ -78,7 +78,7 @@ module('Integration | Component | control group', function (hooks) {
});
test('requestor rendering: some approvals', async function (assert) {
let { model, authData } = setup({ authorizations: [{ name: 'manager 1' }, { name: 'manager 2' }] });
const { model, authData } = setup({ authorizations: [{ name: 'manager 1' }, { name: 'manager 2' }] });
this.set('model', model);
this.set('auth.authData', authData);
await render(hbs`{{control-group model=this.model}}`);
@@ -86,7 +86,7 @@ module('Integration | Component | control group', function (hooks) {
});
test('requestor rendering: approved with no token', async function (assert) {
let { model, authData } = setup({ approved: true });
const { model, authData } = setup({ approved: true });
this.set('model', model);
this.set('auth.authData', authData);
await render(hbs`{{control-group model=this.model}}`);
@@ -99,7 +99,7 @@ module('Integration | Component | control group', function (hooks) {
});
test('requestor rendering: approved with token', async function (assert) {
let { model, authData } = setup({ approved: true });
const { model, authData } = setup({ approved: true });
this.set('model', model);
this.set('auth.authData', authData);
this.set('controlGroup.wrapInfo', { token: 'token' });
@@ -110,7 +110,7 @@ module('Integration | Component | control group', function (hooks) {
});
test('authorizer rendering', async function (assert) {
let { model, authData } = setup({ canAuthorize: true }, { entity_id: 'manager' });
const { model, authData } = setup({ canAuthorize: true }, { entity_id: 'manager' });
this.set('model', model);
this.set('auth.authData', authData);
@@ -131,7 +131,7 @@ module('Integration | Component | control group', function (hooks) {
});
test('authorizer rendering:authorized', async function (assert) {
let { model, authData } = setup(
const { model, authData } = setup(
{ canAuthorize: true, authorizations: [{ id: 'manager', name: 'manager' }] },
{ entity_id: 'manager' }
);
@@ -146,7 +146,7 @@ module('Integration | Component | control group', function (hooks) {
});
test('authorizer rendering: authorized and success', async function (assert) {
let { model, authData } = setup(
const { model, authData } = setup(
{ approved: true, canAuthorize: true, authorizations: [{ id: 'manager', name: 'manager' }] },
{ entity_id: 'manager' }
);
@@ -166,7 +166,7 @@ module('Integration | Component | control group', function (hooks) {
});
test('third-party: success', async function (assert) {
let { model, authData } = setup(
const { model, authData } = setup(
{ approved: true, canAuthorize: true, authorizations: [{ id: 'foo', name: 'foo' }] },
{ entity_id: 'manager' }
);