scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-11-01 19:17:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

UI: fix flaky form-related integration tests (#27537)

Browse Source 
* tests: await settled after calling cancelTimers to fix flakiness

* chore: don't use assert.ok

* tests: fix flaky mfa-test
This commit is contained in:
Noelle Daley
2024-06-21 16:49:54 -07:00
committed by GitHub
parent 89e9e0f2cd
commit 4e02a7a673
12 changed files with 89 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
ui/tests/integration/components/edit-form-test.js
View File

@@ -68,12 +68,12 @@ module('Integration | Component | edit form', function (hooks) {
component.submit();
later(() => cancelTimers(), 50);
return settled().then(() => {
assert.ok(saveSpy.calledOnce, 'calls passed onSave');
assert.strictEqual(saveSpy.getCall(0).args[0].saveType, 'save');
assert.deepEqual(saveSpy.getCall(0).args[0].model, this.model, 'passes model to onSave');
const flash = this.owner.lookup('service:flash-messages');
assert.strictEqual(flash.success.callCount, 1, 'calls flash message success');
});
await settled();
assert.true(saveSpy.calledOnce, 'calls passed onSave');
assert.strictEqual(saveSpy.getCall(0).args[0].saveType, 'save');
assert.deepEqual(saveSpy.getCall(0).args[0].model, this.model, 'passes model to onSave');
const flash = this.owner.lookup('service:flash-messages');
assert.strictEqual(flash.success.callCount, 1, 'calls flash message success');
});
});