scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-11-17 10:25:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix failing enterprise test (#26567)

Browse Source 
* fix failing test

* fix attribution test modifying original array

* use .map not forEach
This commit is contained in:
claire bontempo
2024-04-19 17:19:12 -07:00
committed by GitHub
parent 17552aab7d
commit 54304bf6f4
2 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ui/tests/integration/components/clients/attribution-test.js
View File

@@ -31,7 +31,7 @@ module('Integration | Component | clients/attribution', function (hooks) {
this.timestamp = formatRFC3339(mockNow);
this.selectedNamespace = null;
this.totalUsageCounts = total;
this.totalClientAttribution = by_namespace;
this.totalClientAttribution = [...by_namespace];
this.namespaceMountsData = by_namespace.find((ns) => ns.label === 'ns1').mounts;
});
@@ -338,7 +338,11 @@ ns1,pki-engine-0,5699,0,0,5699,0`,
test('csv filename omits sync clients if not activated', async function (assert) {
assert.expect(1);
this.totalClientAttribution.forEach((ns) => delete ns.secret_syncs);
this.totalClientAttribution = this.totalClientAttribution.map((ns) => {
const namespace = { ...ns };
delete namespace.secret_syncs;
return namespace;
});
await render(hbs`
<Clients::Attribution
@isSecretsSyncActivated={{false}}

15
ui/tests/integration/utils/client-count-utils-test.js
View File

@@ -84,14 +84,19 @@ module('Integration | Util | client count utils', function (hooks) {
});
test('formatByNamespace: it formats namespace array with mounts', async function (assert) {
assert.expect(3);
const original = [...RESPONSE.by_namespace];
const [formattedRoot, formattedNs1] = formatByNamespace(RESPONSE.by_namespace);
const [root, ns1] = SERIALIZED_ACTIVITY_RESPONSE.by_namespace;
const expectedNs1 = SERIALIZED_ACTIVITY_RESPONSE.by_namespace.find((ns) => ns.label === 'ns1');
const formattedNs1 = formatByNamespace(RESPONSE.by_namespace).find((ns) => ns.label === 'ns1');
assert.expect(2 + expectedNs1.mounts.length * 2);
assert.propEqual(formattedRoot, root, 'it formats root namespace');
assert.propEqual(formattedNs1, ns1, 'it formats ns1/ namespace');
assert.propEqual(formattedNs1, expectedNs1, 'it formats ns1/ namespace');
assert.propEqual(RESPONSE.by_namespace, original, 'it does not modify original by_namespace array');
formattedNs1.mounts.forEach((mount) => {
const expectedMount = expectedNs1.mounts.find((m) => m.label === mount.label);
assert.propEqual(Object.keys(mount), Object.keys(expectedMount), `${mount} as expected keys`);
assert.propEqual(Object.values(mount), Object.values(expectedMount), `${mount} as expected values`);
});
});
test('destructureClientCounts: it returns relevant key names when both old and new keys exist', async function (assert) {