scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-11-27 07:13:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

UI: Ember deprecation - addObject, removeObject (#25952)

Browse Source 
* Update add-to-array and remove-from-array helpers

* remove search-select-has-many, moved logic directly into mfa-login-enforcement-form (see #16470)

* Replace add/remove object in MFA files - All MFA tests pass

* Replace in PKI components (pki tests all passing)

* Replace in core addon where applicable

* glimmerize console service -- console tests pass

* more replacements

* update string-list, add comment to vertical-bar-chart

* Refactor CSP Event service

- only used one place (auth-form) so simplified that usage
- glimmerize and refactor so that the tests work

* small updates

* more cleanup

* Fix tests

* Remove objectAt from console-helpers

* Address PR comments

* move commandIndex clearing back

* Remove extra model set
This commit is contained in:
Chelsea Shaw
2024-03-25 13:31:31 -05:00
committed by GitHub
parent 74c350474b
commit 5c18a4e7a4
39 changed files with 239 additions and 193 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ui/tests/integration/helpers/add-to-array-test.js
View File

@@ -12,7 +12,7 @@ module('Integration | Helper | add-to-array', function (hooks) {
test('it correctly adds a value to an array without mutating the original', function (assert) {
const ARRAY = ['horse', 'cow', 'chicken'];
const result = addToArray([ARRAY, 'pig']);
const result = addToArray(ARRAY, 'pig');
assert.deepEqual(result, [...ARRAY, 'pig'], 'Result has additional item');
assert.deepEqual(ARRAY, ['horse', 'cow', 'chicken'], 'original array is not mutated');
});
@@ -20,7 +20,7 @@ module('Integration | Helper | add-to-array', function (hooks) {
test('it fails if the first value is not an array', function (assert) {
let result;
try {
result = addToArray(['not-array', 'string']);
result = addToArray('not-array', 'string');
} catch (e) {
result = e.message;
}
@@ -29,13 +29,13 @@ module('Integration | Helper | add-to-array', function (hooks) {
test('it works with non-string arrays', function (assert) {
const ARRAY = ['five', 6, '7'];
const result = addToArray([ARRAY, 10]);
const result = addToArray(ARRAY, 10);
assert.deepEqual(result, ['five', 6, '7', 10], 'added number value');
});
test('it de-dupes the result', function (assert) {
const ARRAY = ['horse', 'cow', 'chicken'];
const result = addToArray([ARRAY, 'horse']);
const result = addToArray(ARRAY, 'horse');
assert.deepEqual(result, ['horse', 'cow', 'chicken']);
});
});