[QT-588] test: fix drift between enos directories (#21695)

* Sync missing scenarios and modules
* Clean up variables and examples vars
* Add a `lint` make target for enos
* Update enos `fmt` workflow to run the `lint` target.
* Always use ipv4 addresses in target security groups.

Signed-off-by: Ryan Cragun <me@ryan.ec>

enos/enos-variables.hcl

@@ -1,22 +1,16 @@
 # Copyright (c) HashiCorp, Inc.
 # SPDX-License-Identifier: MPL-2.0
 
-variable "artifact_path" {
-  type        = string
-  description = "The local path for dev artifact to test"
-  default     = null
-}
-
 variable "artifactory_username" {
   type        = string
-  description = "The username to use when connecting to artifactory"
+  description = "The username to use when testing an artifact from artifactory"
   default     = null
   sensitive   = true
 }
 
 variable "artifactory_token" {
   type        = string
-  description = "The token to use when connecting to artifactory"
+  description = "The token to use when authenticating to artifactory"
   default     = null
   sensitive   = true
 }
@@ -36,7 +30,7 @@ variable "artifactory_repo" {
 variable "aws_region" {
   description = "The AWS region where we'll create infrastructure"
   type        = string
-  default     = "us-west-1"
+  default     = "us-east-1"
 }
 
 variable "aws_ssh_keypair_name" {
@@ -75,44 +69,12 @@ variable "backend_log_level" {
   default     = "trace"
 }
 
-variable "operator_instance" {
-  type        = string
-  description = "The ip address of the operator (Voter) node"
-}
-
 variable "project_name" {
   description = "The description of the project"
   type        = string
   default     = "vault-enos-integration"
 }
 
-variable "remove_vault_instances" {
-  type = map(object({
-    private_ip = string
-    public_ip  = string
-  }))
-  description = "The old vault nodes to be removed"
-}
-
-
-variable "ui_test_filter" {
-  type        = string
-  description = "A test filter to limit the ui tests to execute. Will be appended to the ember test command as '-f=\"<filter>\"'"
-  default     = null
-}
-
-variable "ui_run_tests" {
-  type        = bool
-  description = "Whether to run the UI tests or not. If set to false a cluster will be created but no tests will be run"
-  default     = true
-}
-
-variable "vault_enable_file_audit_device" {
-  description = "If true the file audit device will be enabled at the path /var/log/vault_audit.log"
-  type        = bool
-  default     = true
-}
-
 variable "rhel_distro_version" {
   description = "The version of RHEL to use"
   type        = string
@@ -132,7 +94,7 @@ variable "terraform_plugin_cache_dir" {
 }
 
 variable "tfc_api_token" {
-  description = "The Terraform Cloud QTI Organization API token."
+  description = "The Terraform Cloud QTI Organization API token. This is used to download the enos Terraform provider."
   type        = string
   sensitive   = true
 }
@@ -143,8 +105,20 @@ variable "ubuntu_distro_version" {
   default     = "22.04" // or "20.04", "18.04"
 }
 
+variable "ui_test_filter" {
+  type        = string
+  description = "A test filter to limit the ui tests to execute. Will be appended to the ember test command as '-f=\"<filter>\"'"
+  default     = null
+}
+
+variable "ui_run_tests" {
+  type        = bool
+  description = "Whether to run the UI tests or not. If set to false a cluster will be created but no tests will be run"
+  default     = true
+}
+
 variable "vault_artifact_type" {
-  description = "The Vault artifact type package or bundle"
+  description = "The type of Vault artifact to use when installing Vault from artifactory. It should be 'package' for .deb or # .rpm package and 'bundle' for .zip bundles"
   default     = "bundle"
 }
 
@@ -156,24 +130,30 @@ variable "vault_autopilot_initial_release" {
   }
 }
 
-variable "vault_bundle_path" {
+variable "vault_artifact_path" {
   description = "Path to CRT generated or local vault.zip bundle"
   type        = string
   default     = "/tmp/vault.zip"
 }
 
+variable "vault_build_date" {
+  description = "The build date for Vault artifact"
+  type        = string
+  default     = ""
+}
+
+variable "vault_enable_file_audit_device" {
+  description = "If true the file audit device will be enabled at the path /var/log/vault_audit.log"
+  type        = bool
+  default     = true
+}
+
 variable "vault_install_dir" {
   type        = string
   description = "The directory where the Vault binary will be installed"
   default     = "/opt/vault/bin"
 }
 
-variable "vault_instance_type" {
-  description = "The instance type to use for the Vault backend"
-  type        = string
-  default     = null
-}
-
 variable "vault_instance_count" {
   description = "How many instances to create for the Vault cluster"
   type        = number
@@ -198,12 +178,6 @@ variable "vault_log_level" {
   default     = "trace"
 }
 
-variable "vault_build_date" {
-  description = "The build date for Vault artifact"
-  type        = string
-  default     = ""
-}
-
 variable "vault_product_version" {
   description = "The version of Vault we are testing"
   type        = string