Purge opened connections on retries during tests (#4452)

api/api_integration_test.go

@@ -152,6 +152,7 @@ func testPostgresDB(t testing.TB) (string, func()) {
 		if err != nil {
 			return err
 		}
+		defer db.Close()
 		return db.Ping()
 	}); err != nil {
 		t.Fatalf("postgresdb: could not connect: %s", err)

builtin/logical/mssql/backend_test.go

@@ -53,6 +53,7 @@ func prepareMSSQLTestContainer(t *testing.T) (func(), string) {
 		if err != nil {
 			return err
 		}
+		defer db.Close()
 		return db.Ping()
 	}); err != nil {
 		cleanup()

builtin/logical/mysql/backend_test.go

@@ -47,6 +47,7 @@ func prepareTestContainer(t *testing.T) (func(), string) {
 		if err != nil {
 			return err
 		}
+		defer db.Close()
 		return db.Ping()
 	}); err != nil {
 		cleanup()

physical/cockroachdb/cockroachdb_test.go

@@ -58,6 +58,7 @@ func prepareCockroachDBTestContainer(t *testing.T) (cleanup func(), retURL, tabl
 		if err != nil {
 			return err
 		}
+		defer db.Close()
 		_, err = db.Exec("CREATE DATABASE database")
 		return err
 	}); err != nil {

plugins/database/mongodb/mongodb_test.go

@@ -55,6 +55,7 @@ func prepareMongoDBTestContainer(t *testing.T) (cleanup func(), retURL string) {
 		if err != nil {
 			return err
 		}
+		defer session.Close()
 		session.SetSyncTimeout(1 * time.Minute)
 		session.SetSocketTimeout(1 * time.Minute)
 		return session.Ping()

plugins/database/mysql/mysql_test.go

@@ -52,6 +52,7 @@ func prepareMySQLTestContainer(t *testing.T, legacy bool) (cleanup func(), retUR
 		if err != nil {
 			return err
 		}
+		defer db.Close()
 		return db.Ping()
 	}); err != nil {
 		cleanup()

plugins/database/postgresql/postgresql_test.go

@@ -50,6 +50,7 @@ func preparePostgresTestContainer(t *testing.T) (cleanup func(), retURL string)
 		if err != nil {
 			return err
 		}
+		defer db.Close()
 		return db.Ping()
 	}); err != nil {
 		t.Fatalf("Could not connect to PostgreSQL docker container: %s", err)