scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-10-30 10:12:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

bolt.write.time should actually be a counter, not a gauge (#22468)

Browse Source 
* bolt.write.time should actually be a counter, not a gauge

* add changelog

* Update website/content/docs/upgrading/upgrade-to-1.14.x.mdx

Co-authored-by: Paul Banks <pbanks@hashicorp.com>

* correct changelog

---------

Co-authored-by: Paul Banks <pbanks@hashicorp.com>
This commit is contained in:
Josh Black
2023-08-21 13:11:57 -07:00
committed by GitHub
parent 616c3a5ba5
commit 75eebddba9
5 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
changelog/22428.txt
View File

@@ -1,3 +0,0 @@
```release-note:bug
core/metrics: vault.raft_storage.bolt.write.time should be a gauge not a summary
```

3
changelog/22468.txt Normal file
View File

@@ -0,0 +1,3 @@
```release-note:bug
core/metrics: vault.raft_storage.bolt.write.time should be a counter not a summary
```

2
physical/raft/raft.go
View File

@@ -671,7 +671,7 @@ func (b *RaftBackend) collectMetricsWithStats(stats bolt.Stats, sink *metricsuti
sink.SetGaugeWithLabels([]string{"raft_storage", "bolt", "spill", "count"}, float32(txstats.GetSpill()), labels) sink.SetGaugeWithLabels([]string{"raft_storage", "bolt", "spill", "count"}, float32(txstats.GetSpill()), labels)
sink.AddSampleWithLabels([]string{"raft_storage", "bolt", "spill", "time"}, float32(txstats.GetSpillTime().Milliseconds()), labels) sink.AddSampleWithLabels([]string{"raft_storage", "bolt", "spill", "time"}, float32(txstats.GetSpillTime().Milliseconds()), labels)
sink.SetGaugeWithLabels([]string{"raft_storage", "bolt", "write", "count"}, float32(txstats.GetWrite()), labels) sink.SetGaugeWithLabels([]string{"raft_storage", "bolt", "write", "count"}, float32(txstats.GetWrite()), labels)
sink.SetGaugeWithLabels([]string{"raft_storage", "bolt", "write", "time"}, float32(txstats.GetWriteTime().Milliseconds()), labels) sink.IncrCounterWithLabels([]string{"raft_storage", "bolt", "write", "time"}, float32(txstats.GetWriteTime().Milliseconds()), labels)
} }
// RaftServer has information about a server in the Raft configuration // RaftServer has information about a server in the Raft configuration

3
website/content/docs/upgrading/upgrade-to-1.14.x.mdx
View File

@@ -28,7 +28,8 @@ Official images separately.
## Important changes ## Important changes
There are no major changes to announce at this time. `vault.raft_storage.bolt.write.time` has been corrected from a summary to a counter to more accurately reflect that it
is measuring cumulative time writing, and not the distribution of individual write times.
## Known issues and workarounds ## Known issues and workarounds

2
website/content/partials/telemetry-metrics/vault/raft_storage/bolt/write/time.mdx
View File

@@ -2,4 +2,4 @@
Metric type | Value | Description Metric type | Value | Description
----------- | ----- | ----------- ----------- | ----- | -----------
gauge | ms | Total time the Bolt database has spent writing to disk counter | ms | Total cumulative time the Bolt database has spent writing to disk.