scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-10-29 17:52:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix sys/leases panic when lease_id is nil (#18951)

Browse Source 
* fix sys/leases panic when lease_id is nil

* add changelog entry
This commit is contained in:
Chris Capurso
2023-02-03 09:51:10 -05:00
committed by GitHub
parent b969c9fed6
commit 7f1e0216f2
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
changelog/18951.txt Normal file
View File

@@ -0,0 +1,3 @@
```release-note:bug
core: Prevent panics in `sys/leases/lookup`, `sys/leases/revoke`, and `sys/leases/renew` endpoints if provided `lease_id` is null
```

2
vault/request_handling.go
View File

@@ -632,7 +632,7 @@ func (c *Core) handleCancelableRequest(ctx context.Context, req *logical.Request
case "sys/leases/lookup", "sys/leases/renew", "sys/leases/revoke", "sys/leases/revoke-force":
leaseID, ok := req.Data["lease_id"]
// If lease ID is not present, break out and let the backend handle the error
if !ok {
if !ok || leaseID == nil {
break
}
_, nsID := namespace.SplitIDFromString(leaseID.(string))