VAULT-17734, VAULT-17735: Combine linters (#21611)

* combine into one checker

* combine and simplify ci checks

* add to test package list

* remove testing test

* only run deprecations check

* only run deprecations check

* remove unneeded repo check

* fix bash options

tools/codechecker/main.go

@@ -0,0 +1,14 @@
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0
+
+package main
+
+import (
+	"github.com/hashicorp/vault/tools/codechecker/pkg/godoctests"
+	"github.com/hashicorp/vault/tools/codechecker/pkg/gonilnilfunctions"
+	"golang.org/x/tools/go/analysis/multichecker"
+)
+
+func main() {
+	multichecker.Main(gonilnilfunctions.Analyzer, godoctests.Analyzer)
+}

tools/codechecker/pkg/godoctests/analyzer.go

@@ -1,7 +1,7 @@
 // Copyright (c) HashiCorp, Inc.
 // SPDX-License-Identifier: MPL-2.0
 
-package analyzer
+package godoctests
 
 import (
 	"go/ast"

tools/codechecker/pkg/godoctests/analyzer_test.go

@@ -1,7 +1,7 @@
 // Copyright (c) HashiCorp, Inc.
 // SPDX-License-Identifier: MPL-2.0
 
-package analyzer
+package godoctests
 
 import (
 	"os"

tools/codechecker/pkg/gonilnilfunctions/analyzer.go

@@ -1,7 +1,7 @@
 // Copyright (c) HashiCorp, Inc.
 // SPDX-License-Identifier: MPL-2.0
 
-package analyzer
+package gonilnilfunctions
 
 import (
 	"go/ast"

tools/codechecker/pkg/gonilnilfunctions/analyzer_test.go

@@ -1,7 +1,7 @@
 // Copyright (c) HashiCorp, Inc.
 // SPDX-License-Identifier: MPL-2.0
 
-package analyzer
+package gonilnilfunctions
 
 import (
 	"os"

tools/godoctests/main.go

@@ -1,13 +0,0 @@
-// Copyright (c) HashiCorp, Inc.
-// SPDX-License-Identifier: MPL-2.0
-
-package main
-
-import (
-	"github.com/hashicorp/vault/tools/godoctests/pkg/analyzer"
-	"golang.org/x/tools/go/analysis/singlechecker"
-)
-
-func main() {
-	singlechecker.Main(analyzer.Analyzer)
-}

tools/gonilnilfunctions/main.go

@@ -1,13 +0,0 @@
-// Copyright (c) HashiCorp, Inc.
-// SPDX-License-Identifier: MPL-2.0
-
-package main
-
-import (
-	"github.com/hashicorp/vault/tools/gonilnilfunctions/pkg/analyzer"
-	"golang.org/x/tools/go/analysis/singlechecker"
-)
-
-func main() {
-	singlechecker.Main(analyzer.Analyzer)
-}