Fix Agent and Proxy env var handling (#24790)

* Fix Agent and Proxy env var handling

* Changelog

* Review suggestions
This commit is contained in:
Violet Hynes
2024-01-11 08:56:50 -05:00
committed by GitHub
parent ebf627ceed
commit 9e62680e10
5 changed files with 78 additions and 2 deletions

View File

@@ -1027,7 +1027,12 @@ func (c *AgentCommand) setBoolFlag(f *FlagSets, configVal bool, fVar *BoolVar) {
// Don't do anything as the flag is already set from the command line
case flagEnvSet:
// Use value from env var
*fVar.Target = flagEnvValue != ""
val, err := parseutil.ParseBool(flagEnvValue)
if err != nil {
c.logger.Error("error parsing bool from environment variable, using default instead", "environment variable", fVar.EnvVar, "provided value", flagEnvValue, "default", fVar.Default, "err", err)
val = fVar.Default
}
*fVar.Target = val
case configVal:
// Use value from config
*fVar.Target = configVal