scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-10-30 18:17:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only run fmtcheck on changed files pre-commit (#21747)

Browse Source 
The pre-commit hook was taking quite a while to run. Let's just check
changed files to avoid unnecessary `go fmt` on the entire tree.
This commit is contained in:
Mike Palmiotto
2023-07-11 10:26:16 -04:00
committed by GitHub
parent 1bed33a399
commit a9778be3f2
2 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
.hooks/pre-commit
View File

@@ -62,11 +62,14 @@ ui_lint() {
backend_lint() {
# Silently succeed if no changes staged for Go code files.
if git diff --name-only --cached --exit-code -- '*.go'; then
staged=$(git diff --name-only --cached --exit-code -- '*.go')
ret=$?
if [ $ret -eq 0 ]; then
return 0
fi
./scripts/gofmtcheck.sh || block "Backend linting failed; run 'make fmt' to fix."
# Only run fmtcheck on staged files
./scripts/gofmtcheck.sh "${staged}" || block "Backend linting failed; run 'make fmt' to fix."
}
for CHECK in $CHECKS; do

9
scripts/gofmtcheck.sh
View File

@@ -2,10 +2,17 @@
# Copyright (c) HashiCorp, Inc.
# SPDX-License-Identifier: MPL-2.0
echo "==> Checking that code complies with gofmt requirements..."
files=$(echo $1 | xargs)
if [ -n "$files" ]; then
echo "Checking changed files..."
gofmt_files="$(echo $1 | grep -v pb.go | grep -v vendor | xargs go run mvdan.cc/gofumpt -l)"
else
echo "Checking all files..."
gofmt_files="$(find . -name '*.go' | grep -v pb.go | grep -v vendor | xargs go run mvdan.cc/gofumpt -l)"
fi
if [[ -n "${gofmt_files}" ]]; then
echo 'gofumpt needs running on the following files:'
echo "${gofmt_files}"