scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-11-02 11:38:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

UI: fix default values resetting form inputs (#22458)

Browse Source
This commit is contained in:
claire bontempo
2023-08-20 10:55:41 -07:00
committed by GitHub
parent 98523a6874
commit abd6324e50
3 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
changelog/22458.txt Normal file
View File

@@ -0,0 +1,3 @@
```release-note:bug
ui: fixes model defaults overwriting input value when user tries to clear form input
```

3
ui/lib/core/addon/components/form-field.hbs
View File

@@ -306,8 +306,9 @@
disabled={{and @attr.options.editDisabled (not @model.isNew)}} disabled={{and @attr.options.editDisabled (not @model.isNew)}}
autocomplete="off" autocomplete="off"
spellcheck="false" spellcheck="false"
value={{or (get @model this.valuePath) @attr.options.defaultValue}} value={{get @model this.valuePath}}
{{on "change" this.onChangeWithEvent}} {{on "change" this.onChangeWithEvent}}
{{on "input" this.onChangeWithEvent}}
{{on "keyup" this.handleKeyUp}} {{on "keyup" this.handleKeyUp}}
class="input {{if this.validationError 'has-error-border'}}" class="input {{if this.validationError 'has-error-border'}}"
maxLength={{@attr.options.characterLimit}} maxLength={{@attr.options.characterLimit}}

3
ui/tests/integration/components/form-field-test.js
View File

@@ -26,7 +26,8 @@ module('Integration | Component | form field', function (hooks) {
}; };
const setup = async function (attr) { const setup = async function (attr) {
const model = EmberObject.create({}); // ember sets model attrs from the defaultValue key, mimicking that behavior here
const model = EmberObject.create({ [attr.name]: attr.options?.defaultValue });
const spy = sinon.spy(); const spy = sinon.spy();
this.set('onChange', spy); this.set('onChange', spy);
this.set('model', model); this.set('model', model);