scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-10-30 02:02:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update GRPC functions to send rotation window and period as seconds explicitly (#29721)

Browse Source
This commit is contained in:
kpcraig
2025-02-26 16:13:46 -05:00
committed by GitHub
parent b8e8620882
commit b078978b00
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
sdk/plugin/grpc_system.go
View File

@@ -234,8 +234,10 @@ func (s *gRPCSystemViewClient) RegisterRotationJob(ctx context.Context, req *rot
MountPoint: req.MountPoint, MountPoint: req.MountPoint,
Path: req.ReqPath, Path: req.ReqPath,
RotationSchedule: req.RotationSchedule, RotationSchedule: req.RotationSchedule,
RotationWindow: int64(req.RotationWindow),
RotationPeriod: int64(req.RotationPeriod), // on the side outbound from the plugin, we convert duration to seconds, so seconds get sent over the wire
RotationWindow: int64(req.RotationWindow.Seconds()),
RotationPeriod: int64(req.RotationPeriod.Seconds()),
}, },
} }
resp, err := s.client.RegisterRotationJob(ctx, cfgReq) resp, err := s.client.RegisterRotationJob(ctx, cfgReq)
@@ -472,8 +474,11 @@ func (s *gRPCSystemViewServer) RegisterRotationJob(ctx context.Context, req *pb.
MountPoint: req.Job.MountPoint, MountPoint: req.Job.MountPoint,
ReqPath: req.Job.Path, ReqPath: req.Job.Path,
RotationSchedule: req.Job.RotationSchedule, RotationSchedule: req.Job.RotationSchedule,
RotationWindow: time.Duration(req.Job.RotationWindow) * time.Second, // on the side inbound to vault, we convert seconds back to time.Duration
RotationPeriod: time.Duration(req.Job.RotationPeriod) * time.Second, // Note: this value is seconds (as per the outbound client call, despite being int64)
// The field is int64 because of gRPC reasons, not time.Duration reasons
RotationWindow: time.Duration(req.Job.RotationWindow) * time.Second,
RotationPeriod: time.Duration(req.Job.RotationPeriod) * time.Second,
} }
rotationID, err := s.impl.RegisterRotationJob(ctx, cfgReq) rotationID, err := s.impl.RegisterRotationJob(ctx, cfgReq)