scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-11-02 03:27:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revoke temporary cred after creation, update warning

Browse Source 
/cc @vishalnayak
This commit is contained in:
Seth Vargo
2017-08-17 18:35:55 -04:00
parent 72f66559eb
commit b5fd472cc1
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
command/ssh.go
View File

@@ -159,8 +159,10 @@ func (c *SSHCommand) Run(args []string) int {
"WARNING: No -mode specified. Use -mode to tell Vault which ssh\n" + "WARNING: No -mode specified. Use -mode to tell Vault which ssh\n" +
"authentication mode to use. In the future, you will need to tell\n" + "authentication mode to use. In the future, you will need to tell\n" +
"Vault which mode to use. For now, Vault will attempt to guess based\n" + "Vault which mode to use. For now, Vault will attempt to guess based\n" +
"on the API response.") "on the API response. This guess involves creating a temporary\n" +
_, cred, err := c.generateCredential() "credential, reading its type, and then revoking it. To reduce the\n" +
"number of API calls and surface area, specify -mode directly.")
secret, cred, err := c.generateCredential()
if err != nil { if err != nil {
// This is _very_ hacky, but is the only sane backwards-compatible way // This is _very_ hacky, but is the only sane backwards-compatible way
// to do this. If the error is "key type unknown", we just assume the // to do this. If the error is "key type unknown", we just assume the
@@ -174,6 +176,14 @@ func (c *SSHCommand) Run(args []string) int {
} else { } else {
c.mode = cred.KeyType c.mode = cred.KeyType
} }
// Revoke the secret, since the child functions will generate their own
// credential. Users wishing to avoid this should specify -mode.
if secret != nil {
if err := c.client.Sys().Revoke(secret.LeaseID); err != nil {
c.Ui.Warn(fmt.Sprintf("Failed to revoke temporary key: %s", err))
}
}
} }
switch strings.ToLower(c.mode) { switch strings.ToLower(c.mode) {