From c855f6e982bd821fc5985465b9c899b52294eb9d Mon Sep 17 00:00:00 2001 From: Victor Rodriguez Date: Mon, 4 Nov 2024 15:51:01 -0500 Subject: [PATCH] Fix bug setting PKI issuer enable_aia_url_templating to be set to false (#28832) Fix bug setting PKI issuer enable_aia_url_templating to be set to false. --- builtin/logical/pki/path_fetch_issuers.go | 2 +- changelog/28832.txt | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 changelog/28832.txt diff --git a/builtin/logical/pki/path_fetch_issuers.go b/builtin/logical/pki/path_fetch_issuers.go index 5d2a70e68f..094e4eb55c 100644 --- a/builtin/logical/pki/path_fetch_issuers.go +++ b/builtin/logical/pki/path_fetch_issuers.go @@ -913,7 +913,7 @@ func (b *backend) pathPatchIssuer(ctx context.Context, req *logical.Request, dat if enableTemplatingRaw, ok := data.GetOk("enable_aia_url_templating"); ok { enableTemplating := enableTemplatingRaw.(bool) if enableTemplating != issuer.AIAURIs.EnableTemplating { - issuer.AIAURIs.EnableTemplating = enableTemplating // TODO: Is this correct? If it is, does it need to be backported? + issuer.AIAURIs.EnableTemplating = enableTemplating modified = true } } diff --git a/changelog/28832.txt b/changelog/28832.txt new file mode 100644 index 0000000000..1219900bd4 --- /dev/null +++ b/changelog/28832.txt @@ -0,0 +1,4 @@ +```release-note:bug +secret/pki: Fix a bug that prevents PKI issuer field enable_aia_url_templating +to be set to false. +```