Backend() functions should return 'backend' objects.

If they return pointers to 'framework.Backend' objects, the receiver functions can't be tested.
This commit is contained in:
vishalnayak
2016-06-10 15:53:02 -04:00
parent 117200c88a
commit cfe0aa860e
9 changed files with 18 additions and 18 deletions

View File

@@ -12,7 +12,7 @@ func Factory(conf *logical.BackendConfig) (logical.Backend, error) {
return Backend().Setup(conf) return Backend().Setup(conf)
} }
func Backend() *framework.Backend { func Backend() *backend {
var b backend var b backend
b.Map = &framework.PolicyMap{ b.Map = &framework.PolicyMap{
PathMap: framework.PathMap{ PathMap: framework.PathMap{
@@ -37,7 +37,7 @@ func Backend() *framework.Backend {
AuthRenew: b.pathLoginRenew, AuthRenew: b.pathLoginRenew,
} }
return b.Backend return &b
} }
type backend struct { type backend struct {

View File

@@ -15,7 +15,7 @@ func Factory(conf *logical.BackendConfig) (logical.Backend, error) {
return Backend().Setup(conf) return Backend().Setup(conf)
} }
func Backend() *framework.Backend { func Backend() *backend {
var b backend var b backend
b.Backend = &framework.Backend{ b.Backend = &framework.Backend{
Help: backendHelp, Help: backendHelp,
@@ -41,7 +41,7 @@ func Backend() *framework.Backend {
AuthRenew: b.pathLoginRenew, AuthRenew: b.pathLoginRenew,
} }
return b.Backend return &b
} }
type backend struct { type backend struct {

View File

@@ -10,7 +10,7 @@ func Factory(conf *logical.BackendConfig) (logical.Backend, error) {
return Backend().Setup(conf) return Backend().Setup(conf)
} }
func Backend() *framework.Backend { func Backend() *backend {
var b backend var b backend
b.Backend = &framework.Backend{ b.Backend = &framework.Backend{
Help: backendHelp, Help: backendHelp,
@@ -35,7 +35,7 @@ func Backend() *framework.Backend {
AuthRenew: b.pathLoginRenew, AuthRenew: b.pathLoginRenew,
} }
return b.Backend return &b
} }
type backend struct { type backend struct {

View File

@@ -12,7 +12,7 @@ func Factory(conf *logical.BackendConfig) (logical.Backend, error) {
return Backend().Setup(conf) return Backend().Setup(conf)
} }
func Backend() *framework.Backend { func Backend() *backend {
var b backend var b backend
b.Backend = &framework.Backend{ b.Backend = &framework.Backend{
Help: strings.TrimSpace(backendHelp), Help: strings.TrimSpace(backendHelp),
@@ -33,7 +33,7 @@ func Backend() *framework.Backend {
WALRollbackMinAge: 5 * time.Minute, WALRollbackMinAge: 5 * time.Minute,
} }
return b.Backend return &b
} }
type backend struct { type backend struct {

View File

@@ -16,7 +16,7 @@ func Factory(conf *logical.BackendConfig) (logical.Backend, error) {
} }
// Backend contains the base information for the backend's functionality // Backend contains the base information for the backend's functionality
func Backend() *framework.Backend { func Backend() *backend {
var b backend var b backend
b.Backend = &framework.Backend{ b.Backend = &framework.Backend{
Help: strings.TrimSpace(backendHelp), Help: strings.TrimSpace(backendHelp),
@@ -32,7 +32,7 @@ func Backend() *framework.Backend {
}, },
} }
return b.Backend return &b
} }
type backend struct { type backend struct {

View File

@@ -15,7 +15,7 @@ func Factory(conf *logical.BackendConfig) (logical.Backend, error) {
return Backend().Setup(conf) return Backend().Setup(conf)
} }
func Backend() *framework.Backend { func Backend() *backend {
var b backend var b backend
b.Backend = &framework.Backend{ b.Backend = &framework.Backend{
Help: strings.TrimSpace(backendHelp), Help: strings.TrimSpace(backendHelp),
@@ -33,7 +33,7 @@ func Backend() *framework.Backend {
}, },
} }
return b.Backend return &b
} }
type backend struct { type backend struct {

View File

@@ -15,7 +15,7 @@ func Factory(conf *logical.BackendConfig) (logical.Backend, error) {
return Backend().Setup(conf) return Backend().Setup(conf)
} }
func Backend() *framework.Backend { func Backend() *backend {
var b backend var b backend
b.Backend = &framework.Backend{ b.Backend = &framework.Backend{
Help: strings.TrimSpace(backendHelp), Help: strings.TrimSpace(backendHelp),
@@ -33,7 +33,7 @@ func Backend() *framework.Backend {
}, },
} }
return b.Backend return &b
} }
type backend struct { type backend struct {

View File

@@ -15,7 +15,7 @@ func Factory(conf *logical.BackendConfig) (logical.Backend, error) {
} }
// Backend returns a new Backend framework struct // Backend returns a new Backend framework struct
func Backend() *framework.Backend { func Backend() *backend {
var b backend var b backend
b.Backend = &framework.Backend{ b.Backend = &framework.Backend{
Help: strings.TrimSpace(backendHelp), Help: strings.TrimSpace(backendHelp),
@@ -60,7 +60,7 @@ func Backend() *framework.Backend {
b.crlLifetime = time.Hour * 72 b.crlLifetime = time.Hour * 72
return b.Backend return &b
} }
type backend struct { type backend struct {

View File

@@ -14,7 +14,7 @@ func Factory(conf *logical.BackendConfig) (logical.Backend, error) {
return Backend().Setup(conf) return Backend().Setup(conf)
} }
func Backend() *framework.Backend { func Backend() *backend {
var b backend var b backend
b.Backend = &framework.Backend{ b.Backend = &framework.Backend{
Help: strings.TrimSpace(backendHelp), Help: strings.TrimSpace(backendHelp),
@@ -34,7 +34,7 @@ func Backend() *framework.Backend {
Clean: b.ResetDB, Clean: b.ResetDB,
} }
return b.Backend return &b
} }
type backend struct { type backend struct {