Ember Upgrade to 4.4 (#17086)

* runs ember-cli-update to 4.4.0

* updates yarn.lock

* updates dependencies causing runtime errors (#17135)

* Inject Store Service When Accessed Implicitly (#17345)

* adds codemod for injecting store service

* adds custom babylon parser with decorators-legacy plugin for jscodeshift transforms

* updates inject-store-service codemod to only look for .extend object expressions and adds recast options

* runs inject-store-service codemod on js files

* replace query-params helper with hash (#17404)

* Updates/removes dependencies throwing errors in Ember 4.4 (#17396)

* updates ember-responsive to latest

* updates ember-composable-helpers to latest and uses includes helper since contains was removed

* updates ember-concurrency to latest

* updates ember-cli-clipboard to latest

* temporary workaround for toolbar-link component throwing errors for using params arg with LinkTo

* adds missing store injection to auth configure route

* fixes issue with string-list component throwing error for accessing prop in same computation

* fixes non-iterable query params issue in mfa methods controller

* refactors field-to-attrs to handle belongsTo rather than fragments

* converts mount-config fragment to belongsTo on auth-method model

* removes ember-api-actions and adds tune method to auth-method adapter

* converts cluster replication attributes from fragment to relationship

* updates ember-data, removes ember-data-fragments and updates yarn to latest

* removes fragments from secret-engine model

* removes fragment from test-form-model

* removes commented out code

* minor change to inject-store-service codemod and runs again on js files

* Remove LinkTo positional params (#17421)

* updates ember-cli-page-object to latest version

* update toolbar-link to support link-to args and not positional params

* adds replace arg to toolbar-link component

* Clean up js lint errors (#17426)

* replaces assert.equal to assert.strictEqual

* update eslint no-console to error and disables invididual intended uses of console

* cleans up hbs lint warnings (#17432)

* Upgrade bug and test fixes (#17500)

* updates inject-service codemod to take arg for service name and runs for flashMessages service

* fixes hbs lint error after merging main

* fixes flash messages

* updates more deps

* bug fixes

* test fixes

* updates ember-cli-content-security-policy and prevents default form submission throwing errors

* more bug and test fixes

* removes commented out code

* fixes issue with code-mirror modifier sending change event on setup causing same computation error

* Upgrade Clean Up (#17543)

* updates deprecation workflow and filter

* cleans up build errors, removes unused ivy-codemirror and sass and updates ember-cli-sass and node-sass to latest

* fixes control groups test that was skipped after upgrade

* updates control group service tests

* addresses review feedback

* updates control group service handleError method to use router.currentURL rather that transition.intent.url

* adds changelog entry
This commit is contained in:
Jordan Reimer
2022-10-18 09:46:02 -06:00
committed by GitHub
parent 55a3b1d41e
commit d4766766f2
477 changed files with 180338 additions and 3306 deletions

View File

@@ -248,7 +248,7 @@ module('Acceptance | secrets/database/*', function (hooks) {
let backend = `database-${Date.now()}`;
await mountSecrets.enable('database', backend);
await settled();
assert.equal(
assert.strictEqual(
currentURL(),
`/vault/secrets/${backend}/list`,
'Mounts and redirects to connection list page'
@@ -258,7 +258,7 @@ module('Acceptance | secrets/database/*', function (hooks) {
.dom('.active[data-test-secret-list-tab="Connections"]')
.exists('Has Connections tab which is active');
await click('[data-test-tab="overview"]');
assert.equal(currentURL(), `/vault/secrets/${backend}/overview`, 'Tab links to overview page');
assert.strictEqual(currentURL(), `/vault/secrets/${backend}/overview`, 'Tab links to overview page');
assert.dom('[data-test-component="empty-state"]').exists('Empty state also exists on overview page');
assert.dom('[data-test-secret-list-tab="Roles"]').exists('Has Roles tab');
});
@@ -268,7 +268,7 @@ module('Acceptance | secrets/database/*', function (hooks) {
const backend = await mount();
for (let testCase of connectionTests) {
await connectionPage.visitCreate({ backend });
assert.equal(currentURL(), `/vault/secrets/${backend}/create`, 'Correct creation URL');
assert.strictEqual(currentURL(), `/vault/secrets/${backend}/create`, 'Correct creation URL');
assert
.dom('[data-test-empty-state-title]')
.hasText('No plugin selected', 'No plugin is selected by default and empty state shows');
@@ -316,7 +316,7 @@ module('Acceptance | secrets/database/*', function (hooks) {
// click "Add Role"
await connectionPage.addRole();
await settled();
assert.equal(
assert.strictEqual(
searchSelectComponent.selectedOptions[0].text,
testCase.name,
'Database connection is pre-selected on the form'
@@ -338,13 +338,13 @@ module('Acceptance | secrets/database/*', function (hooks) {
{ label: 'Write concern', name: 'write_concern' },
],
};
assert.equal(
assert.strictEqual(
currentURL(),
`/vault/secrets/${backend}/list`,
'Mounts and redirects to connection list page'
);
await connectionPage.createLink();
assert.equal(currentURL(), `/vault/secrets/${backend}/create`, 'Create link goes to create page');
assert.strictEqual(currentURL(), `/vault/secrets/${backend}/create`, 'Create link goes to create page');
assert
.dom('[data-test-empty-state-title]')
.hasText('No plugin selected', 'No plugin is selected by default and empty state shows');
@@ -366,7 +366,7 @@ module('Acceptance | secrets/database/*', function (hooks) {
.dom('.modal.is-active .title')
.hasText('Rotate your root credentials?', 'Modal appears asking to ');
await connectionPage.enable();
assert.equal(
assert.strictEqual(
currentURL(),
`/vault/secrets/${backend}/show/${connectionDetails.id}`,
'Saves connection and takes you to show page'
@@ -389,7 +389,7 @@ module('Acceptance | secrets/database/*', function (hooks) {
await fillIn('[data-test-confirmation-modal-input="Delete connection?"]', connectionDetails.id);
await click('[data-test-confirm-button]');
assert.equal(currentURL(), `/vault/secrets/${backend}/list`, 'Redirects to connection list page');
assert.strictEqual(currentURL(), `/vault/secrets/${backend}/list`, 'Redirects to connection list page');
assert
.dom('[data-test-empty-state-title]')
.hasText('No connections in this backend', 'No connections listed because it was deleted');
@@ -427,7 +427,11 @@ module('Acceptance | secrets/database/*', function (hooks) {
await logout.visit();
await authPage.login(token);
await connectionPage.visitShow({ backend, id: connection });
assert.equal(currentURL(), `/vault/secrets/${backend}/show/${connection}`, 'Allows reading connection');
assert.strictEqual(
currentURL(),
`/vault/secrets/${backend}/show/${connection}`,
'Allows reading connection'
);
assert
.dom('[data-test-database-connection-delete]')
.doesNotExist('Delete button does not show due to permissions');
@@ -457,7 +461,7 @@ module('Acceptance | secrets/database/*', function (hooks) {
.dom('[data-test-component="empty-state"]')
.exists({ count: 2 }, 'Two empty states exist before selections made');
await clickTrigger('#database');
assert.equal(searchSelectComponent.options.length, 1, 'list shows existing connections so far');
assert.strictEqual(searchSelectComponent.options.length, 1, 'list shows existing connections so far');
await selectChoose('#database', '.ember-power-select-option', 0);
assert
.dom('[data-test-component="empty-state"]')
@@ -514,7 +518,7 @@ module('Acceptance | secrets/database/*', function (hooks) {
assert.dom('[data-test-secret-list-tab="Roles"]').exists('renders connections tab');
await click('[data-test-secret-create="connections"]');
assert.equal(currentURL(), '/vault/secrets/database/create');
assert.strictEqual(currentURL(), '/vault/secrets/database/create');
// Login with restricted policy
await logout.visit();
@@ -532,6 +536,6 @@ module('Acceptance | secrets/database/*', function (hooks) {
.exists({ count: 1 }, 'renders only the connection card');
await click('[data-test-action-text="Configure new"]');
assert.equal(currentURL(), '/vault/secrets/database/create?itemType=connection');
assert.strictEqual(currentURL(), '/vault/secrets/database/create?itemType=connection');
});
});