mirror of
https://github.com/optim-enterprises-bv/vault.git
synced 2025-11-20 11:55:11 +00:00
Ember Upgrade to 4.4 (#17086)
* runs ember-cli-update to 4.4.0 * updates yarn.lock * updates dependencies causing runtime errors (#17135) * Inject Store Service When Accessed Implicitly (#17345) * adds codemod for injecting store service * adds custom babylon parser with decorators-legacy plugin for jscodeshift transforms * updates inject-store-service codemod to only look for .extend object expressions and adds recast options * runs inject-store-service codemod on js files * replace query-params helper with hash (#17404) * Updates/removes dependencies throwing errors in Ember 4.4 (#17396) * updates ember-responsive to latest * updates ember-composable-helpers to latest and uses includes helper since contains was removed * updates ember-concurrency to latest * updates ember-cli-clipboard to latest * temporary workaround for toolbar-link component throwing errors for using params arg with LinkTo * adds missing store injection to auth configure route * fixes issue with string-list component throwing error for accessing prop in same computation * fixes non-iterable query params issue in mfa methods controller * refactors field-to-attrs to handle belongsTo rather than fragments * converts mount-config fragment to belongsTo on auth-method model * removes ember-api-actions and adds tune method to auth-method adapter * converts cluster replication attributes from fragment to relationship * updates ember-data, removes ember-data-fragments and updates yarn to latest * removes fragments from secret-engine model * removes fragment from test-form-model * removes commented out code * minor change to inject-store-service codemod and runs again on js files * Remove LinkTo positional params (#17421) * updates ember-cli-page-object to latest version * update toolbar-link to support link-to args and not positional params * adds replace arg to toolbar-link component * Clean up js lint errors (#17426) * replaces assert.equal to assert.strictEqual * update eslint no-console to error and disables invididual intended uses of console * cleans up hbs lint warnings (#17432) * Upgrade bug and test fixes (#17500) * updates inject-service codemod to take arg for service name and runs for flashMessages service * fixes hbs lint error after merging main * fixes flash messages * updates more deps * bug fixes * test fixes * updates ember-cli-content-security-policy and prevents default form submission throwing errors * more bug and test fixes * removes commented out code * fixes issue with code-mirror modifier sending change event on setup causing same computation error * Upgrade Clean Up (#17543) * updates deprecation workflow and filter * cleans up build errors, removes unused ivy-codemirror and sass and updates ember-cli-sass and node-sass to latest * fixes control groups test that was skipped after upgrade * updates control group service tests * addresses review feedback * updates control group service handleError method to use router.currentURL rather that transition.intent.url * adds changelog entry
This commit is contained in:
@@ -623,7 +623,7 @@ module('Integration | Util | client count utils', function (hooks) {
|
||||
: ['clients', 'distinct_entities', 'non_entity_tokens'];
|
||||
|
||||
newObjectKeys.forEach((key, i) => {
|
||||
assert.equal(
|
||||
assert.strictEqual(
|
||||
object[key],
|
||||
originalObject.counts[originalKeys[i]],
|
||||
`${object.month} ${key} equal original counts`
|
||||
@@ -678,7 +678,7 @@ module('Integration | Util | client count utils', function (hooks) {
|
||||
timestamp: '2021-07-01T00:00:00Z',
|
||||
},
|
||||
];
|
||||
assert.equal(formatByMonths(SOME_OBJECT), SOME_OBJECT, 'it returns if arg is not an array');
|
||||
assert.strictEqual(formatByMonths(SOME_OBJECT), SOME_OBJECT, 'it returns if arg is not an array');
|
||||
assert.propEqual(expected, formatByMonths(EMPTY_MONTHS), 'it does not error with null months');
|
||||
assert.ok(formatByMonths([...EMPTY_MONTHS, ...MONTHS]), 'it does not error with combined data');
|
||||
});
|
||||
@@ -698,10 +698,10 @@ module('Integration | Util | client count utils', function (hooks) {
|
||||
};
|
||||
const keyValueAssertions = (object, pathName, originalObject) => {
|
||||
const keysToAssert = ['clients', 'entity_clients', 'non_entity_clients'];
|
||||
assert.equal(object.label, originalObject[pathName], `${pathName} matches label`);
|
||||
assert.strictEqual(object.label, originalObject[pathName], `${pathName} matches label`);
|
||||
|
||||
keysToAssert.forEach((key) => {
|
||||
assert.equal(object[key], originalObject.counts[key], `number of ${key} equal original`);
|
||||
assert.strictEqual(object[key], originalObject.counts[key], `number of ${key} equal original`);
|
||||
});
|
||||
};
|
||||
|
||||
@@ -736,9 +736,9 @@ module('Integration | Util | client count utils', function (hooks) {
|
||||
let formattedNsWithoutMounts = formatByNamespace([nsWithoutMounts])[0];
|
||||
keyNameAssertions(formattedNsWithoutMounts, 'namespace without mounts');
|
||||
keyValueAssertions(formattedNsWithoutMounts, 'namespace_path', nsWithoutMounts);
|
||||
assert.equal(formattedNsWithoutMounts.mounts.length, 0, 'formatted namespace has no mounts');
|
||||
assert.strictEqual(formattedNsWithoutMounts.mounts.length, 0, 'formatted namespace has no mounts');
|
||||
|
||||
assert.equal(formatByNamespace(SOME_OBJECT), SOME_OBJECT, 'it returns if arg is not an array');
|
||||
assert.strictEqual(formatByNamespace(SOME_OBJECT), SOME_OBJECT, 'it returns if arg is not an array');
|
||||
});
|
||||
|
||||
test('homogenizeClientNaming: homogenizes key names when both old and new keys exist, or just old key names', async function (assert) {
|
||||
@@ -814,13 +814,13 @@ module('Integration | Util | client count utils', function (hooks) {
|
||||
keyNameAssertions(flattenedMonth, 'month object');
|
||||
keyNameAssertions(flattenedNewMonthClients, 'month new_clients object');
|
||||
|
||||
assert.equal(
|
||||
assert.strictEqual(
|
||||
flattenDataset(SOME_OBJECT),
|
||||
SOME_OBJECT,
|
||||
"it returns original object if counts key doesn't exist"
|
||||
);
|
||||
|
||||
assert.equal(
|
||||
assert.strictEqual(
|
||||
flattenDataset(objectNullCounts),
|
||||
objectNullCounts,
|
||||
'it returns original object if counts are null'
|
||||
@@ -831,8 +831,8 @@ module('Integration | Util | client count utils', function (hooks) {
|
||||
flattenDataset(['some array']),
|
||||
'it fails gracefully if an array is passed in'
|
||||
);
|
||||
assert.equal(flattenDataset(null), null, 'it fails gracefully if null is passed in');
|
||||
assert.equal(
|
||||
assert.strictEqual(flattenDataset(null), null, 'it fails gracefully if null is passed in');
|
||||
assert.strictEqual(
|
||||
flattenDataset('some string'),
|
||||
'some string',
|
||||
'it fails gracefully if a string is passed in'
|
||||
@@ -856,7 +856,7 @@ module('Integration | Util | client count utils', function (hooks) {
|
||||
'third timestamp date is later second'
|
||||
);
|
||||
assert.notEqual(sortedMonths[1], MONTHS[1], 'it does not modify original array');
|
||||
assert.equal(sortedMonths[0], MONTHS[0], 'it does not modify original array');
|
||||
assert.strictEqual(sortedMonths[0], MONTHS[0], 'it does not modify original array');
|
||||
});
|
||||
|
||||
test('namespaceArrayToObject: transforms data without modifying original', async function (assert) {
|
||||
@@ -866,7 +866,7 @@ module('Integration | Util | client count utils', function (hooks) {
|
||||
let valuesToCheck = ['clients', 'entity_clients', 'non_entity_clients'];
|
||||
|
||||
valuesToCheck.forEach((key) => {
|
||||
assert.equal(object[key], originalObject[key], `${key} equal original counts`);
|
||||
assert.strictEqual(object[key], originalObject[key], `${key} equal original counts`);
|
||||
});
|
||||
};
|
||||
const totalClientsByNamespace = formatByNamespace(MONTHS[1].namespaces);
|
||||
|
||||
Reference in New Issue
Block a user