Incorporate Ember Flight Icons (#12976)

* adds ember-flight-icons dependecy

* adds inline-json-import babel plugin

* adds flight icon styling

* updates Icon component to support flight icons

* updates Icon component usages to new api and updates name values to flight icon set when available

* fixes tests

* updates icon story with flight mappings and fixes issue with flight icons not rendering in storybook

* adds changelog

* fixes typo in sign action glyph name in transit-key model

* adds comments to icon-map

* updates Icon component to use only supported flight icon sizes

* adds icon transform codemod

* updates icon transform formatting to handle edge case

* runs icon transform on templates

* updates Icon usage in toolbar-filter md and story

* updates tests
This commit is contained in:
Jordan Reimer
2021-12-07 10:05:14 -07:00
committed by GitHub
parent 3e829466b7
commit d8112714cf
169 changed files with 837 additions and 412 deletions

View File

@@ -87,7 +87,9 @@ module('Integration | Component | InfoTableRow', function(hooks) {
await triggerEvent('[data-test-value-div="test label"] .ember-basic-dropdown-trigger', 'mouseenter');
await settled();
assert.dom('[data-test-tooltip-copy]').hasAttribute('disabled', '', 'Tooltip copy button is disabled');
assert.dom('[data-test-tooltip-copy]').doesNotHaveClass('has-pointer', 'Pointer class not applied when disabled');
assert
.dom('[data-test-tooltip-copy]')
.doesNotHaveClass('has-pointer', 'Pointer class not applied when disabled');
this.set('isCopyable', true);
assert.dom('[data-test-tooltip-copy]').doesNotHaveAttribute('disabled', 'Tooltip copy button is enabled');
assert.dom('[data-test-tooltip-copy]').hasClass('has-pointer', 'Pointer class applied to copy button');
@@ -127,17 +129,17 @@ module('Integration | Component | InfoTableRow', function(hooks) {
@defaultShown={{default}}
/>`);
assert.dom('div.column span').hasClass('hs-icon-s', 'Renders a dash (-) for the label');
assert.dom('div.column.is-one-quarter .flight-icon').exists('Renders a dash (-) for the label');
this.set('value', '');
this.set('label', LABEL);
assert.dom('div.column.is-flex span').hasClass('hs-icon-s', 'Renders a dash (-) for empty string value');
assert.dom('div.column.is-flex .flight-icon').exists('Renders a dash (-) for empty string value');
this.set('value', null);
assert.dom('div.column.is-flex span').hasClass('hs-icon-s', 'Renders a dash (-) for null value');
assert.dom('div.column.is-flex .flight-icon').exists('Renders a dash (-) for null value');
this.set('value', undefined);
assert.dom('div.column.is-flex span').hasClass('hs-icon-s', 'Renders a dash (-) for undefined value');
assert.dom('div.column.is-flex .flight-icon').exists('Renders a dash (-) for undefined value');
this.set('default', DEFAULT);
assert.dom('[data-test-value-div]').hasText(DEFAULT, 'Renders default text if value is empty');
@@ -145,7 +147,7 @@ module('Integration | Component | InfoTableRow', function(hooks) {
this.set('value', '');
this.set('label', '');
this.set('default', '');
let dashCount = document.querySelectorAll('.hs-icon-s').length;
let dashCount = document.querySelectorAll('.flight-icon').length;
assert.equal(dashCount, 2, 'Renders dash (-) when both label and value do not exist (and no defaults)');
});