Add stmt close calls

This commit is contained in:
Jeff Mitchell
2016-06-29 17:39:47 -04:00
parent fb9a4a15c5
commit d9fa64a07c
5 changed files with 5 additions and 2 deletions

View File

@@ -90,6 +90,7 @@ func (b *backend) pathCredsCreateRead(
if err != nil { if err != nil {
return nil, err return nil, err
} }
defer stmt.Close()
if _, err := stmt.Exec(); err != nil { if _, err := stmt.Exec(); err != nil {
return nil, err return nil, err
} }

View File

@@ -133,6 +133,7 @@ func (b *backend) secretCredsRevoke(
lastStmtError = err lastStmtError = err
continue continue
} }
defer stmt.Close()
_, err = stmt.Exec() _, err = stmt.Exec()
if err != nil { if err != nil {
lastStmtError = err lastStmtError = err

View File

@@ -90,6 +90,7 @@ func (b *backend) pathRoleCreateRead(
if err != nil { if err != nil {
return nil, err return nil, err
} }
defer stmt.Close()
if _, err := stmt.Exec(); err != nil { if _, err := stmt.Exec(); err != nil {
return nil, err return nil, err
} }

View File

@@ -101,7 +101,6 @@ func (b *backend) pathRoleCreateRead(
// Execute each query // Execute each query
for _, query := range SplitSQL(role.SQL) { for _, query := range SplitSQL(role.SQL) {
b.logger.Println("[WARN] postgres/pathRoleCreateRead: preparing statement") b.logger.Println("[WARN] postgres/pathRoleCreateRead: preparing statement")
stmt, err := tx.Prepare(Query(query, map[string]string{ stmt, err := tx.Prepare(Query(query, map[string]string{
"name": username, "name": username,
@@ -111,7 +110,7 @@ func (b *backend) pathRoleCreateRead(
if err != nil { if err != nil {
return nil, err return nil, err
} }
defer stmt.Close()
b.logger.Println("[WARN] postgres/pathRoleCreateRead: executing statement") b.logger.Println("[WARN] postgres/pathRoleCreateRead: executing statement")
if _, err := stmt.Exec(); err != nil { if _, err := stmt.Exec(); err != nil {
return nil, err return nil, err

View File

@@ -163,6 +163,7 @@ func (b *backend) secretCredsRevoke(
lastStmtError = err lastStmtError = err
continue continue
} }
defer stmt.Close()
_, err = stmt.Exec() _, err = stmt.Exec()
if err != nil { if err != nil {
lastStmtError = err lastStmtError = err