Errwrap everywhere (#4252)

* package api

* package builtin/credential

* package builtin/logical

* package command

* package helper

* package http and logical

* package physical

* package shamir

* package vault

* package vault

* address feedback

* more fixes
This commit is contained in:
Vishal Nayak
2018-04-05 11:49:21 -04:00
committed by GitHub
parent f13a832a9f
commit e2bb2ec3b9
159 changed files with 811 additions and 741 deletions

View File

@@ -134,7 +134,7 @@ func NewDynamoDBBackend(conf map[string]string, logger log.Logger) (physical.Bac
}
readCapacity, err := strconv.Atoi(readCapacityString)
if err != nil {
return nil, fmt.Errorf("invalid read capacity: %s", readCapacityString)
return nil, fmt.Errorf("invalid read capacity: %q", readCapacityString)
}
if readCapacity == 0 {
readCapacity = DefaultDynamoDBReadCapacity
@@ -149,7 +149,7 @@ func NewDynamoDBBackend(conf map[string]string, logger log.Logger) (physical.Bac
}
writeCapacity, err := strconv.Atoi(writeCapacityString)
if err != nil {
return nil, fmt.Errorf("invalid write capacity: %s", writeCapacityString)
return nil, fmt.Errorf("invalid write capacity: %q", writeCapacityString)
}
if writeCapacity == 0 {
writeCapacity = DefaultDynamoDBWriteCapacity
@@ -192,7 +192,7 @@ func NewDynamoDBBackend(conf map[string]string, logger log.Logger) (physical.Bac
var err error
dynamodbMaxRetry, err = strconv.Atoi(dynamodbMaxRetryString)
if err != nil {
return nil, fmt.Errorf("invalid max retry: %s", dynamodbMaxRetryString)
return nil, fmt.Errorf("invalid max retry: %q", dynamodbMaxRetryString)
}
}
@@ -261,7 +261,7 @@ func (d *DynamoDBBackend) Put(ctx context.Context, entry *physical.Entry) error
}
item, err := dynamodbattribute.ConvertToMap(record)
if err != nil {
return fmt.Errorf("could not convert prefix record to DynamoDB item: %s", err)
return errwrap.Wrapf("could not convert prefix record to DynamoDB item: {{err}}", err)
}
requests := []*dynamodb.WriteRequest{{
PutRequest: &dynamodb.PutRequest{
@@ -276,7 +276,7 @@ func (d *DynamoDBBackend) Put(ctx context.Context, entry *physical.Entry) error
}
item, err := dynamodbattribute.ConvertToMap(record)
if err != nil {
return fmt.Errorf("could not convert prefix record to DynamoDB item: %s", err)
return errwrap.Wrapf("could not convert prefix record to DynamoDB item: {{err}}", err)
}
requests = append(requests, &dynamodb.WriteRequest{
PutRequest: &dynamodb.PutRequest{