Ember Upgrade to 3.24 (#13443)

* Update browserslist

* Add browserslistrc

* ember-cli-update --to 3.26, fix conflicts

* Run codemodes that start with ember-*

* More codemods - before cp*

* More codemods (curly data-test-*)

* WIP ember-basic-dropdown template errors

* updates ember-basic-dropdown and related deps to fix build issues

* updates basic dropdown instances to new version API

* updates more deps -- ember-template-lint is working again

* runs no-implicit-this codemod

* creates and runs no-quoteless-attributes codemod

* runs angle brackets codemod

* updates lint:hbs globs to only touch hbs files

* removes yield only templates

* creates and runs deprecated args transform

* supresses lint error for invokeAction on LinkTo component

* resolves remaining ambiguous path lint errors

* resolves simple-unless lint errors

* adds warnings for deprecated tagName arg on LinkTo components

* adds warnings for remaining curly component invocation

* updates global template lint rules

* resolves remaining template lint errors

* disables some ember specfic lint rules that target pre octane patterns

* js lint fix run

* resolves remaining js lint errors

* fixes test run

* adds npm-run-all dep

* fixes test attribute issues

* fixes console acceptance tests

* fixes tests

* adds yield only wizard/tutorial-active template

* fixes more tests

* attempts to fix more flaky tests

* removes commented out settled in transit test

* updates deprecations workflow and adds initializer to filter by version

* updates flaky policies acl old test

* updates to flaky transit test

* bumps ember deps down to LTS version

* runs linters after main merge

* fixes client count tests after bad merge conflict fixes

* fixes client count history test

* more updates to lint config

* another round of hbs lint fixes after extending stylistic rule

* updates lint-staged commands

* removes indent eslint rule since it seems to break things

* fixes bad attribute in transform-edit-form template

* test fixes

* fixes enterprise tests

* adds changelog

* removes deprecated ember-concurrency-test-waiters dep and adds @ember/test-waiters

* flaky test fix

Co-authored-by: hashishaw <cshaw@hashicorp.com>
This commit is contained in:
Jordan Reimer
2021-12-16 20:44:29 -07:00
committed by GitHub
parent 1aca2656f2
commit e5b1f718f1
1093 changed files with 14704 additions and 12316 deletions

View File

@@ -9,10 +9,10 @@ import kvObjectEditor from '../../pages/components/kv-object-editor';
import sinon from 'sinon';
const component = create(kvObjectEditor);
module('Integration | Component | kv object editor', function(hooks) {
module('Integration | Component | kv object editor', function (hooks) {
setupRenderingTest(hooks);
test('it renders with no initial value', async function(assert) {
test('it renders with no initial value', async function (assert) {
let spy = sinon.spy();
this.set('onChange', spy);
await render(hbs`{{kv-object-editor onChange=onChange}}`);
@@ -21,14 +21,11 @@ module('Integration | Component | kv object editor', function(hooks) {
assert.equal(component.rows.length, 1, 'will only render row with a blank key');
});
test('it calls onChange when the val changes', async function(assert) {
test('it calls onChange when the val changes', async function (assert) {
let spy = sinon.spy();
this.set('onChange', spy);
await render(hbs`{{kv-object-editor onChange=onChange}}`);
await component.rows
.objectAt(0)
.kvKey('foo')
.kvVal('bar');
await component.rows.objectAt(0).kvKey('foo').kvVal('bar');
assert.equal(spy.callCount, 2, 'calls onChange each time change is triggered');
assert.deepEqual(
spy.lastCall.args[0],
@@ -39,7 +36,7 @@ module('Integration | Component | kv object editor', function(hooks) {
assert.equal(component.rows.length, 2, 'adds a row when there is no blank one');
});
test('it renders passed data', async function(assert) {
test('it renders passed data', async function (assert) {
let metadata = { foo: 'bar', baz: 'bop' };
this.set('value', metadata);
await render(hbs`{{kv-object-editor value=value}}`);
@@ -50,14 +47,11 @@ module('Integration | Component | kv object editor', function(hooks) {
);
});
test('it deletes a row', async function(assert) {
test('it deletes a row', async function (assert) {
let spy = sinon.spy();
this.set('onChange', spy);
await render(hbs`{{kv-object-editor onChange=onChange}}`);
await component.rows
.objectAt(0)
.kvKey('foo')
.kvVal('bar');
await component.rows.objectAt(0).kvKey('foo').kvVal('bar');
await component.addRow();
assert.equal(component.rows.length, 2);
assert.equal(spy.callCount, 2, 'calls onChange for editing');
@@ -68,7 +62,7 @@ module('Integration | Component | kv object editor', function(hooks) {
assert.deepEqual(spy.lastCall.args[0], {}, 'last call to onChange is an empty object');
});
test('it shows a warning if there are duplicate keys', async function(assert) {
test('it shows a warning if there are duplicate keys', async function (assert) {
let metadata = { foo: 'bar', baz: 'bop' };
this.set('value', metadata);
await render(hbs`{{kv-object-editor value=value}}`);