From eb9272d26642ee9b8cc6826e6da3eece2b2c08ed Mon Sep 17 00:00:00 2001 From: Kianna <30884335+kiannaquach@users.noreply.github.com> Date: Thu, 2 Nov 2023 12:10:37 -0700 Subject: [PATCH] UI: Update secrets engines sidenav to title-casing (#23964) --- changelog/23964.txt | 3 +++ ui/app/components/sidebar/nav/cluster.hbs | 4 ++-- ui/tests/acceptance/secrets/backend/database/secret-test.js | 2 +- .../secrets/backend/kv/kv-v2-workflow-edge-cases-test.js | 2 +- ui/tests/acceptance/sidebar-nav-test.js | 2 +- ui/tests/integration/components/sidebar/nav/cluster-test.js | 2 +- ui/tests/pages/settings/mount-secret-backend.js | 2 +- 7 files changed, 10 insertions(+), 7 deletions(-) create mode 100644 changelog/23964.txt diff --git a/changelog/23964.txt b/changelog/23964.txt new file mode 100644 index 0000000000..7dcdf884dc --- /dev/null +++ b/changelog/23964.txt @@ -0,0 +1,3 @@ +```release-note:improvement +ui: Update sidebar Secrets engine to title case. +``` diff --git a/ui/app/components/sidebar/nav/cluster.hbs b/ui/app/components/sidebar/nav/cluster.hbs index a350e6aa15..c16c557809 100644 --- a/ui/app/components/sidebar/nav/cluster.hbs +++ b/ui/app/components/sidebar/nav/cluster.hbs @@ -10,8 +10,8 @@ {{#if (has-permission "access")}} { - await click('[data-test-sidebar-nav-link="Secrets engines"]'); + await click('[data-test-sidebar-nav-link="Secrets Engines"]'); return await click(PAGE.backends.link(backend)); }; diff --git a/ui/tests/acceptance/sidebar-nav-test.js b/ui/tests/acceptance/sidebar-nav-test.js index c264ef5682..d274c7a0e9 100644 --- a/ui/tests/acceptance/sidebar-nav-test.js +++ b/ui/tests/acceptance/sidebar-nav-test.js @@ -54,7 +54,7 @@ module('Acceptance | sidebar navigation', function (hooks) { const links = [ { label: 'Raft Storage', route: '/vault/storage/raft' }, { label: 'Seal Vault', route: '/vault/settings/seal' }, - { label: 'Secrets engines', route: '/vault/secrets' }, + { label: 'Secrets Engines', route: '/vault/secrets' }, { label: 'Dashboard', route: '/vault/dashboard' }, ]; diff --git a/ui/tests/integration/components/sidebar/nav/cluster-test.js b/ui/tests/integration/components/sidebar/nav/cluster-test.js index 59f8a53706..ccb9be3bcb 100644 --- a/ui/tests/integration/components/sidebar/nav/cluster-test.js +++ b/ui/tests/integration/components/sidebar/nav/cluster-test.js @@ -48,7 +48,7 @@ module('Integration | Component | sidebar-nav-cluster', function (hooks) { test('it should render nav links', async function (assert) { const links = [ 'Dashboard', - 'Secrets engines', + 'Secrets Engines', 'Access', 'Policies', 'Tools', diff --git a/ui/tests/pages/settings/mount-secret-backend.js b/ui/tests/pages/settings/mount-secret-backend.js index de011247e9..6a4e58661c 100644 --- a/ui/tests/pages/settings/mount-secret-backend.js +++ b/ui/tests/pages/settings/mount-secret-backend.js @@ -17,7 +17,7 @@ export default create({ maxTTLUnit: fillable('[data-test-ttl-unit="Max Lease TTL"] [data-test-select="ttl-unit"]'), enableDefaultTtl: clickable('[data-test-toggle-input="Default Lease TTL"]'), enableEngine: clickable('[data-test-enable-engine]'), - secretList: clickable('[data-test-sidebar-nav-link="Secrets engines"]'), + secretList: clickable('[data-test-sidebar-nav-link="Secrets Engines"]'), defaultTTLVal: fillable('input[data-test-ttl-value="Default Lease TTL"]'), defaultTTLUnit: fillable('[data-test-ttl-unit="Default Lease TTL"] [data-test-select="ttl-unit"]'), enable: async function (type, path) {