From ebcd65310221aff1dfcb94a571d70e38944006df Mon Sep 17 00:00:00 2001 From: Alexander Scheel Date: Wed, 18 Jan 2023 10:40:35 -0500 Subject: [PATCH] Remove t.Parallel() due to initialization race (#18751) Using RunCommand(...) to set format to JSON for PKI HC tests results in multiple initCommands(...) being called, overwriting the same global variable. Nobody else calls the test suite in this way, so remove t.Parallel() as the CLI isn't really meant to be called in parallel and there might be other issues. Signed-off-by: Alexander Scheel Signed-off-by: Alexander Scheel --- command/pki_health_check_test.go | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/command/pki_health_check_test.go b/command/pki_health_check_test.go index bdd491a049..a34dbdf5b8 100644 --- a/command/pki_health_check_test.go +++ b/command/pki_health_check_test.go @@ -16,8 +16,6 @@ import ( ) func TestPKIHC_AllGood(t *testing.T) { - t.Parallel() - client, closer := testVaultServer(t) defer closer() @@ -72,8 +70,6 @@ func TestPKIHC_AllGood(t *testing.T) { } func TestPKIHC_AllBad(t *testing.T) { - t.Parallel() - client, closer := testVaultServer(t) defer closer() @@ -134,8 +130,6 @@ func TestPKIHC_AllBad(t *testing.T) { } func TestPKIHC_OnlyIssuer(t *testing.T) { - t.Parallel() - client, closer := testVaultServer(t) defer closer() @@ -158,8 +152,6 @@ func TestPKIHC_OnlyIssuer(t *testing.T) { } func TestPKIHC_NoMount(t *testing.T) { - t.Parallel() - client, closer := testVaultServer(t) defer closer() @@ -174,8 +166,6 @@ func TestPKIHC_NoMount(t *testing.T) { } func TestPKIHC_ExpectedEmptyMount(t *testing.T) { - t.Parallel() - client, closer := testVaultServer(t) defer closer() @@ -196,8 +186,6 @@ func TestPKIHC_ExpectedEmptyMount(t *testing.T) { } func TestPKIHC_NoPerm(t *testing.T) { - t.Parallel() - client, closer := testVaultServer(t) defer closer()