scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-10-29 09:42:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

UI: OIDC callback bug. (#18521)

Browse Source 
* don't error for other message events

Signed-off-by: David van der Spek <vanderspek.david@gmail.com>

* add changelog

Signed-off-by: David van der Spek <vanderspek.david@gmail.com>

* rename release note for changelog

Signed-off-by: David van der Spek <vanderspek.david@gmail.com>

---------

Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
This commit is contained in:
David van der Spek
2023-03-07 17:23:45 +01:00
committed by GitHub
parent 4b9eb233ca
commit ee529db0d8
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
changelog/18521.txt Normal file
View File

@@ -0,0 +1,3 @@
```release-note:bug
ui: wait for wanted message event during OIDC callback instead of using the first message event
```

2
ui/app/components/auth-jwt.js
View File

@@ -104,7 +104,7 @@ export default Component.extend({
// ensure that postMessage event is from expected source // ensure that postMessage event is from expected source
while (true) { while (true) {
const event = yield waitForEvent(thisWindow, 'message'); const event = yield waitForEvent(thisWindow, 'message');
if (event.data.source === 'oidc-callback' && event.isTrusted && event.origin === thisWindow.origin) { if (event.origin === thisWindow.origin && event.isTrusted && event.data.source === 'oidc-callback') {
return this.exchangeOIDC.perform(event.data, oidcWindow); return this.exchangeOIDC.perform(event.data, oidcWindow);
} }
// continue to wait for the correct message // continue to wait for the correct message