scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-11-01 11:08:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Fix bug in TestAddTestPlugin test helper (#19313)

Browse Source 
* fix external plugin test failing locally

* Ensure file is closed and written in TestAddTestPlugin
This commit is contained in:
John-Michael Faircloth
2023-02-23 11:07:48 -06:00
committed by GitHub
parent 20b347e3cd
commit f4f1762991
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
vault/external_tests/plugin/plugin_test.go
View File

@@ -423,6 +423,8 @@ func testPlugin_continueOnError(t *testing.T, btype logical.BackendType, mismatc
// Get the registered plugin // Get the registered plugin
req := logical.TestRequest(t, logical.ReadOperation, fmt.Sprintf("sys/plugins/catalog/%s/mock-plugin", pluginType)) req := logical.TestRequest(t, logical.ReadOperation, fmt.Sprintf("sys/plugins/catalog/%s/mock-plugin", pluginType))
// We are using the mock backend from vault/sdk/plugin/mock/backend.go which sets the plugin version.
req.Data["version"] = "v0.0.0+mock"
req.ClientToken = core.Client.Token() req.ClientToken = core.Client.Token()
resp, err := core.HandleRequest(namespace.RootContext(testCtx), req) resp, err := core.HandleRequest(namespace.RootContext(testCtx), req)
if err != nil || resp == nil || (resp != nil && resp.IsError()) { if err != nil || resp == nil || (resp != nil && resp.IsError()) {

3
vault/testing.go
View File

@@ -539,6 +539,9 @@ func TestAddTestPlugin(t testing.T, c *Core, name string, pluginType consts.Plug
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
// Ensure that the file is closed and written. This seems to be
// necessary on Linux systems.
out.Close()
dirPath = tempDir dirPath = tempDir
} }