mirror of
				https://github.com/optim-enterprises-bv/vault.git
				synced 2025-10-30 18:17:55 +00:00 
			
		
		
		
	UI/kv creation time (#12663)
* add created time for secret version view * complete functionality * test coverage * changelog * version per list item * clean up
This commit is contained in:
		
							
								
								
									
										3
									
								
								changelog/12663.txt
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										3
									
								
								changelog/12663.txt
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,3 @@ | |||||||
|  | ```release-note:improvement | ||||||
|  | ui: Add creation time to KV 2 version history and version view | ||||||
|  | ``` | ||||||
| @@ -35,6 +35,10 @@ | |||||||
|     .helper-text { |     .helper-text { | ||||||
|       font-weight: normal; |       font-weight: normal; | ||||||
|     } |     } | ||||||
|  |     &.justify-right { | ||||||
|  |       display: flex; | ||||||
|  |       justify-content: right; | ||||||
|  |     } | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   .hs-icon { |   .hs-icon { | ||||||
|   | |||||||
| @@ -8,6 +8,14 @@ | |||||||
|   .ember-basic-dropdown-trigger { |   .ember-basic-dropdown-trigger { | ||||||
|     display: inline-block; |     display: inline-block; | ||||||
|   } |   } | ||||||
|  |  | ||||||
|  |   .center-inside-row { | ||||||
|  |     width: 50%; | ||||||
|  |     margin-left: auto; | ||||||
|  |     font-size: $size-8; | ||||||
|  |     font-weight: $font-weight-semibold; | ||||||
|  |     color: $ui-gray-500; | ||||||
|  |   } | ||||||
| } | } | ||||||
|  |  | ||||||
| a.list-item-row, | a.list-item-row, | ||||||
|   | |||||||
| @@ -23,6 +23,9 @@ | |||||||
|   &.ember-basic-dropdown-content--above.ember-basic-dropdown--transitioning-out { |   &.ember-basic-dropdown-content--above.ember-basic-dropdown--transitioning-out { | ||||||
|     animation: drop-fade-below 0.15s reverse; |     animation: drop-fade-below 0.15s reverse; | ||||||
|   } |   } | ||||||
|  |   &.smaller-font { | ||||||
|  |     font-size: $size-8; | ||||||
|  |   } | ||||||
| } | } | ||||||
|  |  | ||||||
| .ember-basic-dropdown-content--left.tool-tip { | .ember-basic-dropdown-content--left.tool-tip { | ||||||
|   | |||||||
| @@ -47,6 +47,18 @@ | |||||||
|         <div class="th column"> |         <div class="th column"> | ||||||
|           Value |           Value | ||||||
|         </div> |         </div> | ||||||
|  |         <div class="th column justify-right" data-test-created-time> | ||||||
|  |           <ToolTip @verticalPosition="above" @horizontalPosition="center" as |T|> | ||||||
|  |             <T.trigger data-test-tooltip-trigger tabindex="-1" data-test-created-time> | ||||||
|  |               Version created {{date-format @modelForData.createdTime 'MMM dd, yyyy hh:mm a'}} | ||||||
|  |             </T.trigger> | ||||||
|  |             <T.content @class="tool-tip smaller-font"> | ||||||
|  |               <div class="box" data-test-hover-copy-tooltip-text> | ||||||
|  |                 {{@modelForData.createdTime}} | ||||||
|  |               </div> | ||||||
|  |             </T.content> | ||||||
|  |           </ToolTip> | ||||||
|  |         </div> | ||||||
|       </div> |       </div> | ||||||
|     </div> |     </div> | ||||||
|     {{#if @modelForData.secretKeyAndValue}} |     {{#if @modelForData.secretKeyAndValue}} | ||||||
|   | |||||||
| @@ -27,7 +27,7 @@ | |||||||
|     <Item.content> |     <Item.content> | ||||||
|       <div class="columns is-flex-1"> |       <div class="columns is-flex-1"> | ||||||
|         <div> |         <div> | ||||||
|           <Icon @glyph="file-outline" class="has-text-grey" /> |           <Icon @glyph="history" class="has-text-grey" /> | ||||||
|           Version {{list.item.version}} |           Version {{list.item.version}} | ||||||
|         </div> |         </div> | ||||||
|         {{#if (eq list.item.version model.currentVersion)}} |         {{#if (eq list.item.version model.currentVersion)}} | ||||||
| @@ -50,7 +50,19 @@ | |||||||
|               <Icon @glyph="cancel-square-fill" />Destroyed |               <Icon @glyph="cancel-square-fill" />Destroyed | ||||||
|             </span>       |             </span>       | ||||||
|           </div> |           </div> | ||||||
|         {{/if}}     |         {{/if}} | ||||||
|  |         <div class="center-inside-row"> | ||||||
|  |           <ToolTip @verticalPosition="above" @horizontalPosition="center" as |T|> | ||||||
|  |             <T.trigger data-test-tooltip-trigger tabindex="-1"> | ||||||
|  |               Created {{date-format list.item.createdTime 'MMM dd, yyyy hh:mm a'}} | ||||||
|  |             </T.trigger> | ||||||
|  |             <T.content @class="tool-tip smaller-font"> | ||||||
|  |               <div class="box" data-test-hover-copy-tooltip-text> | ||||||
|  |                 {{list.item.createdTime}} | ||||||
|  |               </div> | ||||||
|  |             </T.content> | ||||||
|  |           </ToolTip> | ||||||
|  |         </div> | ||||||
|       </div> |       </div> | ||||||
|     </Item.content> |     </Item.content> | ||||||
|     <Item.menu> |     <Item.menu> | ||||||
|   | |||||||
| @@ -226,6 +226,8 @@ module('Acceptance | secrets/secret/create', function(hooks) { | |||||||
|  |  | ||||||
|   test('it navigates to version history and to a specific version', async function(assert) { |   test('it navigates to version history and to a specific version', async function(assert) { | ||||||
|     const path = `kv-path-${new Date().getTime()}`; |     const path = `kv-path-${new Date().getTime()}`; | ||||||
|  |     let today = new Date(); | ||||||
|  |     let month = today.toString().split(' ')[1]; | ||||||
|     await listPage.visitRoot({ backend: 'secret' }); |     await listPage.visitRoot({ backend: 'secret' }); | ||||||
|     await settled(); |     await settled(); | ||||||
|     await listPage.create(); |     await listPage.create(); | ||||||
| @@ -233,11 +235,13 @@ module('Acceptance | secrets/secret/create', function(hooks) { | |||||||
|     await editPage.createSecret(path, 'foo', 'bar'); |     await editPage.createSecret(path, 'foo', 'bar'); | ||||||
|     await click('[data-test-popup-menu-trigger="version"]'); |     await click('[data-test-popup-menu-trigger="version"]'); | ||||||
|     await settled(); |     await settled(); | ||||||
|  |     assert.dom('[ data-test-created-time]').includesText(month, 'created time shows todays month'); | ||||||
|  |  | ||||||
|     await click('[data-test-version-history]'); |     await click('[data-test-version-history]'); | ||||||
|     await settled(); |     await settled(); | ||||||
|     assert |     assert | ||||||
|       .dom('[data-test-list-item-content]') |       .dom('[data-test-list-item-content]') | ||||||
|       .hasText('Version 1 Current', 'shows version one data on the version history as current'); |       .includesText('Version 1 Current', 'shows version one data on the version history as current'); | ||||||
|     assert.dom('[data-test-list-item-content]').exists({ count: 1 }, 'renders a single version'); |     assert.dom('[data-test-list-item-content]').exists({ count: 1 }, 'renders a single version'); | ||||||
|  |  | ||||||
|     await click('.linked-block'); |     await click('.linked-block'); | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 Angel Garbarino
					Angel Garbarino