vishalnayak
ec1d635769
Add some validation checks
2016-09-28 15:36:02 -04:00
vishalnayak
2964c925d3
Fix the misplaced response warning
2016-09-28 14:20:03 -04:00
vishalnayak
a716e20261
Added testcase to check secret_id_num_uses
2016-09-28 13:58:53 -04:00
vishalnayak
020237779e
Pull out reading and storing of secret ID into separate functions and handle upgrade properly
2016-09-28 12:42:26 -04:00
Mikhail Zholobov
89d2d67a5b
Fix "SecretIDNumUses" in AppRole auth backend
...
There was a typo.
2016-09-27 17:26:52 +03:00
Vishal Nayak
92cb781be9
Merge pull request #1910 from hashicorp/secret-id-cidr-list
...
CIDR restrictions on Secret ID
2016-09-26 10:22:48 -04:00
Vishal Nayak
a31ab07615
Merge pull request #1920 from legal90/fix-approle-delete
...
Fix panic on deleting the AppRole which doesn't exist
2016-09-26 10:05:33 -04:00
Mikhail Zholobov
9667cd9377
Fix panic on deleting the AppRole which doesn't exist
...
#pathRoleDelete should return silently if the specified AppRole doesn't exist
Fixes GH-1919
2016-09-26 16:55:08 +03:00
vishalnayak
c94415d824
Address review feedback from @jefferai
2016-09-26 09:53:24 -04:00
vishalnayak
a83acd402e
Update docs to contain bound_iam_role_arn
2016-09-26 09:37:38 -04:00
vishalnayak
2bd8903cf4
Implemented bound_iam_role_arn constraint
2016-09-23 21:35:36 -04:00
Jeff Mitchell
bba2ea63f1
Don't use time.Time in responses. ( #1912 )
...
This fixes #1911 but not directly; it doesn't address the cause of the
panic. However, it turns out that this is the correct fix anyways,
because it ensures that the value being logged is RFC3339 format, which
is what the time turns into in JSON but not the normal time string
value, so what we audit log (and HMAC) matches what we are returning.
2016-09-23 12:32:07 -04:00
vishalnayak
0b233b3fa1
Fix incorrect naming of bound_iam_instance_profile_arn
2016-09-23 11:22:23 -04:00
vishalnayak
8ce3fa75ba
Store the CIDR list in the secret ID storage entry.
...
Use the stored information to validate the source address and credential issue time.
Correct the logic used to verify BoundCIDRList on the role.
Reverify the subset requirements between secret ID and role during credential issue time.
2016-09-21 20:19:26 -04:00
vishalnayak
7f89bb5f68
Pass only valid inputs to validation methods
2016-09-21 15:44:54 -04:00
vishalnayak
c93bded97b
Added cidrutil helper
2016-09-21 13:58:32 -04:00
Vishal Nayak
ee22bb4f29
Merge pull request #1897 from hashicorp/secret-id-accessor-locks
...
Safely manipulate secret id accessors
2016-09-19 11:37:38 -04:00
vishalnayak
c44f1c9817
s/GetOctalFormatted/GetHexFormatted
2016-09-16 17:47:15 -04:00
vishalnayak
32a8ab3cc7
Safely manipulate secret id accessors
2016-09-15 18:13:50 -04:00
Vishal Nayak
f3306fdb31
Merge pull request #1886 from hashicorp/approle-upgrade-notes
...
upgrade notes entry for approle constraint and warning on role read
2016-09-15 12:14:01 -04:00
vishalnayak
7d4edbde69
check for nil role
2016-09-15 12:10:40 -04:00
vishalnayak
9fb11c4403
Address review feedback
2016-09-15 11:41:52 -04:00
vishalnayak
55c6c0da73
s/disableReauthenticationNonce/reauthentication-disabled-nonce
2016-09-15 11:29:02 -04:00
vishalnayak
e9c8555d12
Updated docs with nonce usage
2016-09-14 19:31:09 -04:00
vishalnayak
097e6031c6
Added comment
2016-09-14 18:27:35 -04:00
vishalnayak
daf7c63225
Disable reauthentication if nonce is explicitly set to empty
2016-09-14 17:58:00 -04:00
vishalnayak
ddb0639a13
address review feedback
2016-09-14 14:28:02 -04:00
vishalnayak
fb04d06b9b
Remove the client nonce being empty check
2016-09-14 14:28:02 -04:00
vishalnayak
2de4c8bef2
Generate the nonce by default
2016-09-14 14:28:02 -04:00
vishalnayak
5e7e30e33c
address review feedback
2016-09-14 12:08:35 -04:00
vishalnayak
75615d9d56
Use constant time comparisons for client nonce
2016-09-13 20:12:43 -04:00
vishalnayak
dbb3f49438
Address review feedback
2016-09-13 18:30:04 -04:00
Jeff Mitchell
ea4fcb2927
Only use running state for checking if instance is alive. ( #1885 )
...
Fixes #1884
2016-09-13 18:08:05 -04:00
vishalnayak
de334d1688
upgrade notes entry for approle constraint and warning on role read
2016-09-13 17:44:07 -04:00
vishalnayak
166d67c0a8
Ensure at least one constraint on the role
2016-09-13 16:03:15 -04:00
vishalnayak
7c743ecd0a
Address review feedback
2016-08-30 16:36:58 -04:00
vishalnayak
edd7b3deb5
approle: fix racy updates problem for roles
2016-08-30 16:11:14 -04:00
Jeff Mitchell
6beadc1e1c
Merge pull request #1755 from hashicorp/logxi
...
Convert to logxi
2016-08-21 19:28:18 -04:00
Jeff Mitchell
68345eb770
Convert to logxi
2016-08-21 18:13:37 -04:00
vishalnayak
7d772e445f
Extract out common code
2016-08-21 15:46:11 -04:00
vishalnayak
1a62fb64c2
Seperate endpoints for read/delete using secret-id and accessor
2016-08-21 14:42:49 -04:00
Jeff Mitchell
357ecb4dfe
gofmt
2016-08-19 16:48:32 -04:00
vishalnayak
0fbc9b1d7b
Pretty print the warning
2016-08-18 16:09:10 -04:00
vishalnayak
a57588303d
Use shortestTTL value during renewals too
2016-08-18 15:43:58 -04:00
vishalnayak
eac454a385
When TTL is not set, consider the system default TTL as well
2016-08-18 15:37:59 -04:00
vishalnayak
22e4577725
aws-ec2: se max_ttl when ttl is not set, during login
2016-08-18 15:16:32 -04:00
vishalnayak
5af0395fb2
Address review feedback by @jefferai
2016-08-09 17:45:42 -04:00
vishalnayak
fd3f2182bc
Added ttl field to aws-ec2 auth backend role
2016-08-09 17:29:45 -04:00
Jeff Mitchell
373e42d60c
Return warning about ACLing the LDAP configuration endpoint.
...
Fixes #1263
2016-08-08 10:18:36 -04:00
Jeff Mitchell
7d1f0facb8
Add arbitrary string slice parsing.
...
Like the KV function, this supports either separated strings or JSON
strings, base64-encoded or not.
Fixes #1619 in theory.
2016-08-03 14:24:16 -04:00
