mirror of
				https://github.com/optim-enterprises-bv/vault.git
				synced 2025-10-30 18:17:55 +00:00 
			
		
		
		
	 07927e036c
			
		
	
	07927e036c
	
	
	
		
			
			* enable registering backend muxed plugins in plugin catalog * set the sysview on the pluginconfig to allow enabling secrets/auth plugins * store backend instances in map * store single implementations in the instances map cleanup instance map and ensure we don't deadlock * fix system backend unit tests move GetMultiplexIDFromContext to pluginutil package fix pluginutil test fix dbplugin ut * return error(s) if we can't get the plugin client update comments * refactor/move GetMultiplexIDFromContext test * add changelog * remove unnecessary field on pluginClient * add unit tests to PluginCatalog for secrets/auth plugins * fix comment * return pluginClient from TestRunTestPlugin * add multiplexed backend test * honor metadatamode value in newbackend pluginconfig * check that connection exists on cleanup * add automtls to secrets/auth plugins * don't remove apiclientmeta parsing * use formatting directive for fmt.Errorf * fix ut: remove tls provider func * remove tlsproviderfunc from backend plugin tests * use env var to prevent test plugin from running as a unit test * WIP: remove lazy loading * move non lazy loaded backend to new package * use version wrapper for backend plugin factory * remove backendVersionWrapper type * implement getBackendPluginType for plugin catalog * handle backend plugin v4 registration * add plugin automtls env guard * modify plugin factory to determine the backend to use * remove old pluginsets from v5 and log pid in plugin catalog * add reload mechanism via context * readd v3 and v4 to pluginset * call cleanup from reload if non-muxed * move v5 backend code to new package * use context reload for for ErrPluginShutdown case * add wrapper on v5 backend * fix run config UTs * fix unit tests - use v4/v5 mapping for plugin versions - fix test build err - add reload method on fakePluginClient - add multiplexed cases for integration tests * remove comment and update AutoMTLS field in test * remove comment * remove errwrap and unused context * only support metadatamode false for v5 backend plugins * update plugin catalog errors * use const for env variables * rename locks and remove unused * remove unneeded nil check * improvements based on staticcheck recommendations * use const for single implementation string * use const for context key * use info default log level * move pid to pluginClient struct * remove v3 and v4 from multiplexed plugin set * return from reload when non-multiplexed * update automtls env string * combine getBackend and getBrokeredClient * update comments for plugin reload, Backend return val and log * revert Backend return type * allow non-muxed plugins to serve v5 * move v5 code to existing sdk plugin package * do next export sdk fields now that we have removed extra plugin pkg * set TLSProvider in ServeMultiplex for backwards compat * use bool to flag multiplexing support on grpc backend server * revert userpass main.go * refactor plugin sdk - update comments - make use of multiplexing boolean and single implementation ID const * update comment and use multierr * attempt v4 if dispense fails on getPluginTypeForUnknown * update comments on sdk plugin backend
		
			
				
	
	
		
			142 lines
		
	
	
		
			3.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			142 lines
		
	
	
		
			3.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package plugin_test
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"fmt"
 | |
| 	"os"
 | |
| 	"testing"
 | |
| 
 | |
| 	log "github.com/hashicorp/go-hclog"
 | |
| 	"github.com/hashicorp/vault/api"
 | |
| 	"github.com/hashicorp/vault/builtin/plugin"
 | |
| 	vaulthttp "github.com/hashicorp/vault/http"
 | |
| 	"github.com/hashicorp/vault/sdk/helper/consts"
 | |
| 	"github.com/hashicorp/vault/sdk/helper/logging"
 | |
| 	"github.com/hashicorp/vault/sdk/helper/pluginutil"
 | |
| 	"github.com/hashicorp/vault/sdk/logical"
 | |
| 	logicalPlugin "github.com/hashicorp/vault/sdk/plugin"
 | |
| 	"github.com/hashicorp/vault/sdk/plugin/mock"
 | |
| 	"github.com/hashicorp/vault/vault"
 | |
| )
 | |
| 
 | |
| func TestBackend_impl(t *testing.T) {
 | |
| 	var _ logical.Backend = &plugin.PluginBackend{}
 | |
| }
 | |
| 
 | |
| func TestBackend(t *testing.T) {
 | |
| 	pluginCmds := []string{"TestBackend_PluginMain", "TestBackend_PluginMain_Multiplexed"}
 | |
| 
 | |
| 	for _, pluginCmd := range pluginCmds {
 | |
| 		t.Run(pluginCmd, func(t *testing.T) {
 | |
| 			config, cleanup := testConfig(t, pluginCmd)
 | |
| 			defer cleanup()
 | |
| 
 | |
| 			_, err := plugin.Backend(context.Background(), config)
 | |
| 			if err != nil {
 | |
| 				t.Fatal(err)
 | |
| 			}
 | |
| 		})
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestBackend_Factory(t *testing.T) {
 | |
| 	pluginCmds := []string{"TestBackend_PluginMain", "TestBackend_PluginMain_Multiplexed"}
 | |
| 
 | |
| 	for _, pluginCmd := range pluginCmds {
 | |
| 		t.Run(pluginCmd, func(t *testing.T) {
 | |
| 			config, cleanup := testConfig(t, pluginCmd)
 | |
| 			defer cleanup()
 | |
| 
 | |
| 			_, err := plugin.Factory(context.Background(), config)
 | |
| 			if err != nil {
 | |
| 				t.Fatal(err)
 | |
| 			}
 | |
| 		})
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestBackend_PluginMain(t *testing.T) {
 | |
| 	args := []string{}
 | |
| 	if os.Getenv(pluginutil.PluginUnwrapTokenEnv) == "" && os.Getenv(pluginutil.PluginMetadataModeEnv) != "true" {
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	caPEM := os.Getenv(pluginutil.PluginCACertPEMEnv)
 | |
| 	if caPEM == "" {
 | |
| 		t.Fatal("CA cert not passed in")
 | |
| 	}
 | |
| 
 | |
| 	args = append(args, fmt.Sprintf("--ca-cert=%s", caPEM))
 | |
| 
 | |
| 	apiClientMeta := &api.PluginAPIClientMeta{}
 | |
| 	flags := apiClientMeta.FlagSet()
 | |
| 	flags.Parse(args)
 | |
| 	tlsConfig := apiClientMeta.GetTLSConfig()
 | |
| 	tlsProviderFunc := api.VaultPluginTLSProvider(tlsConfig)
 | |
| 
 | |
| 	err := logicalPlugin.Serve(&logicalPlugin.ServeOpts{
 | |
| 		BackendFactoryFunc: mock.Factory,
 | |
| 		TLSProviderFunc:    tlsProviderFunc,
 | |
| 	})
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestBackend_PluginMain_Multiplexed(t *testing.T) {
 | |
| 	args := []string{}
 | |
| 	if os.Getenv(pluginutil.PluginUnwrapTokenEnv) == "" && os.Getenv(pluginutil.PluginMetadataModeEnv) != "true" {
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	caPEM := os.Getenv(pluginutil.PluginCACertPEMEnv)
 | |
| 	if caPEM == "" {
 | |
| 		t.Fatal("CA cert not passed in")
 | |
| 	}
 | |
| 
 | |
| 	args = append(args, fmt.Sprintf("--ca-cert=%s", caPEM))
 | |
| 
 | |
| 	apiClientMeta := &api.PluginAPIClientMeta{}
 | |
| 	flags := apiClientMeta.FlagSet()
 | |
| 	flags.Parse(args)
 | |
| 	tlsConfig := apiClientMeta.GetTLSConfig()
 | |
| 	tlsProviderFunc := api.VaultPluginTLSProvider(tlsConfig)
 | |
| 
 | |
| 	err := logicalPlugin.ServeMultiplex(&logicalPlugin.ServeOpts{
 | |
| 		BackendFactoryFunc: mock.Factory,
 | |
| 		TLSProviderFunc:    tlsProviderFunc,
 | |
| 	})
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func testConfig(t *testing.T, pluginCmd string) (*logical.BackendConfig, func()) {
 | |
| 	cluster := vault.NewTestCluster(t, nil, &vault.TestClusterOptions{
 | |
| 		HandlerFunc: vaulthttp.Handler,
 | |
| 	})
 | |
| 	cluster.Start()
 | |
| 	cores := cluster.Cores
 | |
| 
 | |
| 	core := cores[0]
 | |
| 
 | |
| 	sys := vault.TestDynamicSystemView(core.Core, nil)
 | |
| 
 | |
| 	config := &logical.BackendConfig{
 | |
| 		Logger: logging.NewVaultLogger(log.Debug),
 | |
| 		System: sys,
 | |
| 		Config: map[string]string{
 | |
| 			"plugin_name": "mock-plugin",
 | |
| 			"plugin_type": "secret",
 | |
| 		},
 | |
| 	}
 | |
| 
 | |
| 	os.Setenv(pluginutil.PluginCACertPEMEnv, cluster.CACertPEMFile)
 | |
| 
 | |
| 	vault.TestAddTestPlugin(t, core.Core, "mock-plugin", consts.PluginTypeSecrets, pluginCmd, []string{}, "")
 | |
| 
 | |
| 	return config, func() {
 | |
| 		cluster.Cleanup()
 | |
| 	}
 | |
| }
 |