mirror of
				https://github.com/optim-enterprises-bv/vault.git
				synced 2025-10-31 10:37:56 +00:00 
			
		
		
		
	 35667f93a7
			
		
	
	35667f93a7
	
	
	
		
			
			* Add priority queue to sdk * fix issue of storing pointers and now copy * update to use copy structure * Remove file, put Item struct def. into other file * add link * clean up docs * refactor internal data structure to hide heap method implementations. Other cleanup after feedback * rename PushItem and PopItem to just Push/Pop, after encapsulating the heap methods * updates after feedback * refactoring/renaming * guard against pushing a nil item * minor updates after feedback * Add SetCredentials, GenerateCredentials gRPC methods to combined database backend gPRC * Initial Combined database backend implementation of static accounts and automatic rotation * vendor updates * initial implementation of static accounts with Combined database backend, starting with PostgreSQL implementation * add lock and setup of rotation queue * vendor the queue * rebase on new method signature of queue * remove mongo tests for now * update default role sql * gofmt after rebase * cleanup after rebasing to remove checks for ErrNotFound error * rebase cdcr-priority-queue * vendor dependencies with 'go mod vendor' * website database docs for Static Role support * document the rotate-role API endpoint * postgres specific static role docs * use constants for paths * updates from review * remove dead code * combine and clarify error message for older plugins * Update builtin/logical/database/backend.go Co-Authored-By: Jim Kalafut <jim@kalafut.net> * cleanups from feedback * code and comment cleanups * move db.RLock higher to protect db.GenerateCredentials call * Return output with WALID if we failed to delete the WAL * Update builtin/logical/database/path_creds_create.go Co-Authored-By: Jim Kalafut <jim@kalafut.net> * updates after running 'make fmt' * update after running 'make proto' * Update builtin/logical/database/path_roles.go Co-Authored-By: Brian Kassouf <briankassouf@users.noreply.github.com> * Update builtin/logical/database/path_roles.go Co-Authored-By: Brian Kassouf <briankassouf@users.noreply.github.com> * update comment and remove and rearrange some dead code * Update website/source/api/secret/databases/index.html.md Co-Authored-By: Jim Kalafut <jim@kalafut.net> * cleanups after review * Update sdk/database/dbplugin/grpc_transport.go Co-Authored-By: Brian Kassouf <briankassouf@users.noreply.github.com> * code cleanup after feedback * remove PasswordLastSet; it's not used * document GenerateCredentials and SetCredentials * Update builtin/logical/database/path_rotate_credentials.go Co-Authored-By: Brian Kassouf <briankassouf@users.noreply.github.com> * wrap pop and popbykey in backend methods to protect against nil cred rotation queue * use strings.HasPrefix instead of direct equality check for path * Forgot to commit this * updates after feedback * re-purpose an outdated test to now check that static and dynamic roles cannot share a name * check for unique name across dynamic and static roles * refactor loadStaticWALs to return a map of name/setCredentialsWAL struct to consolidate where we're calling set credentials * remove commented out code * refactor to have loadstaticwals filter out wals for roles that no longer exist * return error if nil input given * add nil check for input into setStaticAccount * Update builtin/logical/database/path_roles.go Co-Authored-By: Brian Kassouf <briankassouf@users.noreply.github.com> * add constant for queue tick time in seconds, used for comparrison in updates * Update builtin/logical/database/path_roles.go Co-Authored-By: Jim Kalafut <jim@kalafut.net> * code cleanup after review * remove misplaced code comment * remove commented out code * create a queue in the Factory method, even if it's never used * update path_roles to use a common set of fields, with specific overrides for dynamic/static roles by type * document new method * move rotation things into a specific file * rename test file and consolidate some static account tests * Update builtin/logical/database/path_roles.go Co-Authored-By: Brian Kassouf <briankassouf@users.noreply.github.com> * Update builtin/logical/database/rotation.go Co-Authored-By: Brian Kassouf <briankassouf@users.noreply.github.com> * Update builtin/logical/database/rotation.go Co-Authored-By: Brian Kassouf <briankassouf@users.noreply.github.com> * Update builtin/logical/database/rotation.go Co-Authored-By: Brian Kassouf <briankassouf@users.noreply.github.com> * Update builtin/logical/database/rotation.go Co-Authored-By: Brian Kassouf <briankassouf@users.noreply.github.com> * Update builtin/logical/database/rotation.go Co-Authored-By: Brian Kassouf <briankassouf@users.noreply.github.com> * update code comments, method names, and move more methods into rotation.go * update comments to be capitalized * remove the item from the queue before we try to destroy it * findStaticWAL returns an error * use lowercase keys when encoding WAL entries * small cleanups * remove vestigial static account check * remove redundant DeleteWAL call in populate queue * if we error on loading role, push back to queue with 10 second backoff * poll in initqueue to make sure the backend is setup and can write/delete data * add revoke_user_on_delete flag to allow users to opt-in to revoking the static database user on delete of the Vault role. Default false * add code comments on read-only loop * code comment updates * re-push if error returned from find static wal * add locksutil and acquire locks when pop'ing from the queue * grab exclusive locks for updating static roles * Add SetCredentials and GenerateCredentials stubs to mockPlugin * add a switch in initQueue to listen for cancelation * remove guard on zero time, it should have no affect * create a new context in Factory to pass on and use for closing the backend queue * restore master copy of vendor dir
		
			
				
	
	
		
			1407 lines
		
	
	
		
			39 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			1407 lines
		
	
	
		
			39 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package database
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"database/sql"
 | |
| 	"fmt"
 | |
| 	"log"
 | |
| 	"os"
 | |
| 	"reflect"
 | |
| 	"strings"
 | |
| 	"sync"
 | |
| 	"testing"
 | |
| 	"time"
 | |
| 
 | |
| 	"github.com/go-test/deep"
 | |
| 	"github.com/hashicorp/vault/api"
 | |
| 	"github.com/hashicorp/vault/helper/namespace"
 | |
| 	"github.com/hashicorp/vault/helper/testhelpers/docker"
 | |
| 	vaulthttp "github.com/hashicorp/vault/http"
 | |
| 	"github.com/hashicorp/vault/plugins/database/postgresql"
 | |
| 	"github.com/hashicorp/vault/sdk/database/dbplugin"
 | |
| 	"github.com/hashicorp/vault/sdk/database/helper/dbutil"
 | |
| 	"github.com/hashicorp/vault/sdk/framework"
 | |
| 	"github.com/hashicorp/vault/sdk/helper/consts"
 | |
| 	"github.com/hashicorp/vault/sdk/helper/pluginutil"
 | |
| 	"github.com/hashicorp/vault/sdk/logical"
 | |
| 	"github.com/hashicorp/vault/vault"
 | |
| 	"github.com/lib/pq"
 | |
| 	"github.com/mitchellh/mapstructure"
 | |
| 	"github.com/ory/dockertest"
 | |
| )
 | |
| 
 | |
| var (
 | |
| 	testImagePull sync.Once
 | |
| )
 | |
| 
 | |
| func preparePostgresTestContainer(t *testing.T, s logical.Storage, b logical.Backend) (cleanup func(), retURL string) {
 | |
| 	t.Helper()
 | |
| 	if os.Getenv("PG_URL") != "" {
 | |
| 		return func() {}, os.Getenv("PG_URL")
 | |
| 	}
 | |
| 
 | |
| 	pool, err := dockertest.NewPool("")
 | |
| 	if err != nil {
 | |
| 		t.Fatalf("Failed to connect to docker: %s", err)
 | |
| 	}
 | |
| 
 | |
| 	resource, err := pool.Run("postgres", "latest", []string{"POSTGRES_PASSWORD=secret", "POSTGRES_DB=database"})
 | |
| 	if err != nil {
 | |
| 		t.Fatalf("Could not start local PostgreSQL docker container: %s", err)
 | |
| 	}
 | |
| 
 | |
| 	cleanup = func() {
 | |
| 		docker.CleanupResource(t, pool, resource)
 | |
| 	}
 | |
| 
 | |
| 	retURL = fmt.Sprintf("postgres://postgres:secret@localhost:%s/database?sslmode=disable", resource.GetPort("5432/tcp"))
 | |
| 
 | |
| 	// Exponential backoff-retry
 | |
| 	if err = pool.Retry(func() error {
 | |
| 		// This will cause a validation to run
 | |
| 		resp, err := b.HandleRequest(namespace.RootContext(nil), &logical.Request{
 | |
| 			Storage:   s,
 | |
| 			Operation: logical.UpdateOperation,
 | |
| 			Path:      "config/postgresql",
 | |
| 			Data: map[string]interface{}{
 | |
| 				"plugin_name":    "postgresql-database-plugin",
 | |
| 				"connection_url": retURL,
 | |
| 			},
 | |
| 		})
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			// It's likely not up and running yet, so return error and try again
 | |
| 			return fmt.Errorf("err:%#v resp:%#v", err, resp)
 | |
| 		}
 | |
| 		if resp == nil {
 | |
| 			t.Fatal("expected warning")
 | |
| 		}
 | |
| 
 | |
| 		return nil
 | |
| 	}); err != nil {
 | |
| 		cleanup()
 | |
| 		t.Fatalf("Could not connect to PostgreSQL docker container: %s", err)
 | |
| 	}
 | |
| 
 | |
| 	return
 | |
| }
 | |
| 
 | |
| func getCluster(t *testing.T) (*vault.TestCluster, logical.SystemView) {
 | |
| 	coreConfig := &vault.CoreConfig{
 | |
| 		LogicalBackends: map[string]logical.Factory{
 | |
| 			"database": Factory,
 | |
| 		},
 | |
| 	}
 | |
| 
 | |
| 	cluster := vault.NewTestCluster(t, coreConfig, &vault.TestClusterOptions{
 | |
| 		HandlerFunc: vaulthttp.Handler,
 | |
| 	})
 | |
| 	cluster.Start()
 | |
| 	cores := cluster.Cores
 | |
| 
 | |
| 	os.Setenv(pluginutil.PluginCACertPEMEnv, cluster.CACertPEMFile)
 | |
| 
 | |
| 	sys := vault.TestDynamicSystemView(cores[0].Core)
 | |
| 	vault.TestAddTestPlugin(t, cores[0].Core, "postgresql-database-plugin", consts.PluginTypeDatabase, "TestBackend_PluginMain_Postgres", []string{}, "")
 | |
| 
 | |
| 	return cluster, sys
 | |
| }
 | |
| 
 | |
| func TestBackend_PluginMain_Postgres(t *testing.T) {
 | |
| 	if os.Getenv(pluginutil.PluginUnwrapTokenEnv) == "" {
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	caPEM := os.Getenv(pluginutil.PluginCACertPEMEnv)
 | |
| 	if caPEM == "" {
 | |
| 		t.Fatal("CA cert not passed in")
 | |
| 	}
 | |
| 
 | |
| 	args := []string{"--ca-cert=" + caPEM}
 | |
| 
 | |
| 	apiClientMeta := &api.PluginAPIClientMeta{}
 | |
| 	flags := apiClientMeta.FlagSet()
 | |
| 	flags.Parse(args)
 | |
| 
 | |
| 	postgresql.Run(apiClientMeta.GetTLSConfig())
 | |
| }
 | |
| 
 | |
| func TestBackend_RoleUpgrade(t *testing.T) {
 | |
| 
 | |
| 	storage := &logical.InmemStorage{}
 | |
| 	backend := &databaseBackend{}
 | |
| 
 | |
| 	roleExpected := &roleEntry{
 | |
| 		Statements: dbplugin.Statements{
 | |
| 			CreationStatements: "test",
 | |
| 			Creation:           []string{"test"},
 | |
| 		},
 | |
| 	}
 | |
| 
 | |
| 	entry, err := logical.StorageEntryJSON("role/test", &roleEntry{
 | |
| 		Statements: dbplugin.Statements{
 | |
| 			CreationStatements: "test",
 | |
| 		},
 | |
| 	})
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 	if err := storage.Put(context.Background(), entry); err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 
 | |
| 	role, err := backend.Role(context.Background(), storage, "test")
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 
 | |
| 	if !reflect.DeepEqual(role, roleExpected) {
 | |
| 		t.Fatalf("bad role %#v, %#v", role, roleExpected)
 | |
| 	}
 | |
| 
 | |
| 	// Upgrade case
 | |
| 	badJSON := `{"statments":{"creation_statments":"test","revocation_statements":"","rollback_statements":"","renew_statements":""}}`
 | |
| 	entry = &logical.StorageEntry{
 | |
| 		Key:   "role/test",
 | |
| 		Value: []byte(badJSON),
 | |
| 	}
 | |
| 	if err := storage.Put(context.Background(), entry); err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 
 | |
| 	role, err = backend.Role(context.Background(), storage, "test")
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 
 | |
| 	if !reflect.DeepEqual(role, roleExpected) {
 | |
| 		t.Fatalf("bad role %#v, %#v", role, roleExpected)
 | |
| 	}
 | |
| 
 | |
| }
 | |
| 
 | |
| func TestBackend_config_connection(t *testing.T) {
 | |
| 	var resp *logical.Response
 | |
| 	var err error
 | |
| 
 | |
| 	cluster, sys := getCluster(t)
 | |
| 	defer cluster.Cleanup()
 | |
| 
 | |
| 	config := logical.TestBackendConfig()
 | |
| 	config.StorageView = &logical.InmemStorage{}
 | |
| 	config.System = sys
 | |
| 	lb, err := Factory(context.Background(), config)
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 	b, ok := lb.(*databaseBackend)
 | |
| 	if !ok {
 | |
| 		t.Fatal("could not convert to database backend")
 | |
| 	}
 | |
| 	defer b.Cleanup(context.Background())
 | |
| 
 | |
| 	// Test creation
 | |
| 	{
 | |
| 		configData := map[string]interface{}{
 | |
| 			"connection_url":    "sample_connection_url",
 | |
| 			"someotherdata":     "testing",
 | |
| 			"plugin_name":       "postgresql-database-plugin",
 | |
| 			"verify_connection": false,
 | |
| 			"allowed_roles":     []string{"*"},
 | |
| 			"name":              "plugin-test",
 | |
| 		}
 | |
| 
 | |
| 		configReq := &logical.Request{
 | |
| 			Operation: logical.CreateOperation,
 | |
| 			Path:      "config/plugin-test",
 | |
| 			Storage:   config.StorageView,
 | |
| 			Data:      configData,
 | |
| 		}
 | |
| 
 | |
| 		exists, err := b.connectionExistenceCheck()(context.Background(), configReq, &framework.FieldData{
 | |
| 			Raw:    configData,
 | |
| 			Schema: pathConfigurePluginConnection(b).Fields,
 | |
| 		})
 | |
| 		if err != nil {
 | |
| 			t.Fatal(err)
 | |
| 		}
 | |
| 		if exists {
 | |
| 			t.Fatal("expected not exists")
 | |
| 		}
 | |
| 
 | |
| 		resp, err = b.HandleRequest(namespace.RootContext(nil), configReq)
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%v resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		expected := map[string]interface{}{
 | |
| 			"plugin_name": "postgresql-database-plugin",
 | |
| 			"connection_details": map[string]interface{}{
 | |
| 				"connection_url": "sample_connection_url",
 | |
| 				"someotherdata":  "testing",
 | |
| 			},
 | |
| 			"allowed_roles":                      []string{"*"},
 | |
| 			"root_credentials_rotate_statements": []string{},
 | |
| 		}
 | |
| 		configReq.Operation = logical.ReadOperation
 | |
| 		resp, err = b.HandleRequest(namespace.RootContext(nil), configReq)
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		delete(resp.Data["connection_details"].(map[string]interface{}), "name")
 | |
| 		if !reflect.DeepEqual(expected, resp.Data) {
 | |
| 			t.Fatalf("bad: expected:%#v\nactual:%#v\n", expected, resp.Data)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// Test existence check and an update to a single connection detail parameter
 | |
| 	{
 | |
| 		configData := map[string]interface{}{
 | |
| 			"connection_url":    "sample_convection_url",
 | |
| 			"verify_connection": false,
 | |
| 			"name":              "plugin-test",
 | |
| 		}
 | |
| 
 | |
| 		configReq := &logical.Request{
 | |
| 			Operation: logical.UpdateOperation,
 | |
| 			Path:      "config/plugin-test",
 | |
| 			Storage:   config.StorageView,
 | |
| 			Data:      configData,
 | |
| 		}
 | |
| 
 | |
| 		exists, err := b.connectionExistenceCheck()(context.Background(), configReq, &framework.FieldData{
 | |
| 			Raw:    configData,
 | |
| 			Schema: pathConfigurePluginConnection(b).Fields,
 | |
| 		})
 | |
| 		if err != nil {
 | |
| 			t.Fatal(err)
 | |
| 		}
 | |
| 		if !exists {
 | |
| 			t.Fatal("expected exists")
 | |
| 		}
 | |
| 
 | |
| 		resp, err = b.HandleRequest(namespace.RootContext(nil), configReq)
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%v resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		expected := map[string]interface{}{
 | |
| 			"plugin_name": "postgresql-database-plugin",
 | |
| 			"connection_details": map[string]interface{}{
 | |
| 				"connection_url": "sample_convection_url",
 | |
| 				"someotherdata":  "testing",
 | |
| 			},
 | |
| 			"allowed_roles":                      []string{"*"},
 | |
| 			"root_credentials_rotate_statements": []string{},
 | |
| 		}
 | |
| 		configReq.Operation = logical.ReadOperation
 | |
| 		resp, err = b.HandleRequest(namespace.RootContext(nil), configReq)
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		delete(resp.Data["connection_details"].(map[string]interface{}), "name")
 | |
| 		if !reflect.DeepEqual(expected, resp.Data) {
 | |
| 			t.Fatalf("bad: expected:%#v\nactual:%#v\n", expected, resp.Data)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// Test an update to a non-details value
 | |
| 	{
 | |
| 		configData := map[string]interface{}{
 | |
| 			"verify_connection": false,
 | |
| 			"allowed_roles":     []string{"flu", "barre"},
 | |
| 			"name":              "plugin-test",
 | |
| 		}
 | |
| 
 | |
| 		configReq := &logical.Request{
 | |
| 			Operation: logical.UpdateOperation,
 | |
| 			Path:      "config/plugin-test",
 | |
| 			Storage:   config.StorageView,
 | |
| 			Data:      configData,
 | |
| 		}
 | |
| 
 | |
| 		resp, err = b.HandleRequest(namespace.RootContext(nil), configReq)
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%v resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		expected := map[string]interface{}{
 | |
| 			"plugin_name": "postgresql-database-plugin",
 | |
| 			"connection_details": map[string]interface{}{
 | |
| 				"connection_url": "sample_convection_url",
 | |
| 				"someotherdata":  "testing",
 | |
| 			},
 | |
| 			"allowed_roles":                      []string{"flu", "barre"},
 | |
| 			"root_credentials_rotate_statements": []string{},
 | |
| 		}
 | |
| 		configReq.Operation = logical.ReadOperation
 | |
| 		resp, err = b.HandleRequest(namespace.RootContext(nil), configReq)
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		delete(resp.Data["connection_details"].(map[string]interface{}), "name")
 | |
| 		if !reflect.DeepEqual(expected, resp.Data) {
 | |
| 			t.Fatalf("bad: expected:%#v\nactual:%#v\n", expected, resp.Data)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	req := &logical.Request{
 | |
| 		Operation: logical.ListOperation,
 | |
| 		Storage:   config.StorageView,
 | |
| 		Path:      "config/",
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 	keys := resp.Data["keys"].([]string)
 | |
| 	key := keys[0]
 | |
| 	if key != "plugin-test" {
 | |
| 		t.Fatalf("bad key: %q", key)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestBackend_BadConnectionString(t *testing.T) {
 | |
| 	cluster, sys := getCluster(t)
 | |
| 	defer cluster.Cleanup()
 | |
| 
 | |
| 	config := logical.TestBackendConfig()
 | |
| 	config.StorageView = &logical.InmemStorage{}
 | |
| 	config.System = sys
 | |
| 
 | |
| 	b, err := Factory(context.Background(), config)
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 	defer b.Cleanup(context.Background())
 | |
| 
 | |
| 	cleanup, _ := preparePostgresTestContainer(t, config.StorageView, b)
 | |
| 	defer cleanup()
 | |
| 
 | |
| 	respCheck := func(req *logical.Request) {
 | |
| 		t.Helper()
 | |
| 		resp, err := b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 		if err != nil {
 | |
| 			t.Fatalf("err: %v", err)
 | |
| 		}
 | |
| 		if resp == nil || !resp.IsError() {
 | |
| 			t.Fatalf("expected error, resp:%#v", resp)
 | |
| 		}
 | |
| 		err = resp.Error()
 | |
| 		if strings.Contains(err.Error(), "localhost") {
 | |
| 			t.Fatalf("error should not contain connection info")
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// Configure a connection
 | |
| 	data := map[string]interface{}{
 | |
| 		"connection_url": "postgresql://:pw@[localhost",
 | |
| 		"plugin_name":    "postgresql-database-plugin",
 | |
| 		"allowed_roles":  []string{"plugin-role-test"},
 | |
| 	}
 | |
| 	req := &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "config/plugin-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	respCheck(req)
 | |
| 
 | |
| 	time.Sleep(1 * time.Second)
 | |
| }
 | |
| 
 | |
| func TestBackend_basic(t *testing.T) {
 | |
| 	cluster, sys := getCluster(t)
 | |
| 	defer cluster.Cleanup()
 | |
| 
 | |
| 	config := logical.TestBackendConfig()
 | |
| 	config.StorageView = &logical.InmemStorage{}
 | |
| 	config.System = sys
 | |
| 
 | |
| 	b, err := Factory(context.Background(), config)
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 	defer b.Cleanup(context.Background())
 | |
| 
 | |
| 	cleanup, connURL := preparePostgresTestContainer(t, config.StorageView, b)
 | |
| 	defer cleanup()
 | |
| 
 | |
| 	// Configure a connection
 | |
| 	data := map[string]interface{}{
 | |
| 		"connection_url": connURL,
 | |
| 		"plugin_name":    "postgresql-database-plugin",
 | |
| 		"allowed_roles":  []string{"plugin-role-test"},
 | |
| 	}
 | |
| 	req := &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "config/plugin-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err := b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Create a role
 | |
| 	data = map[string]interface{}{
 | |
| 		"db_name":             "plugin-test",
 | |
| 		"creation_statements": testRole,
 | |
| 		"max_ttl":             "10m",
 | |
| 	}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "roles/plugin-role-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 	// Get creds
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.ReadOperation,
 | |
| 		Path:      "creds/plugin-role-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	credsResp, err := b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (credsResp != nil && credsResp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, credsResp)
 | |
| 	}
 | |
| 	// Update the role with no max ttl
 | |
| 	data = map[string]interface{}{
 | |
| 		"db_name":             "plugin-test",
 | |
| 		"creation_statements": testRole,
 | |
| 		"default_ttl":         "5m",
 | |
| 		"max_ttl":             0,
 | |
| 	}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "roles/plugin-role-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 	// Get creds
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.ReadOperation,
 | |
| 		Path:      "creds/plugin-role-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	credsResp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (credsResp != nil && credsResp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, credsResp)
 | |
| 	}
 | |
| 	// Test for #3812
 | |
| 	if credsResp.Secret.TTL != 5*time.Minute {
 | |
| 		t.Fatalf("unexpected TTL of %d", credsResp.Secret.TTL)
 | |
| 	}
 | |
| 	// Update the role with a max ttl
 | |
| 	data = map[string]interface{}{
 | |
| 		"db_name":             "plugin-test",
 | |
| 		"creation_statements": testRole,
 | |
| 		"default_ttl":         "5m",
 | |
| 		"max_ttl":             "10m",
 | |
| 	}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "roles/plugin-role-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Get creds and revoke when the role stays in existence
 | |
| 	{
 | |
| 		data = map[string]interface{}{}
 | |
| 		req = &logical.Request{
 | |
| 			Operation: logical.ReadOperation,
 | |
| 			Path:      "creds/plugin-role-test",
 | |
| 			Storage:   config.StorageView,
 | |
| 			Data:      data,
 | |
| 		}
 | |
| 		credsResp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 		if err != nil || (credsResp != nil && credsResp.IsError()) {
 | |
| 			t.Fatalf("err:%s resp:%#v\n", err, credsResp)
 | |
| 		}
 | |
| 		// Test for #3812
 | |
| 		if credsResp.Secret.TTL != 5*time.Minute {
 | |
| 			t.Fatalf("unexpected TTL of %d", credsResp.Secret.TTL)
 | |
| 		}
 | |
| 		if !testCredsExist(t, credsResp, connURL) {
 | |
| 			t.Fatalf("Creds should exist")
 | |
| 		}
 | |
| 
 | |
| 		// Revoke creds
 | |
| 		resp, err = b.HandleRequest(namespace.RootContext(nil), &logical.Request{
 | |
| 			Operation: logical.RevokeOperation,
 | |
| 			Storage:   config.StorageView,
 | |
| 			Secret: &logical.Secret{
 | |
| 				InternalData: map[string]interface{}{
 | |
| 					"secret_type": "creds",
 | |
| 					"username":    credsResp.Data["username"],
 | |
| 					"role":        "plugin-role-test",
 | |
| 				},
 | |
| 			},
 | |
| 		})
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		if testCredsExist(t, credsResp, connURL) {
 | |
| 			t.Fatalf("Creds should not exist")
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// Get creds and revoke using embedded revocation data
 | |
| 	{
 | |
| 		data = map[string]interface{}{}
 | |
| 		req = &logical.Request{
 | |
| 			Operation: logical.ReadOperation,
 | |
| 			Path:      "creds/plugin-role-test",
 | |
| 			Storage:   config.StorageView,
 | |
| 			Data:      data,
 | |
| 		}
 | |
| 		credsResp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 		if err != nil || (credsResp != nil && credsResp.IsError()) {
 | |
| 			t.Fatalf("err:%s resp:%#v\n", err, credsResp)
 | |
| 		}
 | |
| 		if !testCredsExist(t, credsResp, connURL) {
 | |
| 			t.Fatalf("Creds should exist")
 | |
| 		}
 | |
| 
 | |
| 		// Delete role, forcing us to rely on embedded data
 | |
| 		req = &logical.Request{
 | |
| 			Operation: logical.DeleteOperation,
 | |
| 			Path:      "roles/plugin-role-test",
 | |
| 			Storage:   config.StorageView,
 | |
| 		}
 | |
| 		resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		// Revoke creds
 | |
| 		resp, err = b.HandleRequest(namespace.RootContext(nil), &logical.Request{
 | |
| 			Operation: logical.RevokeOperation,
 | |
| 			Storage:   config.StorageView,
 | |
| 			Secret: &logical.Secret{
 | |
| 				InternalData: map[string]interface{}{
 | |
| 					"secret_type":           "creds",
 | |
| 					"username":              credsResp.Data["username"],
 | |
| 					"role":                  "plugin-role-test",
 | |
| 					"db_name":               "plugin-test",
 | |
| 					"revocation_statements": nil,
 | |
| 				},
 | |
| 			},
 | |
| 		})
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		if testCredsExist(t, credsResp, connURL) {
 | |
| 			t.Fatalf("Creds should not exist")
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestBackend_connectionCrud(t *testing.T) {
 | |
| 	cluster, sys := getCluster(t)
 | |
| 	defer cluster.Cleanup()
 | |
| 
 | |
| 	config := logical.TestBackendConfig()
 | |
| 	config.StorageView = &logical.InmemStorage{}
 | |
| 	config.System = sys
 | |
| 
 | |
| 	b, err := Factory(context.Background(), config)
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 	defer b.Cleanup(context.Background())
 | |
| 
 | |
| 	cleanup, connURL := preparePostgresTestContainer(t, config.StorageView, b)
 | |
| 	defer cleanup()
 | |
| 
 | |
| 	// Configure a connection
 | |
| 	data := map[string]interface{}{
 | |
| 		"connection_url":    "test",
 | |
| 		"plugin_name":       "postgresql-database-plugin",
 | |
| 		"verify_connection": false,
 | |
| 	}
 | |
| 	req := &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "config/plugin-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err := b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Create a role
 | |
| 	data = map[string]interface{}{
 | |
| 		"db_name":               "plugin-test",
 | |
| 		"creation_statements":   testRole,
 | |
| 		"revocation_statements": defaultRevocationSQL,
 | |
| 		"default_ttl":           "5m",
 | |
| 		"max_ttl":               "10m",
 | |
| 	}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "roles/plugin-role-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Update the connection
 | |
| 	data = map[string]interface{}{
 | |
| 		"connection_url": connURL,
 | |
| 		"plugin_name":    "postgresql-database-plugin",
 | |
| 		"allowed_roles":  []string{"plugin-role-test"},
 | |
| 		"username":       "postgres",
 | |
| 		"password":       "secret",
 | |
| 	}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "config/plugin-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 	if len(resp.Warnings) != 1 {
 | |
| 		t.Fatalf("expected warning about password in url %s, resp:%#v\n", connURL, resp)
 | |
| 	}
 | |
| 
 | |
| 	req.Operation = logical.ReadOperation
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 	if strings.Contains(resp.Data["connection_details"].(map[string]interface{})["connection_url"].(string), "secret") {
 | |
| 		t.Fatal("password should not be found in the connection url")
 | |
| 	}
 | |
| 
 | |
| 	// Replace connection url with templated version
 | |
| 	req.Operation = logical.UpdateOperation
 | |
| 	connURL = strings.Replace(connURL, "postgres:secret", "{{username}}:{{password}}", -1)
 | |
| 	data["connection_url"] = connURL
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Read connection
 | |
| 	expected := map[string]interface{}{
 | |
| 		"plugin_name": "postgresql-database-plugin",
 | |
| 		"connection_details": map[string]interface{}{
 | |
| 			"username":       "postgres",
 | |
| 			"connection_url": connURL,
 | |
| 		},
 | |
| 		"allowed_roles":                      []string{"plugin-role-test"},
 | |
| 		"root_credentials_rotate_statements": []string(nil),
 | |
| 	}
 | |
| 	req.Operation = logical.ReadOperation
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	delete(resp.Data["connection_details"].(map[string]interface{}), "name")
 | |
| 	if diff := deep.Equal(resp.Data, expected); diff != nil {
 | |
| 		t.Fatal(diff)
 | |
| 	}
 | |
| 
 | |
| 	// Reset Connection
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "reset/plugin-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Get creds
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.ReadOperation,
 | |
| 		Path:      "creds/plugin-role-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	credsResp, err := b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (credsResp != nil && credsResp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, credsResp)
 | |
| 	}
 | |
| 
 | |
| 	credCheckURL := dbutil.QueryHelper(connURL, map[string]string{
 | |
| 		"username": "postgres",
 | |
| 		"password": "secret",
 | |
| 	})
 | |
| 	if !testCredsExist(t, credsResp, credCheckURL) {
 | |
| 		t.Fatalf("Creds should exist")
 | |
| 	}
 | |
| 
 | |
| 	// Delete Connection
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.DeleteOperation,
 | |
| 		Path:      "config/plugin-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Read connection
 | |
| 	req.Operation = logical.ReadOperation
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Should be empty
 | |
| 	if resp != nil {
 | |
| 		t.Fatal("Expected response to be nil")
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestBackend_roleCrud(t *testing.T) {
 | |
| 	cluster, sys := getCluster(t)
 | |
| 	defer cluster.Cleanup()
 | |
| 
 | |
| 	config := logical.TestBackendConfig()
 | |
| 	config.StorageView = &logical.InmemStorage{}
 | |
| 	config.System = sys
 | |
| 
 | |
| 	lb, err := Factory(context.Background(), config)
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 	b, ok := lb.(*databaseBackend)
 | |
| 	if !ok {
 | |
| 		t.Fatal("could not convert to db backend")
 | |
| 	}
 | |
| 	defer b.Cleanup(context.Background())
 | |
| 
 | |
| 	cleanup, connURL := preparePostgresTestContainer(t, config.StorageView, b)
 | |
| 	defer cleanup()
 | |
| 
 | |
| 	// Configure a connection
 | |
| 	data := map[string]interface{}{
 | |
| 		"connection_url": connURL,
 | |
| 		"plugin_name":    "postgresql-database-plugin",
 | |
| 	}
 | |
| 	req := &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "config/plugin-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err := b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Test role creation
 | |
| 	{
 | |
| 		data = map[string]interface{}{
 | |
| 			"db_name":               "plugin-test",
 | |
| 			"creation_statements":   testRole,
 | |
| 			"revocation_statements": defaultRevocationSQL,
 | |
| 			"default_ttl":           "5m",
 | |
| 			"max_ttl":               "10m",
 | |
| 		}
 | |
| 		req = &logical.Request{
 | |
| 			Operation: logical.CreateOperation,
 | |
| 			Path:      "roles/plugin-role-test",
 | |
| 			Storage:   config.StorageView,
 | |
| 			Data:      data,
 | |
| 		}
 | |
| 		resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		// Read the role
 | |
| 		data = map[string]interface{}{}
 | |
| 		req = &logical.Request{
 | |
| 			Operation: logical.ReadOperation,
 | |
| 			Path:      "roles/plugin-role-test",
 | |
| 			Storage:   config.StorageView,
 | |
| 			Data:      data,
 | |
| 		}
 | |
| 		resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		expected := dbplugin.Statements{
 | |
| 			Creation:   []string{strings.TrimSpace(testRole)},
 | |
| 			Revocation: []string{strings.TrimSpace(defaultRevocationSQL)},
 | |
| 			Rollback:   []string{},
 | |
| 			Renewal:    []string{},
 | |
| 		}
 | |
| 
 | |
| 		actual := dbplugin.Statements{
 | |
| 			Creation:   resp.Data["creation_statements"].([]string),
 | |
| 			Revocation: resp.Data["revocation_statements"].([]string),
 | |
| 			Rollback:   resp.Data["rollback_statements"].([]string),
 | |
| 			Renewal:    resp.Data["renew_statements"].([]string),
 | |
| 		}
 | |
| 
 | |
| 		if diff := deep.Equal(expected, actual); diff != nil {
 | |
| 			t.Fatal(diff)
 | |
| 		}
 | |
| 
 | |
| 		if diff := deep.Equal(resp.Data["db_name"], "plugin-test"); diff != nil {
 | |
| 			t.Fatal(diff)
 | |
| 		}
 | |
| 		if diff := deep.Equal(resp.Data["default_ttl"], float64(300)); diff != nil {
 | |
| 			t.Fatal(diff)
 | |
| 		}
 | |
| 		if diff := deep.Equal(resp.Data["max_ttl"], float64(600)); diff != nil {
 | |
| 			t.Fatal(diff)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// Test role modification of TTL
 | |
| 	{
 | |
| 		data = map[string]interface{}{
 | |
| 			"name":    "plugin-role-test",
 | |
| 			"max_ttl": "7m",
 | |
| 		}
 | |
| 		req = &logical.Request{
 | |
| 			Operation: logical.UpdateOperation,
 | |
| 			Path:      "roles/plugin-role-test",
 | |
| 			Storage:   config.StorageView,
 | |
| 			Data:      data,
 | |
| 		}
 | |
| 		resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%v resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		// Read the role
 | |
| 		data = map[string]interface{}{}
 | |
| 		req = &logical.Request{
 | |
| 			Operation: logical.ReadOperation,
 | |
| 			Path:      "roles/plugin-role-test",
 | |
| 			Storage:   config.StorageView,
 | |
| 			Data:      data,
 | |
| 		}
 | |
| 		resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		expected := dbplugin.Statements{
 | |
| 			Creation:   []string{strings.TrimSpace(testRole)},
 | |
| 			Revocation: []string{strings.TrimSpace(defaultRevocationSQL)},
 | |
| 			Rollback:   []string{},
 | |
| 			Renewal:    []string{},
 | |
| 		}
 | |
| 
 | |
| 		actual := dbplugin.Statements{
 | |
| 			Creation:   resp.Data["creation_statements"].([]string),
 | |
| 			Revocation: resp.Data["revocation_statements"].([]string),
 | |
| 			Rollback:   resp.Data["rollback_statements"].([]string),
 | |
| 			Renewal:    resp.Data["renew_statements"].([]string),
 | |
| 		}
 | |
| 
 | |
| 		if !reflect.DeepEqual(expected, actual) {
 | |
| 			t.Fatalf("Statements did not match, expected %#v, got %#v", expected, actual)
 | |
| 		}
 | |
| 
 | |
| 		if diff := deep.Equal(resp.Data["db_name"], "plugin-test"); diff != nil {
 | |
| 			t.Fatal(diff)
 | |
| 		}
 | |
| 		if diff := deep.Equal(resp.Data["default_ttl"], float64(300)); diff != nil {
 | |
| 			t.Fatal(diff)
 | |
| 		}
 | |
| 		if diff := deep.Equal(resp.Data["max_ttl"], float64(420)); diff != nil {
 | |
| 			t.Fatal(diff)
 | |
| 		}
 | |
| 
 | |
| 	}
 | |
| 
 | |
| 	// Test role modification of statements
 | |
| 	{
 | |
| 		data = map[string]interface{}{
 | |
| 			"name":                  "plugin-role-test",
 | |
| 			"creation_statements":   []string{testRole, testRole},
 | |
| 			"revocation_statements": []string{defaultRevocationSQL, defaultRevocationSQL},
 | |
| 			"rollback_statements":   testRole,
 | |
| 			"renew_statements":      defaultRevocationSQL,
 | |
| 		}
 | |
| 		req = &logical.Request{
 | |
| 			Operation: logical.UpdateOperation,
 | |
| 			Path:      "roles/plugin-role-test",
 | |
| 			Storage:   config.StorageView,
 | |
| 			Data:      data,
 | |
| 		}
 | |
| 		resp, err = b.HandleRequest(context.Background(), req)
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%v resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		// Read the role
 | |
| 		data = map[string]interface{}{}
 | |
| 		req = &logical.Request{
 | |
| 			Operation: logical.ReadOperation,
 | |
| 			Path:      "roles/plugin-role-test",
 | |
| 			Storage:   config.StorageView,
 | |
| 			Data:      data,
 | |
| 		}
 | |
| 		resp, err = b.HandleRequest(context.Background(), req)
 | |
| 		if err != nil || (resp != nil && resp.IsError()) {
 | |
| 			t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 		}
 | |
| 
 | |
| 		expected := dbplugin.Statements{
 | |
| 			Creation:   []string{strings.TrimSpace(testRole), strings.TrimSpace(testRole)},
 | |
| 			Rollback:   []string{strings.TrimSpace(testRole)},
 | |
| 			Revocation: []string{strings.TrimSpace(defaultRevocationSQL), strings.TrimSpace(defaultRevocationSQL)},
 | |
| 			Renewal:    []string{strings.TrimSpace(defaultRevocationSQL)},
 | |
| 		}
 | |
| 
 | |
| 		actual := dbplugin.Statements{
 | |
| 			Creation:   resp.Data["creation_statements"].([]string),
 | |
| 			Revocation: resp.Data["revocation_statements"].([]string),
 | |
| 			Rollback:   resp.Data["rollback_statements"].([]string),
 | |
| 			Renewal:    resp.Data["renew_statements"].([]string),
 | |
| 		}
 | |
| 
 | |
| 		if diff := deep.Equal(expected, actual); diff != nil {
 | |
| 			t.Fatal(diff)
 | |
| 		}
 | |
| 
 | |
| 		if diff := deep.Equal(resp.Data["db_name"], "plugin-test"); diff != nil {
 | |
| 			t.Fatal(diff)
 | |
| 		}
 | |
| 		if diff := deep.Equal(resp.Data["default_ttl"], float64(300)); diff != nil {
 | |
| 			t.Fatal(diff)
 | |
| 		}
 | |
| 		if diff := deep.Equal(resp.Data["max_ttl"], float64(420)); diff != nil {
 | |
| 			t.Fatal(diff)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// Delete the role
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.DeleteOperation,
 | |
| 		Path:      "roles/plugin-role-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Read the role
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.ReadOperation,
 | |
| 		Path:      "roles/plugin-role-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Should be empty
 | |
| 	if resp != nil {
 | |
| 		t.Fatal("Expected response to be nil")
 | |
| 	}
 | |
| }
 | |
| func TestBackend_allowedRoles(t *testing.T) {
 | |
| 	cluster, sys := getCluster(t)
 | |
| 	defer cluster.Cleanup()
 | |
| 
 | |
| 	config := logical.TestBackendConfig()
 | |
| 	config.StorageView = &logical.InmemStorage{}
 | |
| 	config.System = sys
 | |
| 
 | |
| 	b, err := Factory(context.Background(), config)
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 	defer b.Cleanup(context.Background())
 | |
| 
 | |
| 	cleanup, connURL := preparePostgresTestContainer(t, config.StorageView, b)
 | |
| 	defer cleanup()
 | |
| 
 | |
| 	// Configure a connection
 | |
| 	data := map[string]interface{}{
 | |
| 		"connection_url": connURL,
 | |
| 		"plugin_name":    "postgresql-database-plugin",
 | |
| 	}
 | |
| 	req := &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "config/plugin-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err := b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Create a denied and an allowed role
 | |
| 	data = map[string]interface{}{
 | |
| 		"db_name":             "plugin-test",
 | |
| 		"creation_statements": testRole,
 | |
| 		"default_ttl":         "5m",
 | |
| 		"max_ttl":             "10m",
 | |
| 	}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "roles/denied",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	data = map[string]interface{}{
 | |
| 		"db_name":             "plugin-test",
 | |
| 		"creation_statements": testRole,
 | |
| 		"default_ttl":         "5m",
 | |
| 		"max_ttl":             "10m",
 | |
| 	}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "roles/allowed",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Get creds from denied role, should fail
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.ReadOperation,
 | |
| 		Path:      "creds/denied",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	credsResp, err := b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err == nil {
 | |
| 		t.Fatal("expected error because role is denied")
 | |
| 	}
 | |
| 
 | |
| 	// update connection with glob allowed roles connection
 | |
| 	data = map[string]interface{}{
 | |
| 		"connection_url": connURL,
 | |
| 		"plugin_name":    "postgresql-database-plugin",
 | |
| 		"allowed_roles":  "allow*",
 | |
| 	}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "config/plugin-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Get creds, should work.
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.ReadOperation,
 | |
| 		Path:      "creds/allowed",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	credsResp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (credsResp != nil && credsResp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, credsResp)
 | |
| 	}
 | |
| 
 | |
| 	if !testCredsExist(t, credsResp, connURL) {
 | |
| 		t.Fatalf("Creds should exist")
 | |
| 	}
 | |
| 
 | |
| 	// update connection with * allowed roles connection
 | |
| 	data = map[string]interface{}{
 | |
| 		"connection_url": connURL,
 | |
| 		"plugin_name":    "postgresql-database-plugin",
 | |
| 		"allowed_roles":  "*",
 | |
| 	}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "config/plugin-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Get creds, should work.
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.ReadOperation,
 | |
| 		Path:      "creds/allowed",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	credsResp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (credsResp != nil && credsResp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, credsResp)
 | |
| 	}
 | |
| 
 | |
| 	if !testCredsExist(t, credsResp, connURL) {
 | |
| 		t.Fatalf("Creds should exist")
 | |
| 	}
 | |
| 
 | |
| 	// update connection with allowed roles
 | |
| 	data = map[string]interface{}{
 | |
| 		"connection_url": connURL,
 | |
| 		"plugin_name":    "postgresql-database-plugin",
 | |
| 		"allowed_roles":  "allow, allowed",
 | |
| 	}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "config/plugin-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Get creds from denied role, should fail
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.ReadOperation,
 | |
| 		Path:      "creds/denied",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	credsResp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err == nil {
 | |
| 		t.Fatal("expected error because role is denied")
 | |
| 	}
 | |
| 
 | |
| 	// Get creds from allowed role, should work.
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.ReadOperation,
 | |
| 		Path:      "creds/allowed",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	credsResp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (credsResp != nil && credsResp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, credsResp)
 | |
| 	}
 | |
| 
 | |
| 	if !testCredsExist(t, credsResp, connURL) {
 | |
| 		t.Fatalf("Creds should exist")
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestBackend_RotateRootCredentials(t *testing.T) {
 | |
| 	cluster, sys := getCluster(t)
 | |
| 	defer cluster.Cleanup()
 | |
| 
 | |
| 	config := logical.TestBackendConfig()
 | |
| 	config.StorageView = &logical.InmemStorage{}
 | |
| 	config.System = sys
 | |
| 
 | |
| 	b, err := Factory(context.Background(), config)
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 	defer b.Cleanup(context.Background())
 | |
| 
 | |
| 	cleanup, connURL := preparePostgresTestContainer(t, config.StorageView, b)
 | |
| 	defer cleanup()
 | |
| 
 | |
| 	connURL = strings.Replace(connURL, "postgres:secret", "{{username}}:{{password}}", -1)
 | |
| 
 | |
| 	// Configure a connection
 | |
| 	data := map[string]interface{}{
 | |
| 		"connection_url": connURL,
 | |
| 		"plugin_name":    "postgresql-database-plugin",
 | |
| 		"allowed_roles":  []string{"plugin-role-test"},
 | |
| 		"username":       "postgres",
 | |
| 		"password":       "secret",
 | |
| 	}
 | |
| 	req := &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "config/plugin-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err := b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 
 | |
| 	// Create a role
 | |
| 	data = map[string]interface{}{
 | |
| 		"db_name":             "plugin-test",
 | |
| 		"creation_statements": testRole,
 | |
| 		"max_ttl":             "10m",
 | |
| 	}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "roles/plugin-role-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (resp != nil && resp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, resp)
 | |
| 	}
 | |
| 	// Get creds
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.ReadOperation,
 | |
| 		Path:      "creds/plugin-role-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	credsResp, err := b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (credsResp != nil && credsResp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, credsResp)
 | |
| 	}
 | |
| 
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.UpdateOperation,
 | |
| 		Path:      "rotate-root/plugin-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	resp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (credsResp != nil && credsResp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, credsResp)
 | |
| 	}
 | |
| 
 | |
| 	dbConfig, err := b.(*databaseBackend).DatabaseConfig(context.Background(), config.StorageView, "plugin-test")
 | |
| 	if err != nil {
 | |
| 		t.Fatalf("err: %#v", err)
 | |
| 	}
 | |
| 	if dbConfig.ConnectionDetails["password"].(string) == "secret" {
 | |
| 		t.Fatal("root credentials not rotated")
 | |
| 	}
 | |
| 
 | |
| 	// Get creds to make sure it still works
 | |
| 	data = map[string]interface{}{}
 | |
| 	req = &logical.Request{
 | |
| 		Operation: logical.ReadOperation,
 | |
| 		Path:      "creds/plugin-role-test",
 | |
| 		Storage:   config.StorageView,
 | |
| 		Data:      data,
 | |
| 	}
 | |
| 	credsResp, err = b.HandleRequest(namespace.RootContext(nil), req)
 | |
| 	if err != nil || (credsResp != nil && credsResp.IsError()) {
 | |
| 		t.Fatalf("err:%s resp:%#v\n", err, credsResp)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func testCredsExist(t *testing.T, resp *logical.Response, connURL string) bool {
 | |
| 	t.Helper()
 | |
| 	var d struct {
 | |
| 		Username string `mapstructure:"username"`
 | |
| 		Password string `mapstructure:"password"`
 | |
| 	}
 | |
| 	if err := mapstructure.Decode(resp.Data, &d); err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 	log.Printf("[TRACE] Generated credentials: %v", d)
 | |
| 	conn, err := pq.ParseURL(connURL)
 | |
| 
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 
 | |
| 	conn += " timezone=utc"
 | |
| 
 | |
| 	db, err := sql.Open("postgres", conn)
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 
 | |
| 	returnedRows := func() int {
 | |
| 		stmt, err := db.Prepare("SELECT DISTINCT schemaname FROM pg_tables WHERE has_table_privilege($1, 'information_schema.role_column_grants', 'select');")
 | |
| 		if err != nil {
 | |
| 			return -1
 | |
| 		}
 | |
| 		defer stmt.Close()
 | |
| 
 | |
| 		rows, err := stmt.Query(d.Username)
 | |
| 		if err != nil {
 | |
| 			return -1
 | |
| 		}
 | |
| 		defer rows.Close()
 | |
| 
 | |
| 		i := 0
 | |
| 		for rows.Next() {
 | |
| 			i++
 | |
| 		}
 | |
| 		return i
 | |
| 	}
 | |
| 
 | |
| 	return returnedRows() == 2
 | |
| }
 | |
| 
 | |
| const testRole = `
 | |
| CREATE ROLE "{{name}}" WITH
 | |
|   LOGIN
 | |
|   PASSWORD '{{password}}'
 | |
|   VALID UNTIL '{{expiration}}';
 | |
| GRANT ALL PRIVILEGES ON ALL TABLES IN SCHEMA public TO "{{name}}";
 | |
| `
 | |
| 
 | |
| const defaultRevocationSQL = `
 | |
| REVOKE ALL PRIVILEGES ON ALL TABLES IN SCHEMA public FROM {{name}};
 | |
| REVOKE ALL PRIVILEGES ON ALL SEQUENCES IN SCHEMA public FROM {{name}};
 | |
| REVOKE USAGE ON SCHEMA public FROM {{name}};
 | |
| 
 | |
| DROP ROLE IF EXISTS {{name}};
 | |
| `
 |