Files
vault/ui
claire bontempo f634808ed4 UI: Implement KV patch+subkey [enterprise] (#28212)
* UI: Implement overview page for KV v2 (#28162)

* build json editor patch form

* finish patch component and tests

* add tab to each route

* and path route

* add overview tab to tests

* update overview to use updated_time instead of created_time

* redirect relevant secret.details to secret.index

* compute secretState in component instead of pass as arg

* add capabilities service

* add error handling to fetchSubkeys adapter request

* add overview tabs to test

* add subtext to overview card

* remaining redirects in secret edit

* remove create new version from popup menu

* fix breadcrumbs for overview

* separate adding capabilities service

* add service to kv engine

* Revert "separate adding capabilities service"

This reverts commit bb70b12ab7dbcde0fbd2d4d81768e5c8b1c420cc.

* Revert "add service to kv engine"

This reverts commit bfa880535ef7d529d7610936b2c1aae55673d23f.

* update navigation test

* consistently navigate to secret.index route to be explicit

* finish overview navigation tests

* add copyright header

* update delete tests

* fix nav testrs

* cleanup secret edit redirects

* remove redundant async/awaits

* fix create test

* edge case tests

* secret acceptance tests

* final component tests

* rename kvSecretDetails external route to kvSecretOverview

* add comment

* UI: Add patch route and implement Page::Secret::Patch page component (sidebranch) (#28192)

* add tab to each route

* and path route

* add overview tab to tests

* update overview to use updated_time instead of created_time

* redirect relevant secret.details to secret.index

* compute secretState in component instead of pass as arg

* add capabilities service

* add error handling to fetchSubkeys adapter request

* add patch route and put in page component

* add patch secret action to subkeys card

* fix component name

* add patch capability

* alphabetize computed capabilities

* update links, cleanup selectors

* fix more merge conflict stuff

* add capabilities test

* add models to patch link

* add test for patch route

* rename external route

* add error templates

* make notes about enterprise tests, filter one

* remove errors, transition (redirect) instead

* redirect patch routes

* UI: Move fetching secret data to child route (#28198)

* remove @secret from metadata details

* use metadata model instead of secret in paths page

* put delete back into kv/data adapter

* grant access in control group test

* update metadata route and permissions

* remove secret from parent route, only fetch in details route

* change more permissions to route perms, add tests

* revert overview redirect from list view

* wrap model in conditional for perms

* remove redundant canReadCustomMetadata check

* rename adapter method

* handle overview 404

* remove comment

* add customMetadata as an arg

* update grantAccess in test

* make version param easier to follow

* VAULT-30494 handle 404 jira

* refactor capabilities to return an object

* update create tests

* add test for default truthy capabilities

* remove destroy-all-versions from kv/data adapter

* UI: Add enterprise checks (#28215)

* add enterprise check for subkey card

* add max height and scroll to subkey card

* only fetch subkeys if enterprise

* remove check in overview

* add test

* Update ui/tests/integration/components/kv/page/kv-page-overview-test.js

* fix test failures (#28222)

* add assertion

* add optional chaining

* create/delete versioned secret in each module

* wait for transition

* add another waitUntil

* UI: Add patch latest version to toolbar (#28223)

* add patch latest version action to toolbar

* make isPatchAllowed arg all encompassing

* no longer need model check

* use hash so both promises fire at the same time

* add subkeys to policy

* Update ui/lib/kv/addon/routes/secret.js

* add changelog

* small cleanup items! (#28229)

* add conditional for enterprise checking tabs

* cleanup fetchMultiplePaths method

* add test

* remove todo comment, ticket created and design wants to hold off

* keep transition, update comments

* cleanup tests, add index to breadcrumbs

* add some test coverage

* toggle so value is readable
2024-08-29 16:38:39 -07:00
..
2024-05-07 11:34:21 -05:00
2024-05-07 11:34:21 -05:00
2023-11-14 15:32:17 -07:00
2023-08-01 14:02:21 -05:00
2019-04-03 14:06:20 -07:00
2024-05-07 11:34:21 -05:00
2022-04-19 15:45:20 -06:00
2022-04-20 17:32:03 -05:00
2024-08-22 19:58:58 +00:00
2024-05-07 11:34:21 -05:00
2024-01-08 11:17:11 -06:00
2024-08-22 19:58:58 +00:00

Table of Contents

Vault UI

This README outlines the details of collaborating on this Ember application.

Ember CLI Version Upgrade Matrix

Vault Version Ember Version
1.17.x 5.4.2
1.15.x 4.12.0
1.14.x 4.4.0
1.13.x 4.4.0
1.12.x 3.28.5
1.11.x 3.28.5
1.10.x 3.28.5
1.9.x 3.22.0
1.8.x 3.22.0
1.7.x 3.11.0

Prerequisites

You will need the following things properly installed on your computer.

In order to enforce the same version of yarn across installs, the yarn binary is included in the repo in the .yarn/releases folder. To update to a different version of yarn, use the yarn policies set-version VERSION command. For more information on this, see the documentation.

Running a Vault Server

Before running Vault UI locally, a Vault server must be running. First, ensure Vault dev is built according the instructions in ../README.md.

  • To start a single local Vault server: yarn vault
  • To start a local Vault cluster: yarn vault:cluster

These commands may also be aliased on your local device.

Running the UI locally

To spin up the UI, a Vault server must be running (see previous step). All of the commands below assume you're in the ui/ directory.

These steps will start an Ember CLI server that proxies requests to port 8200, and enable live rebuilding of the application as you change the UI application code. Visit your app at http://localhost:4200.

  1. Install dependencies:

yarn

  1. Run Vault UI and proxy back to a Vault server running on the default port, 8200:

yarn start

If your Vault server is running on a different port you can use the long-form version of the npm script:

ember server --proxy=http://localhost:PORT

Mirage

Mirage can be helpful for mocking backend endpoints. Look in mirage/handlers for existing mocked backends.

Run yarn with mirage: export MIRAGE_DEV_HANDLER=<handler> yarn start

Where handlername is one of the options exported in mirage/handlers/index

Building Vault UI into a Vault Binary

We use the embed package from Go >1.20 to build the static assets of the Ember application into a Vault binary.

This can be done by running these commands from the root directory: make static-dist make dev-ui

This will result in a Vault binary that has the UI built-in - though in a non-dev setup it will still need to be enabled via the ui config or setting VAULT_UI environment variable.

Development

Quick commands

Command Description
yarn start start the app with live reloading (vault must be running on port :8200)
export MIRAGE_DEV_HANDLER=<handler>; yarn start start the app with the mocked mirage backend, with handler provided
make static-dist && make dev-ui build a Vault binary with UI assets (run from root directory not /ui)
ember g component foo -ir core generate a component in the /addon engine
yarn test:filter run non-enterprise in the browser
yarn test:filter -f='<test name>' run tests in the browser, filtering by test name
yarn lint:js lint javascript files

Code Generators

Make use of the many generators for code, try ember help generate for more details. If you're using a component that can be widely-used, consider making it an addon component instead (see this PR for more details)

eg. a reusable component named foo that you'd like in the core engine (read more about Ember engines here).

  • ember g component foo -ir core

The above command creates a template-only component by default. If you'd like to add a backing class, add the -gc flag:

  • ember g component foo -gc -ir core

Running Tests

Running tests will spin up a Vault dev server on port :9200 via a pretest script that testem (the test runner) executes. All of the acceptance tests then run, which proxy requests back to that server. The normal test scripts use ember-exam which split into parallel runs, which is excellent for speed but makes it harder to debug. So we have a custom yarn script that automatically opens all the tests in a browser, and we can pass the -f flag to target the test(s) we're debugging.

  • yarn run test lint & run all the tests (CI uses this)
  • yarn run test:oss lint & run all the non-enterprise tests (CI uses this)
  • yarn run test:quick run all the tests without linting
  • yarn run test:quick-oss run all the non-enterprise tests without linting
  • yarn run test:filter -f="policies" run the filtered test in the browser with no splitting. -f is set to !enterprise by default QUnit's filter config

Linting

  • yarn lint:js
  • yarn lint:hbs
  • yarn lint:fix

Contributing / Best Practices

Hello and thank you for contributing to the Vault UI! Below is a list of patterns we follow on the UI team to keep in mind when contributing to the UI codebase. This is an ever-evolving process, so we welcome any comments, questions or general feedback.

Remember prefixing your branch name with ui/ will run UI tests and skip the go tests. If your PR includes backend changes, do not prefix your branch, instead add the ui label on github. This will trigger the UI test suite to run, in addition to the backend Go tests.