From eac420899717e2d23f6d13304bd67278a7e91730 Mon Sep 17 00:00:00 2001 From: John Crispin Date: Thu, 20 Jan 2022 10:48:35 +0100 Subject: [PATCH 1/2] fixes --- lib/nl80211.c | 76 +++++++++++++++++++++++++++++++++++++++++++++++---- lib/rtnl.c | 1 + 2 files changed, 71 insertions(+), 6 deletions(-) diff --git a/lib/nl80211.c b/lib/nl80211.c index fc24fb8..1d0871a 100644 --- a/lib/nl80211.c +++ b/lib/nl80211.c @@ -45,6 +45,8 @@ limitations under the License. #define err_return(code, ...) do { set_error(code, __VA_ARGS__); return NULL; } while(0) +#define NL80211_ATTR_NOT_IMPLEMENTED 0x10000 + static struct { int code; char *msg; @@ -257,6 +259,14 @@ static const uc_nl_nested_spec_t nl80211_keys_nla = { } }; +#ifndef NL80211_MESHCONF_NOLEARN +#define NL80211_MESHCONF_NOLEARN NL80211_ATTR_NOT_IMPLEMENTED +#endif + +#ifndef NL80211_MESHCONF_CONNECTED_TO_AS +#define NL80211_MESHCONF_CONNECTED_TO_AS NL80211_ATTR_NOT_IMPLEMENTED +#endif + static const uc_nl_nested_spec_t nl80211_mesh_params_nla = { .headsize = 0, .nattrs = 29, @@ -348,6 +358,14 @@ static const uc_nl_nested_spec_t nl80211_nan_func_nla = { } }; +#ifndef NL80211_PMSR_FTM_REQ_ATTR_LMR_FEEDBACK +#define NL80211_PMSR_FTM_REQ_ATTR_LMR_FEEDBACK NL80211_ATTR_NOT_IMPLEMENTED +#endif + +#ifndef NL80211_PMSR_FTM_REQ_ATTR_BSS_COLOR +#define NL80211_PMSR_FTM_REQ_ATTR_BSS_COLOR NL80211_ATTR_NOT_IMPLEMENTED +#endif + static const uc_nl_nested_spec_t nl80211_peer_measurements_peers_req_data_ftm_nla = { .headsize = 0, .nattrs = 13, @@ -497,6 +515,26 @@ static const uc_nl_nested_spec_t nl80211_wiphy_bands_freqs_wmm_nla = { } }; +#ifndef NL80211_FREQUENCY_ATTR_1MHZ +#define NL80211_FREQUENCY_ATTR_1MHZ NL80211_ATTR_NOT_IMPLEMENTED +#endif + +#ifndef NL80211_FREQUENCY_ATTR_2MHZ +#define NL80211_FREQUENCY_ATTR_2MHZ NL80211_ATTR_NOT_IMPLEMENTED +#endif + +#ifndef NL80211_FREQUENCY_ATTR_4MHZ +#define NL80211_FREQUENCY_ATTR_4MHZ NL80211_ATTR_NOT_IMPLEMENTED +#endif + +#ifndef NL80211_FREQUENCY_ATTR_8MHZ +#define NL80211_FREQUENCY_ATTR_8MHZ NL80211_ATTR_NOT_IMPLEMENTED +#endif + +#ifndef NL80211_FREQUENCY_ATTR_16MHZ +#define NL80211_FREQUENCY_ATTR_16MHZ NL80211_ATTR_NOT_IMPLEMENTED +#endif + static const uc_nl_nested_spec_t nl80211_wiphy_bands_freqs_nla = { .headsize = 0, .nattrs = 25, @@ -538,6 +576,10 @@ static const uc_nl_nested_spec_t nl80211_wiphy_bands_rates_nla = { } }; +#ifndef NL80211_BAND_IFTYPE_ATTR_VENDOR_ELEMS +#define NL80211_BAND_IFTYPE_ATTR_VENDOR_ELEMS NL80211_ATTR_NOT_IMPLEMENTED +#endif + static const uc_nl_nested_spec_t nl80211_wiphy_bands_iftype_data_nla = { .headsize = 0, .nattrs = 7, @@ -645,13 +687,26 @@ static const uc_nl_nested_spec_t nl80211_bss_nla = { static const uc_nl_nested_spec_t nl80211_sta_info_bitrate_nla = { .headsize = 0, - .nattrs = 5, + .nattrs = 18, .attrs = { { NL80211_RATE_INFO_BITRATE, "bitrate", DT_U16, 0, NULL }, { NL80211_RATE_INFO_BITRATE32, "bitrate32", DT_U32, 0, NULL }, { NL80211_RATE_INFO_MCS, "mcs", DT_U8, 0, NULL }, { NL80211_RATE_INFO_40_MHZ_WIDTH, "40_mhz_width", DT_FLAG, 0, NULL }, { NL80211_RATE_INFO_SHORT_GI, "short_gi", DT_FLAG, 0, NULL }, + { NL80211_RATE_INFO_VHT_MCS, "vht_mcs", DT_U8, 0, NULL }, + { NL80211_RATE_INFO_VHT_NSS, "vht_nss", DT_U8, 0, NULL }, + { NL80211_RATE_INFO_HE_MCS, "he_mcs", DT_U8, 0, NULL }, + { NL80211_RATE_INFO_HE_NSS, "he_nss", DT_U8, 0, NULL }, + { NL80211_RATE_INFO_HE_GI, "he_gi", DT_U8, 0, NULL }, + { NL80211_RATE_INFO_HE_DCM, "he_dcm", DT_U8, 0, NULL }, + { NL80211_RATE_INFO_HE_RU_ALLOC, "he_ru_alloc", DT_U8, 0, NULL }, + { NL80211_RATE_INFO_40_MHZ_WIDTH, "width_40", DT_FLAG, 0, NULL }, + { NL80211_RATE_INFO_80_MHZ_WIDTH, "width_80", DT_FLAG, 0, NULL }, + { NL80211_RATE_INFO_80P80_MHZ_WIDTH, "width_80p80", DT_FLAG, 0, NULL }, + { NL80211_RATE_INFO_160_MHZ_WIDTH, "width_160", DT_FLAG, 0, NULL }, + { NL80211_RATE_INFO_10_MHZ_WIDTH, "width_10", DT_FLAG, 0, NULL }, + { NL80211_RATE_INFO_5_MHZ_WIDTH, "width_5", DT_FLAG, 0, NULL }, } }; @@ -695,9 +750,13 @@ static const uc_nl_nested_spec_t nl80211_bss_param_nla = { } }; +#ifndef NL80211_STA_INFO_CONNECTED_TO_AS +#define NL80211_STA_INFO_CONNECTED_TO_AS NL80211_ATTR_NOT_IMPLEMENTED +#endif + static const uc_nl_nested_spec_t nl80211_sta_info_nla = { .headsize = 0, - .nattrs = 34, + .nattrs = 35, .attrs = { { NL80211_STA_INFO_INACTIVE_TIME, "inactive_time", DT_U32, 0, NULL }, { NL80211_STA_INFO_RX_BYTES, "rx_bytes", DT_U32, 0, NULL }, @@ -724,21 +783,22 @@ static const uc_nl_nested_spec_t nl80211_sta_info_nla = { { NL80211_STA_INFO_NONPEER_PM, "nonpeer_pm", DT_U32, 0, NULL }, { NL80211_STA_INFO_CHAIN_SIGNAL, "chain_signal", DT_S8, DF_MULTIPLE|DF_AUTOIDX, NULL }, { NL80211_STA_INFO_CHAIN_SIGNAL_AVG, "chain_signal_avg", DT_S8, DF_MULTIPLE|DF_AUTOIDX, NULL }, - { NL80211_STA_INFO_TID_STATS, "tid_stats", DT_NESTED, 0, &nl80211_tid_stats_nla }, + { NL80211_STA_INFO_TID_STATS, "tid_stats", DT_NESTED, DF_MULTIPLE|DF_AUTOIDX, &nl80211_tid_stats_nla }, { NL80211_STA_INFO_BSS_PARAM, "bss_param", DT_NESTED, 0, &nl80211_bss_param_nla }, { NL80211_STA_INFO_RX_DURATION, "rx_duration", DT_U64, 0, NULL }, { NL80211_STA_INFO_TX_DURATION, "tx_duration", DT_U64, 0, NULL }, - { NL80211_STA_INFO_ACK_SIGNAL, "ack_signal", DT_U8, 0, NULL }, - { NL80211_STA_INFO_ACK_SIGNAL_AVG, "ack_signal_avg", DT_U8, 0, NULL }, + { NL80211_STA_INFO_ACK_SIGNAL, "ack_signal", DT_S8, 0, NULL }, + { NL80211_STA_INFO_ACK_SIGNAL_AVG, "ack_signal_avg", DT_S8, 0, NULL }, { NL80211_STA_INFO_AIRTIME_LINK_METRIC, "airtime_link_metric", DT_U32, 0, NULL }, { NL80211_STA_INFO_CONNECTED_TO_AS, "connected_to_as", DT_BOOL, 0, NULL }, { NL80211_STA_INFO_CONNECTED_TO_GATE, "connected_to_gate", DT_BOOL, 0, NULL }, + { NL80211_STA_INFO_CONNECTED_TIME, "connected_time", DT_U32, 0, NULL }, } }; static const uc_nl_nested_spec_t nl80211_msg = { .headsize = 0, - .nattrs = 124, + .nattrs = 125, .attrs = { { NL80211_ATTR_4ADDR, "4addr", DT_U8, 0, NULL }, { NL80211_ATTR_AIRTIME_WEIGHT, "airtime_weight", DT_U16, 0, NULL }, @@ -864,6 +924,7 @@ static const uc_nl_nested_spec_t nl80211_msg = { { NL80211_ATTR_WPA_VERSIONS, "wpa_versions", DT_U32, 0, NULL }, { NL80211_ATTR_SUPPORTED_IFTYPES, "supported_iftypes", DT_NESTED, 0, &nl80211_ifcomb_limit_types_nla }, { NL80211_ATTR_SOFTWARE_IFTYPES, "software_iftypes", DT_NESTED, 0, &nl80211_ifcomb_limit_types_nla }, + { NL80211_ATTR_MAX_AP_ASSOC_STA, "max_ap_assoc", DT_U16, 0, NULL }, } }; @@ -1044,6 +1105,9 @@ uc_nl_parse_attrs(struct nl_msg *msg, char *base, const uc_nl_attr_spec_t *attrs bool exists; for (i = 0; i < nattrs; i++) { + if (attrs[i].attr == NL80211_ATTR_NOT_IMPLEMENTED) + continue; + v = ucv_object_get(obj, attrs[i].key, &exists); if (!exists) diff --git a/lib/rtnl.c b/lib/rtnl.c index b6a3e38..c1d2088 100644 --- a/lib/rtnl.c +++ b/lib/rtnl.c @@ -682,6 +682,7 @@ static const uc_nl_nested_spec_t link_msg = { { IFLA_UNSPEC, "type", DT_U16, 0, MEMBER(ifinfomsg, ifi_type) }, { IFLA_UNSPEC, "dev", DT_NETDEV, 0, MEMBER(ifinfomsg, ifi_index) }, { IFLA_UNSPEC, "flags", DT_FLAGS, 0, MEMBER(ifinfomsg, ifi_flags) }, + { IFLA_UNSPEC, "change", DT_FLAGS, 0, MEMBER(ifinfomsg, ifi_change) }, { IFLA_ADDRESS, "address", DT_LLADDR, 0, NULL }, { IFLA_BROADCAST, "broadcast", DT_LLADDR, 0, NULL }, { IFLA_TXQLEN, "txqlen", DT_U32, 0, NULL }, -- 2.25.1