mirror of
https://github.com/Telecominfraproject/wlan-ap.git
synced 2025-10-30 01:52:51 +00:00
39 lines
1.6 KiB
Diff
39 lines
1.6 KiB
Diff
From: Nathan Chancellor <natechancellor@gmail.com>
|
|
Date: Mon, 6 Apr 2020 20:09:27 -0700
|
|
Subject: [PATCH] kernel/extable.c: use address-of operator on section symbols
|
|
|
|
Clang warns:
|
|
|
|
../kernel/extable.c:37:52: warning: array comparison always evaluates to
|
|
a constant [-Wtautological-compare]
|
|
if (main_extable_sort_needed && __stop___ex_table > __start___ex_table) {
|
|
^
|
|
1 warning generated.
|
|
|
|
These are not true arrays, they are linker defined symbols, which are just
|
|
addresses. Using the address of operator silences the warning and does
|
|
not change the resulting assembly with either clang/ld.lld or gcc/ld
|
|
(tested with diff + objdump -Dr).
|
|
|
|
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
|
|
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
|
|
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
|
|
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
|
|
Link: https://github.com/ClangBuiltLinux/linux/issues/892
|
|
Link: http://lkml.kernel.org/r/20200219202036.45702-1-natechancellor@gmail.com
|
|
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
|
|
---
|
|
|
|
--- a/kernel/extable.c
|
|
+++ b/kernel/extable.c
|
|
@@ -34,7 +34,8 @@ u32 __initdata __visible main_extable_so
|
|
/* Sort the kernel's built-in exception table */
|
|
void __init sort_main_extable(void)
|
|
{
|
|
- if (main_extable_sort_needed && __stop___ex_table > __start___ex_table) {
|
|
+ if (main_extable_sort_needed &&
|
|
+ &__stop___ex_table > &__start___ex_table) {
|
|
pr_notice("Sorting __ex_table...\n");
|
|
sort_extable(__start___ex_table, __stop___ex_table);
|
|
}
|