From 8361e4ca1e89e24e7136b3631b3ae4d23f7a36cd Mon Sep 17 00:00:00 2001 From: Matias Fontanini Date: Fri, 19 Aug 2016 14:12:44 -0700 Subject: [PATCH] Use another name for Metadata::get_topics when using a prefix --- include/cppkafka/metadata.h | 2 +- src/metadata.cpp | 2 +- tests/kafka_handle_base_test.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/cppkafka/metadata.h b/include/cppkafka/metadata.h index 05a948d..a705aa2 100644 --- a/include/cppkafka/metadata.h +++ b/include/cppkafka/metadata.h @@ -164,7 +164,7 @@ public: * * \param prefix The prefix to be looked up */ - std::vector get_topics(const std::string& prefix) const; + std::vector get_topics_prefixed(const std::string& prefix) const; private: using HandlePtr = std::unique_ptr; diff --git a/src/metadata.cpp b/src/metadata.cpp index 4d98dd4..c6dd12c 100644 --- a/src/metadata.cpp +++ b/src/metadata.cpp @@ -144,7 +144,7 @@ vector Metadata::get_topics(const unordered_set& topics) return output; } -vector Metadata::get_topics(const string& prefix) const { +vector Metadata::get_topics_prefixed(const string& prefix) const { vector output; for (int i = 0; i < handle_->topic_cnt; ++i) { const rd_kafka_metadata_topic_t& topic = handle_->topics[i]; diff --git a/tests/kafka_handle_base_test.cpp b/tests/kafka_handle_base_test.cpp index c424af4..69c9cea 100644 --- a/tests/kafka_handle_base_test.cpp +++ b/tests/kafka_handle_base_test.cpp @@ -91,7 +91,7 @@ TEST_F(KafkaHandleBaseTest, TopicsMetadata) { // Find by names EXPECT_EQ(topic_names.size(), metadata.get_topics(topic_names).size()); // Find by prefix - EXPECT_EQ(topic_names.size(), metadata.get_topics("cppkafka_").size()); + EXPECT_EQ(topic_names.size(), metadata.get_topics_prefixed("cppkafka_").size()); // Now get the whole metadata only for this topic Topic topic = producer.get_topic(KAFKA_TOPIC);