scottk/wlan-cloud-lib-poco
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/wlan-cloud-lib-poco.git synced 2025-11-21 20:35:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

4307/8/9/10 data races (#4312)

Browse Source 
* fix(NumericString): properly mark uIntToString deprecated #4304

* dev(runLibtests): allow to specify test to run

* fix(NotificationCenter): data race #4307

* fix(DirectoryWatcher): data race #4308

* fix(ArchiveStrategy): data race #4309

* fix(ActiveThread): data race #4310

* fix(Task): Cancelled Task shouldn't start running #4311 (WIP)

* fix(String): ignore clang loop unrolling warnings

* fix(TaskManager): task ownership #4311

* chore(FIFOEventTest): fix unused var warning; disable benchmark in test

* fix(Task): remove unnecessary mutex (and prevent cyclic locking reported by TSAN)

* fix(CryptoTest): disable testEncryptDecryptGCM

* fix(ci): typo

* fix(NotificationCenter): disable and clear observers in dtor (#4307)

---------

Co-authored-by: Matej Kenda <matejken@gmail.com>
This commit is contained in:
Aleksandar Fabijanic
2023-12-09 21:16:24 +01:00
committed by GitHub
parent 35e1490b26
commit 1e90f64bbf
19 changed files with 303 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
Foundation/src/ActiveThreadPool.cpp
View File

@@ -28,11 +28,14 @@ namespace Poco {
class NewActionNotification: public Notification
{
public:
NewActionNotification(Thread::Priority priority, Runnable &runnable, std::string name) :
_priority(priority),
_runnable(runnable),
_name(std::move(name))
{ }
using Ptr = AutoPtr<NewActionNotification>;
NewActionNotification(Thread::Priority priority, Runnable& runnable, const std::string& name) :
_priority(priority),
_runnable(runnable),
_name(name)
{
}
~NewActionNotification() override = default;
@@ -41,16 +44,16 @@ public:
return _runnable;
}
Thread::Priority priotity() const
Thread::Priority priority() const
{
return _priority;
}
const std::string &threadName() const
{
return _name;
}
std::string threadFullName() const
{
std::string fullName(_name);
@@ -68,8 +71,8 @@ public:
}
private:
Thread::Priority _priority;
Runnable &_runnable;
std::atomic<Thread::Priority> _priority;
Runnable& _runnable;
std::string _name;
};
@@ -87,13 +90,13 @@ public:
void run() override;
private:
NotificationQueue _pTargetQueue;
std::string _name;
Thread _thread;
Event _targetCompleted;
FastMutex _mutex;
const long JOIN_TIMEOUT = 10000;
std::atomic<bool> _needToStop{false};
NotificationQueue _pTargetQueue;
std::string _name;
Thread _thread;
Event _targetCompleted;
FastMutex _mutex;
const long JOIN_TIMEOUT = 10000;
std::atomic<bool> _needToStop{false};
};
@@ -157,16 +160,18 @@ void ActiveThread::release()
void ActiveThread::run()
{
do {
auto *_pTarget = dynamic_cast<NewActionNotification*>(_pTargetQueue.waitDequeueNotification());
while (_pTarget)
do
{
AutoPtr<Notification> pN = _pTargetQueue.waitDequeueNotification();
while (pN)
{
Runnable* pTarget = &_pTarget->runnable();
_thread.setPriority(_pTarget->priotity());
_thread.setName(_pTarget->name());
NewActionNotification::Ptr pNAN = pN.cast<NewActionNotification>();
Runnable& target = pNAN->runnable();
_thread.setPriority(pNAN->priority());
_thread.setName(pNAN->name());
try
{
pTarget->run();
target.run();
}
catch (Exception& exc)
{
@@ -180,11 +185,10 @@ void ActiveThread::run()
{
ErrorHandler::handle();
}
_pTarget->release();
_thread.setName(_name);
_thread.setPriority(Thread::PRIO_NORMAL);
ThreadLocalStorage::clear();
_pTarget = dynamic_cast<NewActionNotification*>(_pTargetQueue.waitDequeueNotification(1000));
pN = _pTargetQueue.waitDequeueNotification(1000);
}
_targetCompleted.set();
}