mirror of
				https://github.com/Telecominfraproject/wlan-cloud-opensync-controller.git
				synced 2025-10-31 10:37:51 +00:00 
			
		
		
		
	WIFI-2080 update based on review comments
This commit is contained in:
		| @@ -43,7 +43,7 @@ import com.telecominfraproject.wlan.equipmentgateway.models.CEGWConfigChangeNoti | |||||||
| import com.telecominfraproject.wlan.equipmentgateway.models.CEGWFirmwareDownloadRequest; | import com.telecominfraproject.wlan.equipmentgateway.models.CEGWFirmwareDownloadRequest; | ||||||
| import com.telecominfraproject.wlan.equipmentgateway.models.CEGWFirmwareFlashRequest; | import com.telecominfraproject.wlan.equipmentgateway.models.CEGWFirmwareFlashRequest; | ||||||
| import com.telecominfraproject.wlan.equipmentgateway.models.CEGWNewChannelRequest; | import com.telecominfraproject.wlan.equipmentgateway.models.CEGWNewChannelRequest; | ||||||
| import com.telecominfraproject.wlan.equipmentgateway.models.CEGWCellSizeRequest; | import com.telecominfraproject.wlan.equipmentgateway.models.CEGWCellSizeAttributesRequest; | ||||||
| import com.telecominfraproject.wlan.equipmentgateway.models.CEGWRadioResetRequest; | import com.telecominfraproject.wlan.equipmentgateway.models.CEGWRadioResetRequest; | ||||||
| import com.telecominfraproject.wlan.equipmentgateway.models.CEGWRebootRequest; | import com.telecominfraproject.wlan.equipmentgateway.models.CEGWRebootRequest; | ||||||
| import com.telecominfraproject.wlan.equipmentgateway.models.CEGWRouteCheck; | import com.telecominfraproject.wlan.equipmentgateway.models.CEGWRouteCheck; | ||||||
| @@ -207,8 +207,8 @@ public class OpensyncCloudGatewayController { | |||||||
|                     case NewChannelRequest: |                     case NewChannelRequest: | ||||||
|                         ret.add(sendNewChannelRequest(session, (CEGWNewChannelRequest) command)); |                         ret.add(sendNewChannelRequest(session, (CEGWNewChannelRequest) command)); | ||||||
|                         break; |                         break; | ||||||
|                     case CellSizeRequest: |                     case CellSizeAttributesRequest: | ||||||
|                         ret.add(sendCellSizeRequest(session, (CEGWCellSizeRequest) command)); |                         ret.add(sendCellSizeRequest(session, (CEGWCellSizeAttributesRequest) command)); | ||||||
|                         break; |                         break; | ||||||
|                     default: |                     default: | ||||||
|                         LOG.warn("[{}] Failed to deliver command {}, unsupported command type", inventoryId, command); |                         LOG.warn("[{}] Failed to deliver command {}, unsupported command type", inventoryId, command); | ||||||
| @@ -302,7 +302,7 @@ public class OpensyncCloudGatewayController { | |||||||
|         return sendMessage(session, command.getInventoryId(), command); |         return sendMessage(session, command.getInventoryId(), command); | ||||||
|     } |     } | ||||||
|      |      | ||||||
|     private EquipmentCommandResponse sendCellSizeRequest(OvsdbSession session, CEGWCellSizeRequest command) { |     private EquipmentCommandResponse sendCellSizeRequest(OvsdbSession session, CEGWCellSizeAttributesRequest command) { | ||||||
|         return sendMessage(session, command.getInventoryId(), command); |         return sendMessage(session, command.getInventoryId(), command); | ||||||
|     } |     } | ||||||
|  |  | ||||||
| @@ -342,8 +342,8 @@ public class OpensyncCloudGatewayController { | |||||||
|  |  | ||||||
|             String resultDetails = tipwlanOvsdbClient.processNewChannelsRequest(inventoryId, newBackupChannels,newPrimaryChannels); |             String resultDetails = tipwlanOvsdbClient.processNewChannelsRequest(inventoryId, newBackupChannels,newPrimaryChannels); | ||||||
|             response.setResultDetail(resultDetails); |             response.setResultDetail(resultDetails); | ||||||
|         } else if (command instanceof CEGWCellSizeRequest) { |         } else if (command instanceof CEGWCellSizeAttributesRequest) { | ||||||
|             CEGWCellSizeRequest request = (CEGWCellSizeRequest) command; |             CEGWCellSizeAttributesRequest request = (CEGWCellSizeAttributesRequest) command; | ||||||
|             Map<RadioType, CellSizeAttributes> cellSizeAttributeMap = request.getCellSizeAttributesMap(); |             Map<RadioType, CellSizeAttributes> cellSizeAttributeMap = request.getCellSizeAttributesMap(); | ||||||
|  |  | ||||||
|             String resultDetails = tipwlanOvsdbClient.processCellSizeAttributesRequest(inventoryId, cellSizeAttributeMap); |             String resultDetails = tipwlanOvsdbClient.processCellSizeAttributesRequest(inventoryId, cellSizeAttributeMap); | ||||||
|   | |||||||
| @@ -327,8 +327,9 @@ public class OvsdbRrmConfig extends OvsdbDaoBase { | |||||||
|                     // for insert, make sure it is actually in the table |                     // for insert, make sure it is actually in the table | ||||||
|                     confirmRowExistsInTable(ovsdbClient, ((InsertResult) res).getUuid(), wifiRrmConfigDbTable); |                     confirmRowExistsInTable(ovsdbClient, ((InsertResult) res).getUuid(), wifiRrmConfigDbTable); | ||||||
|                 } else if (res instanceof ErrorResult) { |                 } else if (res instanceof ErrorResult) { | ||||||
|                     LOG.error("configureWifiRrm error {}", (res)); |                     LOG.error("processCellSizeAttributesRequest error {}", (res)); | ||||||
|                     throw new RuntimeException("configureWifiRrm " + ((ErrorResult) res).getError() + " " + ((ErrorResult) res).getDetails()); |                     throw new RuntimeException("processCellSizeAttributesRequest " + ((ErrorResult) res).getError() + | ||||||
|  |                             " " + ((ErrorResult) res).getDetails()); | ||||||
|                 } |                 } | ||||||
|             } |             } | ||||||
|  |  | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 Lynn Shi
					Lynn Shi