From 7af93a052d2450da2f911f952e13f46ae2d74401 Mon Sep 17 00:00:00 2001 From: Dmitry Toptygin Date: Thu, 25 Jun 2020 12:24:25 -0400 Subject: [PATCH] fixed NPE in OvsdbDao.updateVifConfigsSetForRadio --- .../wlan/opensync/ovsdb/dao/OvsdbDao.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/opensync-gateway/src/main/java/com/telecominfraproject/wlan/opensync/ovsdb/dao/OvsdbDao.java b/opensync-gateway/src/main/java/com/telecominfraproject/wlan/opensync/ovsdb/dao/OvsdbDao.java index 17edeff..3dfce25 100644 --- a/opensync-gateway/src/main/java/com/telecominfraproject/wlan/opensync/ovsdb/dao/OvsdbDao.java +++ b/opensync-gateway/src/main/java/com/telecominfraproject/wlan/opensync/ovsdb/dao/OvsdbDao.java @@ -1983,18 +1983,22 @@ public class OvsdbDao { fResult = ovsdbClient.transact(ovsdbName, operations); result = fResult.get(ovsdbTimeoutSec, TimeUnit.SECONDS); - Set vifConfigsSet = null; + Set vifConfigsSet = new HashSet(); if (result != null && result.length > 0 && !((SelectResult) result[0]).getRows().isEmpty()) { row = ((SelectResult) result[0]).getRows().iterator().next(); if (row != null) { vifConfigsSet = row.getSetColumn("vif_configs"); - } else { - vifConfigsSet = new HashSet(); + if(vifConfigsSet == null) { + vifConfigsSet = new HashSet(); + } } } - vifConfigsSet.add(vifConfigUuid); + if(vifConfigUuid!=null) { + vifConfigsSet.add(vifConfigUuid); + } + com.vmware.ovsdb.protocol.operation.notation.Set vifConfigs = com.vmware.ovsdb.protocol.operation.notation.Set .of(vifConfigsSet);