mirror of
				https://github.com/Telecominfraproject/wlan-cloud-opensync-controller.git
				synced 2025-11-03 20:17:53 +00:00 
			
		
		
		
	Fix Config MAP for non-encrypted mode, allow externalize bridge name
This commit is contained in:
		@@ -35,6 +35,8 @@ OVSDB_EQUIPMENT_CONFIG_FILE="${OVSDB_EQUIPMENT_CONFIG_FILE:=/app/opensync/Equipm
 | 
				
			|||||||
OVSDB_APPROFILE_CONFIG_FILE="${OVSDB_AP_PROFILE_CONFIG_FILE:=/app/opensync/ProfileAPExample.json}"
 | 
					OVSDB_APPROFILE_CONFIG_FILE="${OVSDB_AP_PROFILE_CONFIG_FILE:=/app/opensync/ProfileAPExample.json}"
 | 
				
			||||||
OVSDB_SSIDPROFILE_CONFIG_FILE="${OVSDB_SSIDPROFILE_CONFIG_FILE:=/app/opensync/ProfileSsid.json}"
 | 
					OVSDB_SSIDPROFILE_CONFIG_FILE="${OVSDB_SSIDPROFILE_CONFIG_FILE:=/app/opensync/ProfileSsid.json}"
 | 
				
			||||||
OVSDB_LOCATION_CONFIG_FILE="${OVSDB_LOCATION_CONFIG_FILE:=/app/opensync/LocationBuildingExample.json}"
 | 
					OVSDB_LOCATION_CONFIG_FILE="${OVSDB_LOCATION_CONFIG_FILE:=/app/opensync/LocationBuildingExample.json}"
 | 
				
			||||||
 | 
					OVSDB_IF_DEFAULT_BRIDGE="${OVSDB_IF_DEFAULT_BRIDGE:=br-home}"
 | 
				
			||||||
 | 
					echo $OVSDB_IF_DEFAULT_BRIDGE
 | 
				
			||||||
OVSDB_IF_DEFAULT_RADIO_0="${OVSDB_IF_DEFAULT_RADIO_0:=home-ap-u50}"
 | 
					OVSDB_IF_DEFAULT_RADIO_0="${OVSDB_IF_DEFAULT_RADIO_0:=home-ap-u50}"
 | 
				
			||||||
echo $OVSDB_IF_DEFAULT_RADIO_0
 | 
					echo $OVSDB_IF_DEFAULT_RADIO_0
 | 
				
			||||||
OVSDB_IF_DEFAULT_RADIO_1="${OVSDB_IF_DEFAULT_RADIO_1:=home-ap-24}"
 | 
					OVSDB_IF_DEFAULT_RADIO_1="${OVSDB_IF_DEFAULT_RADIO_1:=home-ap-24}"
 | 
				
			||||||
@@ -123,6 +125,7 @@ OVSDB_PROPS="$OVSDB_PROPS -Dconnectus.ovsdb.customerEquipmentFileName=$OVSDB_EQU
 | 
				
			|||||||
OVSDB_PROPS="$OVSDB_PROPS -Dconnectus.ovsdb.apProfileFileName=$OVSDB_APPROFILE_CONFIG_FILE"
 | 
					OVSDB_PROPS="$OVSDB_PROPS -Dconnectus.ovsdb.apProfileFileName=$OVSDB_APPROFILE_CONFIG_FILE"
 | 
				
			||||||
OVSDB_PROPS="$OVSDB_PROPS -Dconnectus.ovsdb.ssidProfileFileName=$OVSDB_SSIDPROFILE_CONFIG_FILE"
 | 
					OVSDB_PROPS="$OVSDB_PROPS -Dconnectus.ovsdb.ssidProfileFileName=$OVSDB_SSIDPROFILE_CONFIG_FILE"
 | 
				
			||||||
OVSDB_PROPS="$OVSDB_PROPS -Dconnectus.ovsdb.locationFileName=$OVSDB_LOCATION_CONFIG_FILE"
 | 
					OVSDB_PROPS="$OVSDB_PROPS -Dconnectus.ovsdb.locationFileName=$OVSDB_LOCATION_CONFIG_FILE"
 | 
				
			||||||
 | 
					OVSDB_PROPS="$OVSDB_PROPS -Dconnectus.ovsdb.wifi-iface.default_bridge=$OVSDB_IF_DEFAULT_BRIDGE"
 | 
				
			||||||
OVSDB_PROPS="$OVSDB_PROPS -Dconnectus.ovsdb.wifi-iface.default_radio0=$OVSDB_IF_DEFAULT_RADIO_0"
 | 
					OVSDB_PROPS="$OVSDB_PROPS -Dconnectus.ovsdb.wifi-iface.default_radio0=$OVSDB_IF_DEFAULT_RADIO_0"
 | 
				
			||||||
OVSDB_PROPS="$OVSDB_PROPS -Dconnectus.ovsdb.wifi-iface.default_radio1=$OVSDB_IF_DEFAULT_RADIO_1"
 | 
					OVSDB_PROPS="$OVSDB_PROPS -Dconnectus.ovsdb.wifi-iface.default_radio1=$OVSDB_IF_DEFAULT_RADIO_1"
 | 
				
			||||||
OVSDB_PROPS="$OVSDB_PROPS -Dconnectus.ovsdb.wifi-iface.default_radio2=$OVSDB_IF_DEFAULT_RADIO_2"
 | 
					OVSDB_PROPS="$OVSDB_PROPS -Dconnectus.ovsdb.wifi-iface.default_radio2=$OVSDB_IF_DEFAULT_RADIO_2"
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -23,6 +23,7 @@ OVSDB_PROPS+=" -Dconnectus.ovsdb.customerEquipmentFileName=$OVSDB_EQUIPMENT_CONF
 | 
				
			|||||||
OVSDB_PROPS+=" -Dconnectus.ovsdb.apProfileFileName=$OVSDB_APPROFILE_CONFIG_FILE"
 | 
					OVSDB_PROPS+=" -Dconnectus.ovsdb.apProfileFileName=$OVSDB_APPROFILE_CONFIG_FILE"
 | 
				
			||||||
OVSDB_PROPS+=" -Dconnectus.ovsdb.ssidProfileFileName=$OVSDB_SSIDPROFILE_CONFIG_FILE"
 | 
					OVSDB_PROPS+=" -Dconnectus.ovsdb.ssidProfileFileName=$OVSDB_SSIDPROFILE_CONFIG_FILE"
 | 
				
			||||||
OVSDB_PROPS+=" -Dconnectus.ovsdb.locationFileName=$OVSDB_LOCATION_CONFIG_FILE"
 | 
					OVSDB_PROPS+=" -Dconnectus.ovsdb.locationFileName=$OVSDB_LOCATION_CONFIG_FILE"
 | 
				
			||||||
 | 
					OVSDB_PROPS+=" -Dconnectus.ovsdb.wifi-iface.default_bridge=$OVSDB_IF_DEFAULT_BRIDGE"
 | 
				
			||||||
OVSDB_PROPS+=" -Dconnectus.ovsdb.wifi-iface.default_radio0=$OVSDB_IF_DEFAULT_RADIO_0"
 | 
					OVSDB_PROPS+=" -Dconnectus.ovsdb.wifi-iface.default_radio0=$OVSDB_IF_DEFAULT_RADIO_0"
 | 
				
			||||||
OVSDB_PROPS+=" -Dconnectus.ovsdb.wifi-iface.default_radio1=$OVSDB_IF_DEFAULT_RADIO_1"
 | 
					OVSDB_PROPS+=" -Dconnectus.ovsdb.wifi-iface.default_radio1=$OVSDB_IF_DEFAULT_RADIO_1"
 | 
				
			||||||
OVSDB_PROPS+=" -Dconnectus.ovsdb.wifi-iface.default_radio2=$OVSDB_IF_DEFAULT_RADIO_2"
 | 
					OVSDB_PROPS+=" -Dconnectus.ovsdb.wifi-iface.default_radio2=$OVSDB_IF_DEFAULT_RADIO_2"
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -82,6 +82,9 @@ public class OvsdbDao {
 | 
				
			|||||||
	@org.springframework.beans.factory.annotation.Value("${connectus.ovsdb.timeoutSec:30}")
 | 
						@org.springframework.beans.factory.annotation.Value("${connectus.ovsdb.timeoutSec:30}")
 | 
				
			||||||
	private int ovsdbTimeoutSec;
 | 
						private int ovsdbTimeoutSec;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
						@org.springframework.beans.factory.annotation.Value("${connectus.ovsdb.wifi-iface.default_bridge:br-home}")
 | 
				
			||||||
 | 
						public String bridgeNameVifInterfaces;
 | 
				
			||||||
 | 
						
 | 
				
			||||||
	@org.springframework.beans.factory.annotation.Value("${connectus.ovsdb.wifi-iface.default_radio1:home-ap-24}")
 | 
						@org.springframework.beans.factory.annotation.Value("${connectus.ovsdb.wifi-iface.default_radio1:home-ap-24}")
 | 
				
			||||||
	public String ifName2pt4GHz;
 | 
						public String ifName2pt4GHz;
 | 
				
			||||||
	@org.springframework.beans.factory.annotation.Value("${connectus.ovsdb.wifi-iface.default_radio2:home-ap-l50}")
 | 
						@org.springframework.beans.factory.annotation.Value("${connectus.ovsdb.wifi-iface.default_radio2:home-ap-l50}")
 | 
				
			||||||
@@ -1040,7 +1043,6 @@ public class OvsdbDao {
 | 
				
			|||||||
//	public static final String homeApL50 = "home-ap-l50";
 | 
					//	public static final String homeApL50 = "home-ap-l50";
 | 
				
			||||||
//	public static final String homeApU50 = "home-ap-u50";
 | 
					//	public static final String homeApU50 = "home-ap-u50";
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	public static final String brHome = "br-home";
 | 
					 | 
				
			||||||
	public static final String brWan = "br-wan";
 | 
						public static final String brWan = "br-wan";
 | 
				
			||||||
	public static final String brLan = "br-lan";
 | 
						public static final String brLan = "br-lan";
 | 
				
			||||||
 | 
					
 | 
				
			||||||
@@ -1064,16 +1066,16 @@ public class OvsdbDao {
 | 
				
			|||||||
			Map<String, String> patchW2hOptions = new HashMap<>();
 | 
								Map<String, String> patchW2hOptions = new HashMap<>();
 | 
				
			||||||
			patchH2wOptions.put("peer", "patch-h2w");
 | 
								patchH2wOptions.put("peer", "patch-h2w");
 | 
				
			||||||
 | 
					
 | 
				
			||||||
			provisionSingleBridgePortInterface(ovsdbClient, patchH2w, brHome, "patch", patchH2wOptions,
 | 
								provisionSingleBridgePortInterface(ovsdbClient, patchH2w, bridgeNameVifInterfaces, "patch", patchH2wOptions,
 | 
				
			||||||
					provisionedInterfaces, provisionedPorts, provisionedBridges);
 | 
										provisionedInterfaces, provisionedPorts, provisionedBridges);
 | 
				
			||||||
			provisionSingleBridgePortInterface(ovsdbClient, patchW2h, brWan, "patch", patchW2hOptions,
 | 
								provisionSingleBridgePortInterface(ovsdbClient, patchW2h, brWan, "patch", patchW2hOptions,
 | 
				
			||||||
					provisionedInterfaces, provisionedPorts, provisionedBridges);
 | 
										provisionedInterfaces, provisionedPorts, provisionedBridges);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
			provisionSingleBridgePortInterface(ovsdbClient, ifName5GHzU, brHome, "vif", null, provisionedInterfaces,
 | 
								provisionSingleBridgePortInterface(ovsdbClient, ifName5GHzU, bridgeNameVifInterfaces, "vif", null, provisionedInterfaces,
 | 
				
			||||||
					provisionedPorts, provisionedBridges);
 | 
										provisionedPorts, provisionedBridges);
 | 
				
			||||||
			provisionSingleBridgePortInterface(ovsdbClient, ifName5GHzL, brHome, "vif", null, provisionedInterfaces,
 | 
								provisionSingleBridgePortInterface(ovsdbClient, ifName5GHzL, bridgeNameVifInterfaces, "vif", null, provisionedInterfaces,
 | 
				
			||||||
					provisionedPorts, provisionedBridges);
 | 
										provisionedPorts, provisionedBridges);
 | 
				
			||||||
			provisionSingleBridgePortInterface(ovsdbClient, ifName2pt4GHz, brHome, "vif", null, provisionedInterfaces,
 | 
								provisionSingleBridgePortInterface(ovsdbClient, ifName2pt4GHz, bridgeNameVifInterfaces, "vif", null, provisionedInterfaces,
 | 
				
			||||||
					provisionedPorts, provisionedBridges);
 | 
										provisionedPorts, provisionedBridges);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
		} catch (OvsdbClientException | TimeoutException | ExecutionException | InterruptedException e) {
 | 
							} catch (OvsdbClientException | TimeoutException | ExecutionException | InterruptedException e) {
 | 
				
			||||||
@@ -1935,37 +1937,31 @@ public class OvsdbDao {
 | 
				
			|||||||
					opensyncSecurityMode = "WEP";
 | 
										opensyncSecurityMode = "WEP";
 | 
				
			||||||
				
 | 
									
 | 
				
			||||||
				security.put("encryption", opensyncSecurityMode);
 | 
									security.put("encryption", opensyncSecurityMode);
 | 
				
			||||||
 | 
									// key and mode is N/A for OPEN security
 | 
				
			||||||
 | 
									if (!opensyncSecurityMode.equals("OPEN")) {
 | 
				
			||||||
					security.put("key", ssidConfig.getKeyStr());
 | 
										security.put("key", ssidConfig.getKeyStr());
 | 
				
			||||||
					security.put("mode", Long.toString(ssidConfig.getSecureMode().getId()));
 | 
										security.put("mode", Long.toString(ssidConfig.getSecureMode().getId()));
 | 
				
			||||||
				String bridge = brHome;
 | 
									}
 | 
				
			||||||
 | 
									
 | 
				
			||||||
				boolean enabled = ssidConfig.getSsidAdminState().equals(StateSetting.enabled);
 | 
									boolean enabled = ssidConfig.getSsidAdminState().equals(StateSetting.enabled);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
				String ifName = null;
 | 
									String ifName = null;
 | 
				
			||||||
				String radioIfName = null;
 | 
									String radioIfName = null;
 | 
				
			||||||
//				int vifRadioIdx = -1;
 | 
					 | 
				
			||||||
 | 
					
 | 
				
			||||||
				if (radioType == RadioType.is2dot4GHz) {
 | 
									if (radioType == RadioType.is2dot4GHz) {
 | 
				
			||||||
					ifName = ifName2pt4GHz;
 | 
										ifName = ifName2pt4GHz;
 | 
				
			||||||
					radioIfName = radioName2pt4GHz;
 | 
										radioIfName = radioName2pt4GHz;
 | 
				
			||||||
//					vifRadioIdx = 1;
 | 
					 | 
				
			||||||
				} else if (radioType == RadioType.is5GHzL) {
 | 
									} else if (radioType == RadioType.is5GHzL) {
 | 
				
			||||||
					ifName = ifName5GHzL;
 | 
										ifName = ifName5GHzL;
 | 
				
			||||||
					radioIfName = radioName5GHzL;
 | 
										radioIfName = radioName5GHzL;
 | 
				
			||||||
//					vifRadioIdx = 2;
 | 
					 | 
				
			||||||
				} else if (radioType == RadioType.is5GHzU) {
 | 
									} else if (radioType == RadioType.is5GHzU) {
 | 
				
			||||||
					ifName = ifName5GHzU;
 | 
										ifName = ifName5GHzU;
 | 
				
			||||||
					radioIfName = radioName5GHzU;
 | 
										radioIfName = radioName5GHzU;
 | 
				
			||||||
//					vifRadioIdx = 3;
 | 
					 | 
				
			||||||
				}
 | 
									}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
//				if (vifRadioIdx == -1) {
 | 
					 | 
				
			||||||
//					LOG.debug("Cannot determine vif radio idx radioType {} skipping", radioType);
 | 
					 | 
				
			||||||
//					continue;
 | 
					 | 
				
			||||||
//				}
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
				if (!provisionedWifiVifConfigs.containsKey(ifName + "_" + ssidConfig.getSsid())) {
 | 
									if (!provisionedWifiVifConfigs.containsKey(ifName + "_" + ssidConfig.getSsid())) {
 | 
				
			||||||
					try {
 | 
										try {
 | 
				
			||||||
						configureSingleSsid(ovsdbClient, bridge, ifName, ssidConfig.getSsid(), ssidBroadcast, security,
 | 
											configureSingleSsid(ovsdbClient, bridgeNameVifInterfaces, ifName, ssidConfig.getSsid(), ssidBroadcast, security,
 | 
				
			||||||
								provisionedWifiRadioConfigs, radioIfName, ssidConfig.getVlanId(), rrmEnabled, minHwMode,
 | 
													provisionedWifiRadioConfigs, radioIfName, ssidConfig.getVlanId(), rrmEnabled, minHwMode,
 | 
				
			||||||
								enabled, keyRefresh, uapsdEnabled, apBridge, ssidConfig.getForwardMode(), gateway, inet,
 | 
													enabled, keyRefresh, uapsdEnabled, apBridge, ssidConfig.getForwardMode(), gateway, inet,
 | 
				
			||||||
								dns, ipAssignScheme);
 | 
													dns, ipAssignScheme);
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user