diff --git a/opensync-ext-cloud/src/main/java/com/telecominfraproject/wlan/opensync/external/integration/OpensyncExternalIntegrationCloud.java b/opensync-ext-cloud/src/main/java/com/telecominfraproject/wlan/opensync/external/integration/OpensyncExternalIntegrationCloud.java
index 00b32da..91d988b 100644
--- a/opensync-ext-cloud/src/main/java/com/telecominfraproject/wlan/opensync/external/integration/OpensyncExternalIntegrationCloud.java
+++ b/opensync-ext-cloud/src/main/java/com/telecominfraproject/wlan/opensync/external/integration/OpensyncExternalIntegrationCloud.java
@@ -1437,8 +1437,8 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
FailureReason fwUpgradeFailureReason = null;
if (opensyncAPState.getFirmwareUrl().equals(OvsdbStringConstants.OVSDB_AWLAN_AP_FACTORY_RESET)
- || opensyncAPState.getFirmwareUrl().equals(OvsdbStringConstants.OVSDB_AWLAN_AP_FACTORY_RESET)
- || opensyncAPState.getFirmwareUrl().equals(OvsdbStringConstants.OVSDB_AWLAN_AP_FACTORY_RESET)
+ || opensyncAPState.getFirmwareUrl().equals(OvsdbStringConstants.OVSDB_AWLAN_AP_REBOOT)
+ || opensyncAPState.getFirmwareUrl().equals(OvsdbStringConstants.OVSDB_AWLAN_AP_SWITCH_SOFTWARE_BANK)
|| opensyncAPState.getFirmwareUrl().equals("")) {
LOG.debug("Firmware Url {}, no fwUpgradeState", opensyncAPState.getFirmwareUrl());
@@ -1605,11 +1605,6 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
return;
}
- if (equipmentId < 0L) {
- LOG.debug("wifiVIFStateDbTableDelete Cannot get equipmentId {} for session {}", equipmentId);
- return;
- }
-
Status activeBssidsStatus = statusServiceInterface.getOrNull(customerId, equipmentId,
StatusDataType.ACTIVE_BSSIDS);
@@ -1644,7 +1639,7 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
}
- bssidList.removeAll(toBeDeleted);
+ if (bssidList != null) bssidList.removeAll(toBeDeleted);
statusDetails.setActiveBSSIDs(bssidList);
diff --git a/opensync-ext-cloud/src/main/java/com/telecominfraproject/wlan/opensync/external/integration/OpensyncExternalIntegrationMqttMessageProcessor.java b/opensync-ext-cloud/src/main/java/com/telecominfraproject/wlan/opensync/external/integration/OpensyncExternalIntegrationMqttMessageProcessor.java
index 3b62770..fc8732e 100644
--- a/opensync-ext-cloud/src/main/java/com/telecominfraproject/wlan/opensync/external/integration/OpensyncExternalIntegrationMqttMessageProcessor.java
+++ b/opensync-ext-cloud/src/main/java/com/telecominfraproject/wlan/opensync/external/integration/OpensyncExternalIntegrationMqttMessageProcessor.java
@@ -1787,17 +1787,16 @@ public class OpensyncExternalIntegrationMqttMessageProcessor {
if (radiusMetrics.hasLatency()) {
networkProbeMetrics.setRadiusLatencyInMs(radiusMetrics.getLatency());
}
+
if (radiusMetrics.hasRadiusState()) {
+ StateUpDownError radiusState = OvsdbToWlanCloudTypeMappingUtility
+ .getCloudMetricsStateFromOpensyncStatsStateUpDown(radiusMetrics.getRadiusState());
- if (radiusMetrics.hasRadiusState()) {
- StateUpDownError radiusState = OvsdbToWlanCloudTypeMappingUtility
- .getCloudMetricsStateFromOpensyncStatsStateUpDown(radiusMetrics.getRadiusState());
-
- networkProbeMetrics.setRadiusState(radiusState);
-
- }
+ networkProbeMetrics.setRadiusState(radiusState);
}
+
+
}
if (networkProbe.hasVlanProbe()) {
diff --git a/opensync-gateway-cloud-process/src/main/resources/launchers/OpenSyncProcess (local, KDC certs) cloud.launch b/opensync-gateway-cloud-process/src/main/resources/launchers/OpenSyncProcess (local, KDC certs) cloud.launch
index f8912da..c36a0c1 100644
--- a/opensync-gateway-cloud-process/src/main/resources/launchers/OpenSyncProcess (local, KDC certs) cloud.launch
+++ b/opensync-gateway-cloud-process/src/main/resources/launchers/OpenSyncProcess (local, KDC certs) cloud.launch
@@ -7,6 +7,7 @@
+
diff --git a/opensync-gateway-static-process/src/main/resources/launchers/OpenSyncProcess (local, KDC certs) static.launch b/opensync-gateway-static-process/src/main/resources/launchers/OpenSyncProcess (local, KDC certs) static.launch
index dbccbc1..886235f 100644
--- a/opensync-gateway-static-process/src/main/resources/launchers/OpenSyncProcess (local, KDC certs) static.launch
+++ b/opensync-gateway-static-process/src/main/resources/launchers/OpenSyncProcess (local, KDC certs) static.launch
@@ -7,6 +7,7 @@
+
diff --git a/opensync-gateway/src/main/java/com/telecominfraproject/wlan/opensync/ovsdb/dao/OvsdbDao.java b/opensync-gateway/src/main/java/com/telecominfraproject/wlan/opensync/ovsdb/dao/OvsdbDao.java
index 27ab85d..1045ab6 100644
--- a/opensync-gateway/src/main/java/com/telecominfraproject/wlan/opensync/ovsdb/dao/OvsdbDao.java
+++ b/opensync-gateway/src/main/java/com/telecominfraproject/wlan/opensync/ovsdb/dao/OvsdbDao.java
@@ -775,10 +775,9 @@ public class OvsdbDao {
Row row = null;
if ((result != null) && (result.length > 0) && !((SelectResult) result[0]).getRows().isEmpty()) {
row = ((SelectResult) result[0]).getRows().iterator().next();
- }
-
- for (OperationResult res : result) {
- LOG.debug("Op Result {}", res);
+ for (OperationResult res : result) {
+ LOG.debug("Op Result {}", res);
+ }
}
firmwareVersion = row != null ? row.getStringColumn("firmware_version") : null;
@@ -4856,34 +4855,36 @@ public class OvsdbDao {
}
int multicastRateMbps = 0;
- switch (multicastRate) {
- case rate6mbps:
- multicastRateMbps = 6;
- break;
- case rate9mbps:
- multicastRateMbps = 9;
- break;
- case rate12mbps:
- multicastRateMbps = 12;
- break;
- case rate18mbps:
- multicastRateMbps = 18;
- break;
- case rate24mbps:
- multicastRateMbps = 24;
- break;
- case rate36mbps:
- multicastRateMbps = 36;
- break;
- case rate48mbps:
- multicastRateMbps = 48;
- break;
- case rate54mbps:
- multicastRateMbps = 54;
- break;
- case auto:
- default:
- multicastRateMbps = 0;
+ if (multicastRate != null) {
+ switch (multicastRate) {
+ case rate6mbps:
+ multicastRateMbps = 6;
+ break;
+ case rate9mbps:
+ multicastRateMbps = 9;
+ break;
+ case rate12mbps:
+ multicastRateMbps = 12;
+ break;
+ case rate18mbps:
+ multicastRateMbps = 18;
+ break;
+ case rate24mbps:
+ multicastRateMbps = 24;
+ break;
+ case rate36mbps:
+ multicastRateMbps = 36;
+ break;
+ case rate48mbps:
+ multicastRateMbps = 48;
+ break;
+ case rate54mbps:
+ multicastRateMbps = 54;
+ break;
+ case auto:
+ default:
+ multicastRateMbps = 0;
+ }
}
if (freqBand != null) {
diff --git a/opensync-gateway/src/test/java/com/telecominfraproject/wlan/opensync/ovsdb/dao/OvsdbDaoTestUtilities.java b/opensync-gateway/src/test/java/com/telecominfraproject/wlan/opensync/ovsdb/dao/OvsdbDaoTestUtilities.java
index 212b0b3..903212d 100644
--- a/opensync-gateway/src/test/java/com/telecominfraproject/wlan/opensync/ovsdb/dao/OvsdbDaoTestUtilities.java
+++ b/opensync-gateway/src/test/java/com/telecominfraproject/wlan/opensync/ovsdb/dao/OvsdbDaoTestUtilities.java
@@ -121,14 +121,13 @@ public class OvsdbDaoTestUtilities {
mccMncList.add(passpointMccMnc);
Set naiRealms = new HashSet<>();
naiRealms.add(naiRealm);
- naiRealm.split(".");
List roamingOi = new ArrayList<>();
roamingOi.add(Byte.valueOf("1"));
roamingOi.add(Byte.valueOf("2"));
roamingOi.add(Byte.valueOf("3"));
roamingOi.add(Byte.valueOf("4"));
hotspot20IdProviderProfile = createOsuProviderProfile(customerId, hotspot20IdProviderProfile, mccMncList,
- naiRealms, "https://example.com/osu/" + naiRealm.split(".com")[0], naiRealm.split(".com")[0], naiRealm,
+ naiRealms, "https://example.com/osu/" + naiRealm.split("/.com")[0], naiRealm.split(".com")[0], naiRealm,
roamingOi);
return hotspot20IdProviderProfile;
}