[WIFI-3344] remove artifact from removing ClientSessionMetricDetails()

Signed-off-by: Mike Hansen <mike.hansen@netexperience.com>

opensync-ext-cloud/src/main/java/com/telecominfraproject/wlan/opensync/external/integration/OpensyncExternalIntegrationCloud.java

@@ -5,14 +5,23 @@ import java.net.Inet4Address;
 import java.net.Inet6Address;
 import java.net.InetAddress;
 import java.net.UnknownHostException;
+import java.text.DateFormat;
+import java.text.SimpleDateFormat;
+import java.time.Instant;
+import java.time.temporal.ChronoField;
+import java.time.temporal.TemporalField;
 import java.util.ArrayList;
+import java.util.Date;
 import java.util.EnumMap;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Objects;
+import java.util.Optional;
 import java.util.Set;
+import java.util.function.Predicate;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 import java.util.stream.Collectors;
@@ -37,11 +46,11 @@ import com.telecominfraproject.wlan.client.session.models.AssociationState;
 import com.telecominfraproject.wlan.client.session.models.ClientDhcpDetails;
 import com.telecominfraproject.wlan.client.session.models.ClientSession;
 import com.telecominfraproject.wlan.client.session.models.ClientSessionDetails;
-import com.telecominfraproject.wlan.client.session.models.ClientSessionMetricDetails;
 import com.telecominfraproject.wlan.core.model.entity.CountryCode;
 import com.telecominfraproject.wlan.core.model.equipment.EquipmentType;
 import com.telecominfraproject.wlan.core.model.equipment.MacAddress;
 import com.telecominfraproject.wlan.core.model.equipment.RadioType;
+import com.telecominfraproject.wlan.core.model.equipment.WiFiSessionUtility;
 import com.telecominfraproject.wlan.core.model.pagination.PaginationContext;
 import com.telecominfraproject.wlan.core.model.pagination.PaginationResponse;
 import com.telecominfraproject.wlan.customer.models.Customer;
@@ -119,10 +128,14 @@ import com.telecominfraproject.wlan.systemevent.equipment.realtime.ApcElectionEv
 import com.telecominfraproject.wlan.systemevent.equipment.realtime.ApcElectionEvent.ApcMode;
 import com.telecominfraproject.wlan.systemevent.equipment.realtime.RealTimeEventType;
 
+import sts.OpensyncStats.Report;
+
 @org.springframework.context.annotation.Profile("opensync_cloud_config")
 @Component
 public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegrationInterface {
 
+    protected static final String standard_linux_date_format = "EEE MMM dd HH:mm:ss zzz yyyy";
+
     private static final Logger LOG = LoggerFactory.getLogger(OpensyncExternalIntegrationCloud.class);
 
     @Autowired
@@ -144,7 +157,7 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
     @Autowired
     private FirmwareServiceInterface firmwareServiceInterface;
     @Autowired
-    private StatsPublisherInterface mqttMessageProcessor;
+    private StatsPublisherInterface statsPublisherInterface;
     @Autowired
     private AlarmServiceInterface alarmServiceInterface;
 
@@ -210,11 +223,14 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
                 }
 
                 long locationId = autoProvisionedLocationId;
-                locationId = customer.getDetails().getAutoProvisioning().getLocationId();
-
+                if ((customer.getDetails() != null) && (customer.getDetails().getAutoProvisioning() != null)
+                        && customer.getDetails().getAutoProvisioning().isEnabled()) {
+                    locationId = customer.getDetails().getAutoProvisioning().getLocationId();
+                }
                 try {
-                    Location location = locationServiceInterface.get(locationId);
-                    ce.setLocationId(location.getId());
+                    Location location = locationServiceInterface.getOrNull(locationId);
+                    if (location != null)
+                        ce.setLocationId(location.getId());
                 } catch (Exception e) {
                     LOG.error("Cannot auto-provision equipment because customer location with id {} cannot be found", locationId);
                     throw new IllegalStateException("Cannot auto-provision equipment because customer location cannot be found : " + locationId);
@@ -403,15 +419,30 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
             LOG.info("AP {} got connected to the gateway", apId);
             LOG.info("ConnectNodeInfo {}", connectNodeInfo);
 
-            if (connectNodeInfo.versionMatrix.containsKey(OvsdbStringConstants.FW_IMAGE_ACTIVE_KEY)) {
-                reconcileFwVersionToTrack(ce, connectNodeInfo.versionMatrix.get(OvsdbStringConstants.FW_IMAGE_ACTIVE_KEY), connectNodeInfo.model);
+            if (connectNodeInfo.versionMatrix.containsKey(OvsdbStringConstants.FW_IMAGE_ACTIVE_KEY) && connectNodeInfo.versionMatrix.containsKey("DATE")) {
+                // The AP uses standard linux date format. So the format would be:
+                // root@OpenAp-0498b5:~# date
+                // Tue Aug 3 14:55:28 UTC 2021
+                DateFormat dateFormat = new SimpleDateFormat(standard_linux_date_format, Locale.ENGLISH);
+                String dateString = connectNodeInfo.versionMatrix.get("DATE").strip();
+                try {
+                    Date date = dateFormat.parse(dateString);
+                    reconcileFwVersionToTrack(ce, connectNodeInfo.versionMatrix.get(OvsdbStringConstants.FW_IMAGE_ACTIVE_KEY),
+                            connectNodeInfo.versionMatrix.get(OvsdbStringConstants.FW_IMAGE_INACTIVE_KEY), date.getTime(), connectNodeInfo.model,
+                            connectNodeInfo.firmwareVersion);
+                } catch (java.text.ParseException p) {
+                    LOG.info("Could not parse release date {} from AP fw, set date to EPOCH start value.", dateString, Instant.EPOCH);
+                    reconcileFwVersionToTrack(ce, connectNodeInfo.versionMatrix.get(OvsdbStringConstants.FW_IMAGE_ACTIVE_KEY),
+                            connectNodeInfo.versionMatrix.get(OvsdbStringConstants.FW_IMAGE_INACTIVE_KEY), Instant.EPOCH.getLong(ChronoField.INSTANT_SECONDS), connectNodeInfo.model,
+                            connectNodeInfo.firmwareVersion);
+                }
             } else {
                 LOG.info("Cloud based firmware upgrade is not supported for this AP");
             }
 
         } catch (Exception e) {
             LOG.error("Could not process connection from AP {}", apId, e);
-            throw e;
+            throw new RuntimeException(e);
         }
 
     }
@@ -543,8 +574,9 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
             protocolStatusData.setBaseMacAddress(MacAddress.valueOf(connectNodeInfo.macAddress));
             protocolStatusData.setCloudCfgDataVersion(42L);
             protocolStatusData.setReportedCfgDataVersion(42L);
-            CountryCode countryCode = Location.getCountryCode(locationServiceInterface.get(ce.getLocationId()));
-            protocolStatusData.setCountryCode(countryCode.getName());
+            CountryCode countryCode = Location.getCountryCode(locationServiceInterface.getOrNull(ce.getLocationId()));
+            if (countryCode != null)
+                protocolStatusData.setCountryCode(countryCode.getName());
             if (connectNodeInfo.country != null) {
                 protocolStatusData.setReportedCC(CountryCode.getByName(connectNodeInfo.country));
             }
@@ -721,102 +753,97 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
 
     }
 
-    private void reconcileFwVersionToTrack(Equipment ce, String reportedFwVersionFromAp, String model) {
-
-        LOG.debug("reconcileFwVersionToTrack for AP {} with active firmware version {} model {}", ce.getInventoryId(), reportedFwVersionFromAp, model);
-        Status statusRecord = statusServiceInterface.getOrNull(ce.getCustomerId(), ce.getId(), StatusDataType.FIRMWARE);
+    void reconcileFwVersionToTrack(Equipment ce, String activeFirmwareImageAp, String inactiveFirmwareImageAp, Long activeFwReleaseDate, String model,
+            String firmwareVersion) {
 
+        LOG.debug("reconcileFwVersionToTrack for AP {} with active firmware version {} model {}", ce.getInventoryId(), activeFirmwareImageAp, model);
+        Status statusRecord = statusServiceInterface.getOrNull(autoProvisionedCustomerId, autoProvisionedCustomerId, StatusDataType.FIRMWARE);
+        if (statusRecord == null) {
+            statusRecord = new Status();
+            statusRecord.setCreatedTimestamp(System.currentTimeMillis());
+            statusRecord.setCustomerId(ce.getCustomerId());
+            statusRecord.setEquipmentId(ce.getId());
+            statusRecord.setStatusDataType(StatusDataType.FIRMWARE);
+            statusRecord.setDetails(new EquipmentUpgradeStatusData());
+            ((EquipmentUpgradeStatusData) statusRecord.getDetails()).setActiveSwVersion(activeFirmwareImageAp);
+            if (inactiveFirmwareImageAp != null) {
+                ((EquipmentUpgradeStatusData) statusRecord.getDetails()).setActiveSwVersion(inactiveFirmwareImageAp);
+            }
+        }
         EquipmentUpgradeStatusData fwUpgradeStatusData = (EquipmentUpgradeStatusData) statusRecord.getDetails();
+        fwUpgradeStatusData.setActiveSwVersion(firmwareVersion);
+        fwUpgradeStatusData.setAlternateSwVersion(inactiveFirmwareImageAp);
 
         // default track settings for firmware
         CustomerFirmwareTrackSettings trackSettings = firmwareServiceInterface.getDefaultCustomerTrackSetting();
 
         // check for updated/modified track settings for this customer
         CustomerFirmwareTrackRecord custFwTrackRecord = firmwareServiceInterface.getCustomerFirmwareTrackRecord(ce.getCustomerId());
-
-        long trackRecordId = -1;
-        if (custFwTrackRecord != null) {
+        if (custFwTrackRecord != null)
             trackSettings = custFwTrackRecord.getSettings();
-            trackRecordId = custFwTrackRecord.getTrackRecordId();
-        }
+
         // determine if AP requires FW upgrade before cloud
         // connection/provision
         if (trackSettings.getAutoUpgradeDeprecatedOnBind().equals(TrackFlag.ALWAYS) || trackSettings.getAutoUpgradeUnknownOnBind().equals(TrackFlag.ALWAYS)) {
-
             LOG.debug("reconcileFwVersionToTrack for AP {} track flag for auto-upgrade {}", ce.getInventoryId(),
                     trackSettings.getAutoUpgradeDeprecatedOnBind());
-
             // check the reported fw version for the AP, if it is < than
             // the default version for the cloud, then download and
             // flash the firmware before proceeding.
             // then return;
             FirmwareTrackRecord fwTrackRecord = null;
-            if (trackRecordId == -1) {
+            if (custFwTrackRecord == null) {
                 // take the default
                 fwTrackRecord = firmwareServiceInterface.getFirmwareTrackByName(FirmwareTrackRecord.DEFAULT_TRACK_NAME);
-
             } else {
                 // there must be a customer one
-                fwTrackRecord = firmwareServiceInterface.getFirmwareTrackById(trackRecordId);
+                fwTrackRecord = firmwareServiceInterface.getFirmwareTrackById(custFwTrackRecord.getTrackRecordId());
             }
-
             if (fwTrackRecord != null) {
-
                 LOG.debug("reconcileFwVersionToTrack for AP {} firmwareTrackRecord {}", ce.getInventoryId(), fwTrackRecord);
-
-                List<FirmwareTrackAssignmentDetails> fwTrackAssignmentDetails =
-                        firmwareServiceInterface.getFirmwareTrackAssignments(fwTrackRecord.getTrackName());
-
-                String targetFwVersionNameForTrack = null;
-
-                if (fwTrackAssignmentDetails != null) {
-                    for (FirmwareTrackAssignmentDetails details : fwTrackAssignmentDetails) {
-                        if (model.equalsIgnoreCase(details.getModelId())) {
-                            targetFwVersionNameForTrack = details.getVersionName();
-                            break;
-                        }
-                    }
-                }
-
-                if (targetFwVersionNameForTrack == null) {
-                    LOG.info("No target FW version for this track {}", fwTrackRecord);
-
-                } else {
-                    LOG.debug("reconcileFwVersionToTrack for AP {} targetFwVersion for track {}", ce.getInventoryId(), targetFwVersionNameForTrack);
-
-                    if (reportedFwVersionFromAp != null) {
-                        if (!targetFwVersionNameForTrack.equals(reportedFwVersionFromAp)) {
-                            LOG.debug(
-                                    "reconcileFwVersionToTrack for AP {} targetFwVersion {} doesn't match reported fw version {}, triggering download and flash",
-                                    ce.getInventoryId(), targetFwVersionNameForTrack, reportedFwVersionFromAp);
-
-                            fwUpgradeStatusData.setTargetSwVersion(targetFwVersionNameForTrack);
+                Optional<FirmwareTrackAssignmentDetails> assignmentDetails = firmwareServiceInterface.getFirmwareTrackAssignments(fwTrackRecord.getTrackName())
+                        .stream().filter(new Predicate<FirmwareTrackAssignmentDetails>() {
+                            @Override
+                            public boolean test(FirmwareTrackAssignmentDetails t) {
+                                // AP may report type as UPPER case
+                                return model.equalsIgnoreCase(t.getModelId());
+                            }
+                        }).findFirst();
+                if (assignmentDetails.isPresent()) {
+                    FirmwareTrackAssignmentDetails targetFirmwareForTrack = assignmentDetails.get();
+                    if (activeFwReleaseDate == null) {
+                        LOG.info("Active FW release date is unknown, firmware upgrade required.");
+                        fwUpgradeStatusData.setTargetSwVersion(targetFirmwareForTrack.getVersionName());
+                        fwUpgradeStatusData.setUpgradeState(EquipmentUpgradeState.out_of_date);
+                        statusRecord.setDetails(fwUpgradeStatusData);
+                        statusRecord = statusServiceInterface.update(statusRecord);
+                        triggerFwDownload(ce, fwUpgradeStatusData, trackSettings);
+                    } else {
+                        Date activeReleaseDate = new Date(activeFwReleaseDate);
+                        Date targetReleaseDate = new Date(targetFirmwareForTrack.getReleaseDate());
+                        if (activeReleaseDate.after(targetReleaseDate) || activeReleaseDate.equals(targetReleaseDate)) {
+                            LOG.info("Active FW release date {} is more recent than or equal to the target firmware release date {}, no upgrade required.",
+                                    activeReleaseDate, targetReleaseDate);
+                            fwUpgradeStatusData.setUpgradeState(EquipmentUpgradeState.up_to_date);
+                            fwUpgradeStatusData.setTargetSwVersion(targetFirmwareForTrack.getVersionName());
+                            statusRecord.setDetails(fwUpgradeStatusData);
+                            statusRecord = statusServiceInterface.update(statusRecord);
+                        } else {
+                            LOG.info("Active FW release date {} is earlier than target firmware release date {}, firmware upgrade required.", activeReleaseDate,
+                                    targetReleaseDate);
+                            fwUpgradeStatusData.setTargetSwVersion(targetFirmwareForTrack.getVersionName());
                             fwUpgradeStatusData.setUpgradeState(EquipmentUpgradeState.out_of_date);
                             statusRecord.setDetails(fwUpgradeStatusData);
                             statusRecord = statusServiceInterface.update(statusRecord);
                             triggerFwDownload(ce, fwUpgradeStatusData, trackSettings);
-                        } else if (targetFwVersionNameForTrack.equals(reportedFwVersionFromAp)) {
-                            LOG.debug("reconcileFwVersionToTrack for AP {} targetFwVersion {} is active", ce.getInventoryId(), targetFwVersionNameForTrack);
-
-                            fwUpgradeStatusData.setUpgradeState(EquipmentUpgradeState.up_to_date);
-                            fwUpgradeStatusData.setActiveSwVersion(targetFwVersionNameForTrack);
-                            fwUpgradeStatusData.setAlternateSwVersion(targetFwVersionNameForTrack);
-                            fwUpgradeStatusData.setTargetSwVersion(targetFwVersionNameForTrack);
-
-                            statusRecord.setDetails(fwUpgradeStatusData);
-                            statusRecord = statusServiceInterface.update(statusRecord);
-
                         }
                     }
-
+                } else {
+                    LOG.info("No firmware assignment present in track for AP model {}. Auto-upgrade of firmware is not possible for this node.", model);
                 }
-
             }
-
-        } else
-
-        {
-            LOG.debug("Automatic firmware upgrade is not configured for track {}", trackSettings);
+        } else {
+            LOG.info("Automatic firmware upgrade is not configured for track {}", trackSettings);
         }
     }
 
@@ -1436,7 +1463,6 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
             LOG.debug("wifiInetStateDbTableUpdate Cannot get customer Equipment for {}", apId);
             return;
         }
-
         int customerId = ce.getCustomerId();
         if ((customerId < 0) || (equipmentId < 0)) {
             LOG.debug("wifiInetStateDbTableUpdate::Cannot get valid CustomerId {} or EquipmentId {} for AP {}", customerId, equipmentId, apId);
@@ -1557,15 +1583,12 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
             LOG.debug("wifiAssociatedClientsDbTableUpdate::Cannot get Session for AP {}", apId);
             return;
         }
-
         long equipmentId = ovsdbSession.getEquipmentId();
         Equipment ce = equipmentServiceInterface.getOrNull(equipmentId);
-
         if (ce == null) {
             LOG.debug("wifiAssociatedClientsDbTableUpdate Cannot get customer Equipment for {}", apId);
             return;
         }
-
         int customerId = ce.getCustomerId();
         if ((customerId < 0) || (equipmentId < 0)) {
             LOG.debug("wifiAssociatedClientsDbTableUpdate::Cannot get valid CustomerId {} or EquipmentId {} for AP {}", customerId, equipmentId, apId);
@@ -1588,17 +1611,13 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
             MacAddress macAddress = MacAddress.valueOf(mMac);
 
             Client clientInstance = clientServiceInterface.getOrNull(customerId, macAddress);
-            boolean isReassociation = true;
             if (clientInstance == null) {
-
-                isReassociation = false; // new client
-
                 clientInstance = new Client();
                 clientInstance.setCustomerId(customerId);
                 clientInstance.setMacAddress(MacAddress.valueOf(mMac));
+                clientInstance.setCreatedTimestamp(System.currentTimeMillis());
                 clientInstance.setDetails(new ClientInfoDetails());
                 clientInstance = clientServiceInterface.create(clientInstance);
-
                 LOG.info("Created client from Wifi_Associated_Clients ovsdb table change {}", clientInstance);
             }
 
@@ -1610,30 +1629,20 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
                 clientSession.setMacAddress(clientInstance.getMacAddress());
                 clientSession.setLocationId(ce.getLocationId());
                 clientSession.setDetails(new ClientSessionDetails());
-                clientSession.getDetails().setSessionId(clientInstance.getMacAddress().getAddressAsLong());
-                clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(clientInstance.getMacAddress().getAddressAsLong()));
-                clientSession.getDetails().setMetricDetails(new ClientSessionMetricDetails());
+                long derivedSessionId = WiFiSessionUtility.encodeWiFiAssociationId(timestamp / 1000, clientInstance.getMacAddress().getAddressAsLong());
+                clientSession.getDetails().setSessionId(Long.toUnsignedString(derivedSessionId));
+                clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(Long.toUnsignedString(derivedSessionId)));
                 clientSession.getDetails().setAssociationState(AssociationState._802_11_Associated);
+                clientSession.getDetails().setIsReassociation(false);
                 clientSession.getDetails().setAssocTimestamp(timestamp);
+                clientSessions.add(clientSession);
             } else {
-                if (clientSession.getDetails().getPriorEquipmentId() == null) {
-                    clientSession.getDetails().setPriorEquipmentId(clientSession.getEquipmentId());
-                }
-                if (clientSession.getDetails().getPriorSessionId() == null) {
-                    clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
-                }
-                if (clientSession.getDetails().getLastEventTimestamp() == null || clientSession.getDetails().getLastEventTimestamp() < timestamp) {
-                    clientSession.getDetails().setLastEventTimestamp(timestamp);
-                }
                 if (!clientSession.getDetails().getAssociationState().equals(AssociationState._802_11_Associated)) {
                     clientSession.getDetails().setAssociationState(AssociationState._802_11_Associated);
                     clientSession.getDetails().setAssocTimestamp(timestamp);
+                    clientSessions.add(clientSession);
                 }
             }
-            clientSession.getDetails().setIsReassociation(isReassociation);
-
-            clientSessions.add(clientSession);
-
         }
 
         if (clientSessions.size() > 0) {
@@ -1882,9 +1891,12 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
             LOG.debug("wifiVIFStateDbTableDelete::Cannot get Session for AP {}", apId);
             return;
         }
-
         long equipmentId = ovsdbSession.getEquipmentId();
         Equipment ce = equipmentServiceInterface.getOrNull(equipmentId);
+        if (ce == null) {
+            LOG.debug("wifiVIFStateDbTableDelete Cannot get customer Equipment for {}", apId);
+            return;
+        }
         int customerId = ce.getCustomerId();
         if ((customerId < 0) || (equipmentId < 0)) {
             LOG.debug("wifiVIFStateDbTableDelete::Cannot get valid CustomerId {} or EquipmentId {} for AP {}", customerId, equipmentId, apId);
@@ -1942,9 +1954,13 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
         }
         long equipmentId = ovsdbSession.getEquipmentId();
         Equipment ce = equipmentServiceInterface.getOrNull(equipmentId);
+        if (ce == null) {
+            LOG.debug("wifiAssociatedClientsDbTableDelete Cannot get customer Equipment for {}", apId);
+            return;
+        }
         int customerId = ce.getCustomerId();
         if ((customerId < 0) || (equipmentId < 0)) {
-            LOG.debug("wifiVIFStateDbTableDelete::Cannot get valid CustomerId {} or EquipmentId {} for AP {}", customerId, equipmentId, apId);
+            LOG.debug("wifiAssociatedClientsDbTableDelete::Cannot get valid CustomerId {} or EquipmentId {} for AP {}", customerId, equipmentId, apId);
             return;
         }
         Client client = clientServiceInterface.getOrNull(customerId, MacAddress.valueOf(deletedClientMac));
@@ -1982,11 +1998,11 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
 
         long equipmentId = ovsdbSession.getEquipmentId();
         Equipment ce = equipmentServiceInterface.getByInventoryIdOrNull(apId);
-        int customerId = ce.getCustomerId();
         if (ce == null) {
             LOG.debug("updateDhcpIpClientFingerprints::Cannot get Equipment for AP {}", apId);
             return;
         }
+        int customerId = ce.getCustomerId();
         if ((customerId < 0) || (equipmentId < 0)) {
             LOG.debug("updateDhcpIpClientFingerprints::Cannot get valid CustomerId {} or EquipmentId {} for AP {}", customerId, equipmentId, apId);
             return;
@@ -2079,15 +2095,6 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
                     if (clientServiceInterface.getOrNull(customerId, clientMacAddress) != null) {
                         LOG.info("Deleting invalid client {}", clientServiceInterface.delete(customerId, clientMacAddress));
                     }
-                } else {
-                    LOG.info("Client {} already exists on the cloud, delete the session for the client if it exists", dhcpLeasedIps);
-                    // In this case, we might have a session, as the client
-                    // already exists on the cloud, update if required
-                    ClientSession session = clientServiceInterface.getSessionOrNull(customerId, equipmentId, clientMacAddress);
-                    if (session != null) {
-                        LOG.info("Delete clientSession that was removed from the Dhcp_Leased_IP table {}",
-                                clientServiceInterface.deleteSession(customerId, equipmentId, clientMacAddress));
-                    }
                 }
             }
         }
@@ -2102,21 +2109,8 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
         if (session == null) {
             LOG.info("No session for client {} with for customer {} equipment {}", clientMacAddress, customerId, equipmentId);
             return null;
-        } else {
-            if (session.getDetails().getPriorEquipmentId() == null) {
-                session.getDetails().setPriorEquipmentId(session.getEquipmentId());
-            }
-            if (session.getDetails().getPriorSessionId() == null) {
-                session.getDetails().setPriorSessionId(session.getDetails().getSessionId());
-            }
-            if (session.getDetails().getLastEventTimestamp() == null || session.getDetails().getLastEventTimestamp() < timestamp) {
-                session.getDetails().setLastEventTimestamp(timestamp);
-            }
-            if (!session.getDetails().getAssociationState().equals(AssociationState._802_11_Associated)) {
-                session.getDetails().setAssociationState(AssociationState._802_11_Associated);
-                session.getDetails().setAssocTimestamp(timestamp);
-            }
         }
+
         if (dhcpLeasedIps.containsKey("fingerprint")) {
             session.getDetails().setApFingerprint(dhcpLeasedIps.get("fingerprint"));
         }
@@ -2171,6 +2165,7 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
         if (dhcpLeasedIps.containsKey("lease_time")) {
             Integer leaseTime = Integer.valueOf(dhcpLeasedIps.get("lease_time"));
             session.getDetails().getDhcpDetails().setLeaseTimeInSeconds(leaseTime);
+            session.getDetails().getDhcpDetails().setLeaseStartTimestamp(session.getDetails().getAssocTimestamp());
         }
 
         if (dhcpLeasedIps.containsKey("gateway")) {
@@ -2413,7 +2408,7 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
         ApcElectionEvent electionEvent =
                 new ApcElectionEvent(drIpAddr, bdrIpAddr, localIpV4Addr, drIpAddr, mode, Boolean.valueOf(apcStateAttributes.get("enabled")),
                         RealTimeEventType.APC_Election_event, customerId, ce.getLocationId(), equipmentId, System.currentTimeMillis());
-        mqttMessageProcessor.publishSystemEventFromTableStateMonitor(electionEvent);
+        statsPublisherInterface.publishSystemEventFromTableStateMonitor(electionEvent);
     }
 
     @Override
@@ -2470,4 +2465,9 @@ public class OpensyncExternalIntegrationCloud implements OpensyncExternalIntegra
         LOG.debug("finished nodeStateDbTableUpdate for {}", apId);
 
     }
+
+    @Override
+    public void processMqttMessage(String topic, Report report) {
+        statsPublisherInterface.processMqttMessage(topic, report);
+    }
 }

opensync-ext-cloud/src/main/java/com/telecominfraproject/wlan/opensync/external/integration/controller/OpensyncCloudGatewayController.java

@@ -209,9 +209,9 @@ public class OpensyncCloudGatewayController {
                     case CellSizeAttributesRequest:
                         ret.add(sendCellSizeRequest(session, (CEGWCellSizeAttributesRequest) command));
                         break;
-                    case MostRecentStatsTimestamp:
-                        ret.add(sendGetMostRecentStatsTimestampRequest(command, inventoryId));
-                        break;
+//                    case MostRecentStatsTimestamp:
+//                        ret.add(sendGetMostRecentStatsTimestampRequest(command, inventoryId));
+//                        break;
                     default:
                         LOG.warn("[{}] Failed to deliver command {}, unsupported command type", inventoryId, command);
                         ret.add(new EquipmentCommandResponse(CEGWCommandResultCode.UnsupportedCommand,
@@ -250,32 +250,7 @@ public class OpensyncCloudGatewayController {
         return new GatewayDefaults();
     }
     
-    private EquipmentCommandResponse sendGetMostRecentStatsTimestampRequest(CEGWBaseCommand command, String inventoryId) {
-        Long ts = lastReceivedStatsTimestamp(inventoryId);
-        if (ts == null) {
-            return new EquipmentCommandResponse(CEGWCommandResultCode.NoRouteToCE,
-                    null, command,
-                    registeredGateway == null ? null : registeredGateway.getHostname(),
-                            registeredGateway == null ? -1 : registeredGateway.getPort());
-        } else {
-            return new EquipmentCommandResponse(CEGWCommandResultCode.Success,
-                    ts.toString(), command,
-                    registeredGateway == null ? null : registeredGateway.getHostname(),
-                            registeredGateway == null ? -1 : registeredGateway.getPort());
-        }
-    }
 
-    @RequestMapping(value = "/lastReceivedStatsTimestamp", method = RequestMethod.GET)
-    public Long lastReceivedStatsTimestamp(@RequestParam String apId) {
-        Long ret = null;
-        if (ovsdbSessionMapInterface.getSession(apId) != null) {
-            ret = ovsdbSessionMapInterface.getSession(apId).getMostRecentStatsTimestamp();
-            LOG.debug("lastReceivedStatsTimestamp for apId {} {}",apId,ret);
-        } else {
-            LOG.warn("lastReceivedStatsTimestamp found no session for {}, cannot get timestamp",apId);
-        }
-        return ret;
-    }
 
     /**
      * Verify a route to customer equipment

opensync-ext-cloud/src/main/java/com/telecominfraproject/wlan/opensync/external/integration/utils/MqttStatsPublisher.java

@@ -5,16 +5,16 @@ import java.net.Inet4Address;
 import java.net.Inet6Address;
 import java.net.InetAddress;
 import java.net.UnknownHostException;
-import java.text.DecimalFormat;
 import java.util.ArrayList;
 import java.util.Collections;
-import java.util.Date;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
 import java.util.concurrent.TimeUnit;
+import java.util.function.Predicate;
+import java.util.stream.Collectors;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -23,6 +23,7 @@ import org.springframework.beans.factory.annotation.Value;
 import org.springframework.scheduling.annotation.Async;
 import org.springframework.stereotype.Component;
 
+import com.google.common.base.Objects;
 import com.google.protobuf.ByteString;
 import com.telecominfraproject.wlan.alarm.AlarmServiceInterface;
 import com.telecominfraproject.wlan.alarm.models.Alarm;
@@ -38,7 +39,6 @@ import com.telecominfraproject.wlan.client.session.models.ClientEapDetails;
 import com.telecominfraproject.wlan.client.session.models.ClientFailureDetails;
 import com.telecominfraproject.wlan.client.session.models.ClientSession;
 import com.telecominfraproject.wlan.client.session.models.ClientSessionDetails;
-import com.telecominfraproject.wlan.client.session.models.ClientSessionMetricDetails;
 import com.telecominfraproject.wlan.cloudeventdispatcher.CloudEventDispatcherInterface;
 import com.telecominfraproject.wlan.core.model.equipment.ChannelBandwidth;
 import com.telecominfraproject.wlan.core.model.equipment.DetectedAuthMode;
@@ -51,7 +51,6 @@ import com.telecominfraproject.wlan.equipment.EquipmentServiceInterface;
 import com.telecominfraproject.wlan.equipment.models.Equipment;
 import com.telecominfraproject.wlan.opensync.external.integration.OvsdbSession;
 import com.telecominfraproject.wlan.opensync.external.integration.OvsdbSessionMapInterface;
-import com.telecominfraproject.wlan.opensync.external.integration.controller.OpensyncCloudGatewayController;
 import com.telecominfraproject.wlan.opensync.util.OvsdbToWlanCloudTypeMappingUtility;
 import com.telecominfraproject.wlan.profile.ProfileServiceInterface;
 import com.telecominfraproject.wlan.profile.models.Profile;
@@ -73,6 +72,7 @@ import com.telecominfraproject.wlan.servicemetric.channelinfo.models.ChannelInfo
 import com.telecominfraproject.wlan.servicemetric.channelinfo.models.ChannelInfoReports;
 import com.telecominfraproject.wlan.servicemetric.client.models.ClientMetrics;
 import com.telecominfraproject.wlan.servicemetric.models.ServiceMetric;
+import com.telecominfraproject.wlan.servicemetric.models.ServiceMetricDataType;
 import com.telecominfraproject.wlan.servicemetric.neighbourscan.models.NeighbourReport;
 import com.telecominfraproject.wlan.servicemetric.neighbourscan.models.NeighbourScanReports;
 import com.telecominfraproject.wlan.status.StatusServiceInterface;
@@ -139,8 +139,6 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
     private RealtimeEventPublisher realtimeEventPublisher;
     @Autowired
     private AlarmServiceInterface alarmServiceInterface;
-    @Autowired
-    private OpensyncCloudGatewayController gatewayController;
 
     @Value("${tip.wlan.mqttStatsPublisher.temperatureThresholdInC:80}")
     private int temperatureThresholdInC;
@@ -160,12 +158,16 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
     @Override
     @Async
     public void processMqttMessage(String topic, Report report) {
+        // Numerous try/catch blocks to address situations where logs are not being reported due to corrupt or invalid
+        // data in mqtt stats causing a crash
+        LOG.info("processMqttMessage for {} start", topic);
+
         long startTime = System.nanoTime();
         String apId = extractApIdFromTopic(topic);
-        LOG.info("Received report on topic {} for ap {}", topic, report.getNodeID());
+        
         Equipment ce = equipmentServiceInterface.getByInventoryIdOrNull(apId);
         if (ce == null) {
-            LOG.warn("Cannot get equipment for inventoryId {}. Ignore mqtt message for topic {}", apId, topic);
+            LOG.error("Cannot get equipment for inventoryId {}. Ignore mqtt message for topic {}. Exiting processMqttMessage without processing report.", apId, topic);
             return;
         }
 
@@ -175,44 +177,72 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
         long profileId = ce.getProfileId();
 
         // update timestamp for active customer equipment
-        gatewayController.updateActiveCustomer(customerId);
         List<ServiceMetric> metricRecordList = new ArrayList<>();
 
         try {
             long clientMetricsStart = System.nanoTime();
             populateApClientMetrics(metricRecordList, report, customerId, equipmentId, locationId);
             long clientMetricsStop = System.nanoTime();
-            LOG.debug("Elapsed time for constructing Client metrics record was {} milliseconds for topic {}",
-                    TimeUnit.MILLISECONDS.convert(clientMetricsStop - clientMetricsStart, TimeUnit.NANOSECONDS), topic);
+            if (LOG.isDebugEnabled())
+                LOG.debug("Elapsed time for constructing Client metrics record was {} milliseconds for topic {}",
+                        TimeUnit.MILLISECONDS.convert(clientMetricsStop - clientMetricsStart, TimeUnit.NANOSECONDS), topic);
+        } catch (Exception e) {
+            LOG.error("Exception when trying to populateApClientMetrics.", e);
+        }
 
+        try {
             long nodeMetricsStart = System.nanoTime();
             populateApNodeMetrics(metricRecordList, report, customerId, equipmentId, locationId);
             long nodeMetricsStop = System.nanoTime();
-            LOG.debug("Elapsed time for constructing ApNode metrics record was {} milliseconds for topic {}",
-                    TimeUnit.MILLISECONDS.convert(nodeMetricsStop - nodeMetricsStart, TimeUnit.NANOSECONDS), topic);
+            if (LOG.isDebugEnabled())
+                LOG.debug("Elapsed time for constructing ApNode metrics record was {} milliseconds for topic {}",
+                        TimeUnit.MILLISECONDS.convert(nodeMetricsStop - nodeMetricsStart, TimeUnit.NANOSECONDS), topic);
+        } catch (Exception e) {
+            LOG.error("Exception when trying to populateApNodeMetrics.", e);
+        }
 
+        try {
             long neighbourScanStart = System.nanoTime();
             populateNeighbourScanReports(metricRecordList, report, customerId, equipmentId, locationId);
             long neighbourScanStop = System.nanoTime();
-            LOG.debug("Elapsed time for constructing Neighbour metrics record was {} milliseconds for topic {}",
-                    TimeUnit.MILLISECONDS.convert(neighbourScanStop - neighbourScanStart, TimeUnit.NANOSECONDS), topic);
+            if (LOG.isDebugEnabled())
+                LOG.debug("Elapsed time for constructing Neighbour metrics record was {} milliseconds for topic {}",
+                        TimeUnit.MILLISECONDS.convert(neighbourScanStop - neighbourScanStart, TimeUnit.NANOSECONDS), topic);
+        } catch (Exception e) {
+            LOG.error("Exception when trying to populateNeighbourScanReports.", e);
+        }
 
+        try {
             long channelInfoStart = System.nanoTime();
             populateChannelInfoReports(metricRecordList, report, customerId, equipmentId, locationId, profileId);
             long channelInfoStop = System.nanoTime();
-            LOG.debug("Elapsed time for constructing Channel metrics record was {} milliseconds for topic {}",
-                    TimeUnit.MILLISECONDS.convert(channelInfoStop - channelInfoStart, TimeUnit.NANOSECONDS), topic);
+            if (LOG.isDebugEnabled())
+                LOG.debug("Elapsed time for constructing Channel metrics record was {} milliseconds for topic {}",
+                        TimeUnit.MILLISECONDS.convert(channelInfoStop - channelInfoStart, TimeUnit.NANOSECONDS), topic);
+        } catch (Exception e) {
+            LOG.error("Exception when trying to populateChannelInfoReports.", e);
+        }
 
+        try {
             long ssidStart = System.nanoTime();
             populateApSsidMetrics(metricRecordList, report, customerId, equipmentId, apId, locationId);
             long ssidStop = System.nanoTime();
-            LOG.debug("Elapsed time for constructing ApSsid metrics record was {} milliseconds for topic {}",
-                    TimeUnit.MILLISECONDS.convert(ssidStop - ssidStart, TimeUnit.NANOSECONDS), topic);
+            if (LOG.isDebugEnabled())
+                LOG.debug("Elapsed time for constructing ApSsid metrics record was {} milliseconds for topic {}",
+                        TimeUnit.MILLISECONDS.convert(ssidStop - ssidStart, TimeUnit.NANOSECONDS), topic);
+        } catch (Exception e) {
+            LOG.error("Exception when trying to populateApSsidMetrics.", e);
+        }
 
-            if (!metricRecordList.isEmpty()) {
-                long serviceMetricTimestamp = System.currentTimeMillis();
-                metricRecordList.stream().forEach(smr -> {              
-                    smr.setCreatedTimestamp(serviceMetricTimestamp);
+        if (!metricRecordList.isEmpty()) {
+            long serviceMetricTimestamp = System.currentTimeMillis();
+            metricRecordList.stream().forEach(smr -> {
+                try {
+                    // TODO use serviceMetricTimestamp rather than 0. This is done for now since there are some
+                    // channel metrics that have overlapping keys which messes up Cassandra if the same time stamp is
+                    // used
+                    // and setting it to 0 allows the CloudEventDispatcherController to assign unique time stamps.
+                    smr.setCreatedTimestamp(0);
                     if (smr.getLocationId() == 0)
                         smr.setLocationId(locationId);
                     if (smr.getCustomerId() == 0)
@@ -225,23 +255,39 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
                     long thresholdMillis = statsTimeDriftThresholdSec * 1000L;
                     if (diffMillis > thresholdMillis) {
                         double diffSec = diffMillis / 1000D;
-                        LOG.warn("AP {} stats report is {} seconds behind cloud. ServiceMetric {} sourceTimestampMs {} createdTimestampMs {}.", apId,diffSec,  smr.getDataType(), sourceTimestamp, serviceMetricTimestamp);
+                        LOG.warn("AP {} stats report is {} seconds behind cloud. ServiceMetric {} sourceTimestampMs {} createdTimestampMs {}.", apId, diffSec,
+                                smr.getDataType(), sourceTimestamp, serviceMetricTimestamp);
                     }
+                } catch (Exception e) {
+                    LOG.error("Exception when trying to set ServiceMetric timestamps and base values where not present.", e);
+                }
 
-                });
+            });
+
+            try {
                 long publishStart = System.nanoTime();
                 cloudEventDispatcherInterface.publishMetrics(metricRecordList);
                 long publishStop = System.nanoTime();
-                LOG.debug("Elapsed publishing time for metrics records from AP {} is {} milliseconds", apId,
-                        TimeUnit.MILLISECONDS.convert(publishStop - publishStart, TimeUnit.NANOSECONDS));
+                if (LOG.isDebugEnabled())
+                    LOG.debug("Elapsed publishing time for metrics records from AP {} is {} milliseconds", apId,
+                            TimeUnit.MILLISECONDS.convert(publishStop - publishStart, TimeUnit.NANOSECONDS));
+            } catch (Exception e) {
+                LOG.error("Exception when trying to publishServiceMetrics.", e);
             }
+        }
 
+        try {
             long mqttEventsStart = System.nanoTime();
             publishEvents(report, customerId, equipmentId, apId, locationId);
             long mqttEventsStop = System.nanoTime();
-            LOG.debug("Elapsed publishing time for mqtt events from AP {} is {} milliseconds", apId,
-                    TimeUnit.MILLISECONDS.convert(mqttEventsStop - mqttEventsStart, TimeUnit.NANOSECONDS));
+            if (LOG.isDebugEnabled())
+                LOG.debug("Elapsed publishing time for mqtt events from AP {} is {} milliseconds", apId,
+                        TimeUnit.MILLISECONDS.convert(mqttEventsStop - mqttEventsStart, TimeUnit.NANOSECONDS));
+        } catch (Exception e) {
+            LOG.error("Exception when trying to publishEvents.", e);
+        }
 
+        try {
             long endTime = System.nanoTime();
             long elapsedTimeMillis = TimeUnit.MILLISECONDS.convert(endTime - startTime, TimeUnit.NANOSECONDS);
             long elapsedTimeSeconds = TimeUnit.SECONDS.convert(endTime - startTime, TimeUnit.NANOSECONDS);
@@ -251,21 +297,23 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
                         elapsedTimeSeconds, report);
             } else {
                 if (elapsedTimeSeconds < 1) {
-                    LOG.debug("Total elapsed processing time {} milliseconds for stats messages from AP {}", elapsedTimeMillis, apId);
+                    if (LOG.isDebugEnabled())
+                        LOG.debug("Total elapsed processing time {} milliseconds for stats messages from AP {}", elapsedTimeMillis, apId);
                 } else {
-                    LOG.debug("Total elapsed processing time {} seconds for stats messages from AP {}", elapsedTimeSeconds, apId);
+                    if (LOG.isDebugEnabled())
+                        LOG.debug("Total elapsed processing time {} seconds for stats messages from AP {}", elapsedTimeSeconds, apId);
                 }
             }
         } catch (Exception e) {
-            LOG.error("Exception when processing stats messages from AP", e);
+            LOG.error("Exception when calculating elapsed time for metrics processing.", e);
         }
 
+        LOG.info("processMqttMessage for {} complete", topic);
     }
 
     @Override
     public void publishSystemEventFromTableStateMonitor(SystemEvent event) {
         LOG.info("Publishing SystemEvent received by TableStateMonitor {}", event);
-        gatewayController.updateActiveCustomer(event.getCustomerId());
         cloudEventDispatcherInterface.publishEvent(event);
     }
 
@@ -338,20 +386,19 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
             clientSession.setMacAddress(MacAddress.valueOf(apClientEvent.getStaMac()));
             clientSession.setLocationId(locationId);
             clientSession.setDetails(new ClientSessionDetails());
-            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(apEventClientSession.getSessionId()));
-            clientSession.getDetails().setMetricDetails(new ClientSessionMetricDetails());
+            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(Long.toUnsignedString(apEventClientSession.getSessionId())));
         }
         if (clientSession.getDetails().getPriorEquipmentId() == null) {
             clientSession.getDetails().setPriorEquipmentId(clientSession.getEquipmentId());
         }
         if (clientSession.getDetails().getPriorSessionId() == null) {
-            if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId())
+            if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId())))
                 clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId()) {
+        if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId()))) {
             clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        clientSession.getDetails().setSessionId(apEventClientSession.getSessionId());
+        clientSession.getDetails().setSessionId(Long.toUnsignedString(apEventClientSession.getSessionId()));
         clientSession.getDetails().setRadioType(OvsdbToWlanCloudTypeMappingUtility.getRadioTypeFromOpensyncStatsRadioBandType(apClientEvent.getBand()));
         clientSession.getDetails().setSsid(apClientEvent.getSsid());
 
@@ -462,20 +509,19 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
             clientSession.setMacAddress(MacAddress.valueOf(apClientEvent.getStaMac()));
             clientSession.setLocationId(locationId);
             clientSession.setDetails(new ClientSessionDetails());
-            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(apEventClientSession.getSessionId()));
-            clientSession.getDetails().setMetricDetails(new ClientSessionMetricDetails());
+            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(Long.toUnsignedString(apEventClientSession.getSessionId())));
         }
         if (clientSession.getDetails().getPriorEquipmentId() == null) {
             clientSession.getDetails().setPriorEquipmentId(clientSession.getEquipmentId());
         }
         if (clientSession.getDetails().getPriorSessionId() == null) {
-            if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId())
+            if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId())))
                 clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId()) {
+        if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId()))) {
             clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        clientSession.getDetails().setSessionId(apEventClientSession.getSessionId());
+        clientSession.getDetails().setSessionId(Long.toUnsignedString(apEventClientSession.getSessionId()));
         clientSession.getDetails().setRadioType(OvsdbToWlanCloudTypeMappingUtility.getRadioTypeFromOpensyncStatsRadioBandType(apClientEvent.getBand()));
         clientSession.getDetails().setSsid(apClientEvent.getSsid());
         if (apClientEvent.hasDevType()) {
@@ -541,20 +587,19 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
             clientSession.setMacAddress(MacAddress.valueOf(apClientEvent.getStaMac()));
             clientSession.setLocationId(locationId);
             clientSession.setDetails(new ClientSessionDetails());
-            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(apEventClientSession.getSessionId()));
-            clientSession.getDetails().setMetricDetails(new ClientSessionMetricDetails());
+            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(Long.toUnsignedString(apEventClientSession.getSessionId())));
         }
         if (clientSession.getDetails().getPriorEquipmentId() == null) {
             clientSession.getDetails().setPriorEquipmentId(clientSession.getEquipmentId());
         }
         if (clientSession.getDetails().getPriorSessionId() == null) {
-            if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId())
+            if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId())))
                 clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId()) {
+        if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId()))) {
             clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        clientSession.getDetails().setSessionId(apEventClientSession.getSessionId());
+        clientSession.getDetails().setSessionId(Long.toUnsignedString(apEventClientSession.getSessionId()));
         clientSession.getDetails().setRadioType(OvsdbToWlanCloudTypeMappingUtility.getRadioTypeFromOpensyncStatsRadioBandType(apClientEvent.getBand()));
         clientSession.getDetails().setSsid(apClientEvent.getSsid());
         if (apClientEvent.hasAuthStatus()) {
@@ -592,20 +637,19 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
             clientSession.setMacAddress(MacAddress.valueOf(apClientEvent.getStaMac()));
             clientSession.setLocationId(locationId);
             clientSession.setDetails(new ClientSessionDetails());
-            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(apEventClientSession.getSessionId()));
-            clientSession.getDetails().setMetricDetails(new ClientSessionMetricDetails());
+            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(Long.toUnsignedString(apEventClientSession.getSessionId())));
         }
         if (clientSession.getDetails().getPriorEquipmentId() == null) {
             clientSession.getDetails().setPriorEquipmentId(clientSession.getEquipmentId());
         }
         if (clientSession.getDetails().getPriorSessionId() == null) {
-            if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId())
+            if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId())))
                 clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId()) {
+        if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId()))) {
             clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        clientSession.getDetails().setSessionId(apEventClientSession.getSessionId());
+        clientSession.getDetails().setSessionId(Long.toUnsignedString(apEventClientSession.getSessionId()));
         clientSession.getDetails().setRadioType(OvsdbToWlanCloudTypeMappingUtility.getRadioTypeFromOpensyncStatsRadioBandType(apClientEvent.getBand()));
         clientSession.getDetails().setSsid(apClientEvent.getSsid());
         if (apClientEvent.hasStatus()) {
@@ -657,20 +701,19 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
             clientSession.setMacAddress(MacAddress.valueOf(apClientEvent.getStaMac()));
             clientSession.setLocationId(locationId);
             clientSession.setDetails(new ClientSessionDetails());
-            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(apEventClientSession.getSessionId()));
-            clientSession.getDetails().setMetricDetails(new ClientSessionMetricDetails());
+            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(Long.toUnsignedString(apEventClientSession.getSessionId())));
         }
         if (clientSession.getDetails().getPriorEquipmentId() == null) {
             clientSession.getDetails().setPriorEquipmentId(clientSession.getEquipmentId());
         }
         if (clientSession.getDetails().getPriorSessionId() == null) {
-            if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId())
+            if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId())))
                 clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId()) {
+        if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId()))) {
             clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        clientSession.getDetails().setSessionId(apEventClientSession.getSessionId());
+        clientSession.getDetails().setSessionId(Long.toUnsignedString(apEventClientSession.getSessionId()));
         clientSession.getDetails().setSsid(apClientEvent.getSsid());
 
         ClientFailureDetails clientFailureDetails = new ClientFailureDetails();
@@ -705,20 +748,19 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
             clientSession.setMacAddress(MacAddress.valueOf(apClientEvent.getStaMac()));
             clientSession.setLocationId(locationId);
             clientSession.setDetails(new ClientSessionDetails());
-            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(apEventClientSession.getSessionId()));
-            clientSession.getDetails().setMetricDetails(new ClientSessionMetricDetails());
+            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(Long.toUnsignedString(apEventClientSession.getSessionId())));
         }
         if (clientSession.getDetails().getPriorEquipmentId() == null) {
             clientSession.getDetails().setPriorEquipmentId(clientSession.getEquipmentId());
         }
         if (clientSession.getDetails().getPriorSessionId() == null) {
-            if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId())
+            if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId())))
                 clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId()) {
+        if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId()))) {
             clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        clientSession.getDetails().setSessionId(apEventClientSession.getSessionId());
+        clientSession.getDetails().setSessionId(Long.toUnsignedString(apEventClientSession.getSessionId()));
 
         if (apClientEvent.hasFdataRxUpTsInUs()) {
             clientSession.getDetails().setFirstDataRcvdTimestamp(apClientEvent.getFdataRxUpTsInUs());
@@ -757,20 +799,19 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
             clientSession.setMacAddress(MacAddress.valueOf(apClientEvent.getCltMac()));
             clientSession.setLocationId(locationId);
             clientSession.setDetails(new ClientSessionDetails());
-            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(apEventClientSession.getSessionId()));
-            clientSession.getDetails().setMetricDetails(new ClientSessionMetricDetails());
+            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(Long.toUnsignedString(apEventClientSession.getSessionId())));
         }
         if (clientSession.getDetails().getPriorEquipmentId() == null) {
             clientSession.getDetails().setPriorEquipmentId(clientSession.getEquipmentId());
         }
         if (clientSession.getDetails().getPriorSessionId() == null) {
-            if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId())
+            if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId())))
                 clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId()) {
+        if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId()))) {
             clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        clientSession.getDetails().setSessionId(apEventClientSession.getSessionId());
+        clientSession.getDetails().setSessionId(Long.toUnsignedString(apEventClientSession.getSessionId()));
         if (apClientEvent.hasCltId()) {
             clientSession.getDetails().setHostname(apClientEvent.getCltId());
         }
@@ -799,20 +840,19 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
             clientSession.setMacAddress(MacAddress.valueOf(apClientEvent.getStaMac()));
             clientSession.setLocationId(locationId);
             clientSession.setDetails(new ClientSessionDetails());
-            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(apEventClientSession.getSessionId()));
-            clientSession.getDetails().setMetricDetails(new ClientSessionMetricDetails());
+            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(Long.toUnsignedString(apEventClientSession.getSessionId())));
         }
         if (clientSession.getDetails().getPriorEquipmentId() == null) {
             clientSession.getDetails().setPriorEquipmentId(clientSession.getEquipmentId());
         }
         if (clientSession.getDetails().getPriorSessionId() == null) {
-            if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId())
+            if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId())))
                 clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId()) {
+        if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId()))) {
             clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        clientSession.getDetails().setSessionId(apEventClientSession.getSessionId());
+        clientSession.getDetails().setSessionId(Long.toUnsignedString(apEventClientSession.getSessionId()));
         if (apClientEvent.hasIpAddr()) {
             ByteString ipAddress = apClientEvent.getIpAddr();
             if (ipAddress != null) {
@@ -856,20 +896,19 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
             clientSession.setMacAddress(MacAddress.valueOf(apClientEvent.getStaMac()));
             clientSession.setLocationId(locationId);
             clientSession.setDetails(new ClientSessionDetails());
-            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(apEventClientSession.getSessionId()));
-            clientSession.getDetails().setMetricDetails(new ClientSessionMetricDetails());
+            clientSession.getDetails().setDhcpDetails(new ClientDhcpDetails(Long.toUnsignedString(apEventClientSession.getSessionId())));
         }
         if (clientSession.getDetails().getPriorEquipmentId() == null) {
             clientSession.getDetails().setPriorEquipmentId(clientSession.getEquipmentId());
         }
         if (clientSession.getDetails().getPriorSessionId() == null) {
-            if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId())
+            if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId())))
                 clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        if (clientSession.getDetails().getSessionId() != apEventClientSession.getSessionId()) {
+        if (!Objects.equal(clientSession.getDetails().getSessionId(), Long.toUnsignedString(apEventClientSession.getSessionId()))) {
             clientSession.getDetails().setPriorSessionId(clientSession.getDetails().getSessionId());
         }
-        clientSession.getDetails().setSessionId(apEventClientSession.getSessionId());
+        clientSession.getDetails().setSessionId(Long.toUnsignedString(apEventClientSession.getSessionId()));
         if (apClientEvent.hasLastRcvUpTsInUs()) {
             clientSession.getDetails().setLastRxTimestamp(apClientEvent.getLastRcvUpTsInUs());
         }
@@ -1560,109 +1599,120 @@ public class MqttStatsPublisher implements StatsPublisherInterface {
     }
 
     void populateApSsidMetrics(List<ServiceMetric> metricRecordList, Report report, int customerId, long equipmentId, String apId, long locationId) {
+        LOG.debug("populateApSsidMetrics start");
+
+        if (report.getClientsCount() == 0) {
+            LOG.info("populateApSsidMetrics no client data present, cannot build {}", ServiceMetricDataType.ApSsid);
+            return;
+        }
+
+        LOG.debug("populateApSsidMetrics for Customer {} Equipment {} LocationId {} AP {}", customerId, equipmentId, locationId, apId);
 
-        LOG.info("populateApSsidMetrics for Customer {} Equipment {}", customerId, equipmentId);
         ServiceMetric smr = new ServiceMetric(customerId, equipmentId);
         smr.setLocationId(locationId);
+        smr.setDataType(ServiceMetricDataType.ApSsid);
         ApSsidMetrics apSsidMetrics = new ApSsidMetrics();
         smr.setDetails(apSsidMetrics);
         metricRecordList.add(smr);
 
         for (ClientReport clientReport : report.getClientsList()) {
-
-            LOG.debug("ClientReport for channel {} RadioBand {}", clientReport.getChannel(), clientReport.getBand());
-
-            // The service metric report's sourceTimestamp will be the most recent ClientReport timestamp
-            if (apSsidMetrics.getSourceTimestampMs() < clientReport.getTimestampMs())
-                apSsidMetrics.setSourceTimestampMs(clientReport.getTimestampMs());
-
-            long txBytes = 0L;
-            long rxBytes = 0L;
-            long txFrames = 0L;
-            long rxFrames = 0L;
-
-            int txErrors = 0;
-            int rxErrors = 0;
-
-            int txRetries = 0;
-            int rxRetries = 0;
-
-            int lastRssi = 0;
-            String ssid = null;
-
-            Set<String> clientMacs = new HashSet<>();
-
             RadioType radioType = OvsdbToWlanCloudTypeMappingUtility.getRadioTypeFromOpensyncStatsRadioBandType(clientReport.getBand());
 
-            SsidStatistics ssidStatistics = new SsidStatistics();
-            // GET the Radio IF MAC (BSSID) from the activeBSSIDs
-            ssidStatistics.setSourceTimestampMs(clientReport.getTimestampMs());
-            Status activeBssidsStatus = statusServiceInterface.getOrNull(customerId, equipmentId, StatusDataType.ACTIVE_BSSIDS);
-            if (activeBssidsStatus != null && activeBssidsStatus.getDetails() != null
-                    && ((ActiveBSSIDs) activeBssidsStatus.getDetails()).getActiveBSSIDs() != null) {
-                for (ActiveBSSID activeBSSID : ((ActiveBSSIDs) activeBssidsStatus.getDetails()).getActiveBSSIDs()) {
-                    if (activeBSSID.getRadioType().equals(radioType)) {
-                        ssidStatistics.setBssid(MacAddress.valueOf(activeBSSID.getBssid()));
-                    }
+            LOG.debug("populateApSsidMetrics processing clientReport for RadioType {} Channel {}", radioType, clientReport.getChannel());
+            Map<String, List<Client>> clientBySsid = clientReport.getClientListList().stream().filter(new Predicate<Client>() {
+                @Override
+                public boolean test(Client t) {
+                    return t.hasSsid() && t.hasStats();
                 }
-            }
+            }).collect(Collectors.groupingBy(c -> c.getSsid()));
+
             if (LOG.isTraceEnabled())
-                LOG.trace("Client Report Date is {}", new Date(clientReport.getTimestampMs()));
-            int numConnectedClients = 0;
-            for (Client client : clientReport.getClientListList()) {
-                if (client.hasStats()) {
+                LOG.trace("populateApSsidMetrics clientBySsid {}", clientBySsid);
 
-                    if (client.hasSsid()) {
-                        ssid = client.getSsid();
-                    }
+            final List<SsidStatistics> ssidStats = new ArrayList<>();
 
-                    if (client.hasMacAddress()) {
-                        clientMacs.add(client.getMacAddress());
+            clientBySsid.entrySet().stream().forEach(e -> {
 
-                    } else {
-                        continue; // cannot have a session without a MAC address
-                    }
+                if (LOG.isTraceEnabled())
+                    LOG.trace("populateApSsidMetrics processing clients {}", e.getValue());
 
-                    rxBytes += client.getStats().getRxBytes();
-                    txBytes += client.getStats().getTxBytes();
-                    rxFrames += client.getStats().getRxFrames();
-                    txFrames += client.getStats().getTxFrames();
-                    rxRetries += client.getStats().getRxRetries();
-                    txRetries += client.getStats().getTxRetries();
-                    rxErrors += client.getStats().getRxErrors();
-                    txErrors += client.getStats().getTxErrors();
-                    lastRssi = client.getStats().getRssi();
+                SsidStatistics stats = new SsidStatistics();
+                stats.setSsid(e.getKey());
+                stats.setNumClient(e.getValue().size());
+                stats.setSourceTimestampMs(clientReport.getTimestampMs());
 
-                    if (client.hasConnected() && client.getConnected() && client.hasMacAddress()) {
-                        numConnectedClients += 1;
-                    }
-                }
+                // Get the BSSID (MAC address) for this SSID
+                String bssid = getBssidForClientSsid(customerId, equipmentId, apId, e.getKey(), radioType);
+                if (bssid != null)
+                    stats.setBssid(MacAddress.valueOf(bssid));
+                else
+                    LOG.warn("Could not get BSSID for customer {} equipment {} apId {}, ssid {} radioType {}", customerId, equipmentId, apId, e.getKey(),
+                            radioType);
 
-            }
+                long txBytes = e.getValue().stream().mapToLong(c -> c.getStats().getTxBytes()).sum();
+                long rxBytes = e.getValue().stream().mapToLong(c -> c.getStats().getRxBytes()).sum();
+                long txFrame = e.getValue().stream().mapToLong(c -> c.getStats().getTxFrames()).sum();
+                long rxFrame = e.getValue().stream().mapToLong(c -> c.getStats().getRxFrames()).sum();
 
-            ssidStatistics.setRxLastRssi(lastRssi);
-            ssidStatistics.setNumRxData(Long.valueOf(rxFrames).intValue());
-            ssidStatistics.setRxBytes(rxBytes - rxErrors - rxRetries);
-            ssidStatistics.setNumTxDataRetries(txRetries);
-            ssidStatistics.setNumRcvFrameForTx(txFrames);
-            ssidStatistics.setNumTxBytesSucc(txBytes - txErrors - txRetries);
-            ssidStatistics.setNumRxRetry(rxRetries);
-            ssidStatistics.setNumClient(numConnectedClients);
-            ssidStatistics.setSsid(ssid);
+                long txErrors = e.getValue().stream().mapToLong(c -> c.getStats().getTxErrors()).sum();
+                long rxErrors = e.getValue().stream().mapToLong(c -> c.getStats().getRxErrors()).sum();
 
-            if (radioType != null) {
-                List<SsidStatistics> ssidStatsList = apSsidMetrics.getSsidStats().get(radioType);
-                if (ssidStatsList == null) {
-                    ssidStatsList = new ArrayList<>();
-                }
-                ssidStatsList.add(ssidStatistics);
-                apSsidMetrics.getSsidStats().put(radioType, ssidStatsList);
-            }
+                long txRetries = e.getValue().stream().mapToLong(c -> c.getStats().getTxRetries()).sum();
+                long rxRetries = e.getValue().stream().mapToLong(c -> c.getStats().getRxRetries()).sum();
+
+                int[] rssi = e.getValue().stream().mapToInt(c -> c.getStats().getRssi()).toArray();
+                double avgRssi = DecibelUtils.getAverageDecibel(rssi);
+
+                stats.setRxLastRssi(Double.valueOf(avgRssi).intValue());
+                stats.setNumRxData(Long.valueOf(rxFrame).intValue());
+                stats.setRxBytes(rxBytes - rxErrors - rxRetries);
+                stats.setNumTxDataRetries(Long.valueOf(txRetries).intValue());
+                stats.setNumRcvFrameForTx(txFrame);
+                stats.setNumTxBytesSucc(txBytes - txErrors - txRetries);
+                stats.setNumRxRetry(Long.valueOf(rxRetries).intValue());
+
+                if (LOG.isTraceEnabled())
+                    LOG.trace("populateApSsidMetrics stats {}", stats.toPrettyString());
+                ssidStats.add(stats);
+
+            });
+
+            if (LOG.isTraceEnabled())
+                LOG.trace("populateApSsidMetrics ssidStats {}", ssidStats);
+            apSsidMetrics.getSsidStats().put(radioType, ssidStats);
 
         }
 
-        LOG.debug("ApSsidMetrics {}", apSsidMetrics);
+        if (LOG.isTraceEnabled())
+            LOG.trace("populateApSsidMetrics apSsidMetrics {}", apSsidMetrics);
 
+        LOG.debug("populateApSsidMetrics finished");
+    }
+
+    String getBssidForClientSsid(int customerId, long equipmentId, String apId, String ssid, RadioType radioType) {
+        try {
+            Status activeBssidsStatus = statusServiceInterface.getOrNull(customerId, equipmentId, StatusDataType.ACTIVE_BSSIDS);
+            LOG.debug("populateApSsidMetrics get BSSID from activeBssids {}", activeBssidsStatus);
+            if (activeBssidsStatus != null) {
+                if (activeBssidsStatus.getDetails() != null) {
+                    ActiveBSSIDs activeBssids = (ActiveBSSIDs) activeBssidsStatus.getDetails();
+                    if (activeBssids.getActiveBSSIDs() != null) {
+                        for (ActiveBSSID activeBssid : activeBssids.getActiveBSSIDs()) {
+                            if (activeBssid.getRadioType() != null && activeBssid.getRadioType().equals(radioType)) {
+                                if (activeBssid.getSsid() != null && activeBssid.getSsid().equals(ssid)) {
+                                    if (activeBssid.getBssid() != null) {
+                                        return activeBssid.getBssid();
+                                    }
+                                }
+                            }
+                        }
+                    }
+                }
+            }
+        } catch (Exception e) {
+            LOG.error("Could not get active BSSIDs for apId {} radioType {}", apId, radioType, e);
+        }
+        return null;
     }
 
     ChannelInfo createChannelInfo(long equipmentId, RadioType radioType, List<SurveySample> surveySampleList, ChannelBandwidth channelBandwidth) {

opensync-ext-cloud/src/main/java/com/telecominfraproject/wlan/opensync/external/integration/utils/RealtimeEventPublisher.java

@@ -190,7 +190,7 @@ public class RealtimeEventPublisher {
         clientEvent.setRadioType(OvsdbToWlanCloudTypeMappingUtility
                 .getRadioTypeFromOpensyncStatsRadioBandType(clientConnectEvent.getBand()));
         clientEvent.setSsid(clientConnectEvent.getSsid());
-        clientEvent.setSessionId(clientConnectEvent.getSessionId());
+        clientEvent.setSessionId(Long.toUnsignedString( clientConnectEvent.getSessionId()));
 
         if (clientConnectEvent.hasFbtUsed()) {
             clientEvent.setFbtUsed(clientConnectEvent.getFbtUsed());
@@ -278,7 +278,7 @@ public class RealtimeEventPublisher {
         com.telecominfraproject.wlan.client.models.events.realtime.ClientDisconnectEvent clientEvent = new com.telecominfraproject.wlan.client.models.events.realtime.ClientDisconnectEvent(
                 clientDisconnectEvent.getTimestampMs());
         clientEvent.setClientMacAddress(MacAddress.valueOf(clientDisconnectEvent.getStaMac()));
-        clientEvent.setSessionId(clientDisconnectEvent.getSessionId());
+        clientEvent.setSessionId(Long.toUnsignedString( clientDisconnectEvent.getSessionId()));
         clientEvent.setRadioType(OvsdbToWlanCloudTypeMappingUtility
                 .getRadioTypeFromOpensyncStatsRadioBandType(clientDisconnectEvent.getBand()));
         clientEvent.setSsid(clientDisconnectEvent.getSsid());
@@ -326,7 +326,7 @@ public class RealtimeEventPublisher {
 
         com.telecominfraproject.wlan.client.models.events.realtime.ClientAuthEvent clientEvent = new com.telecominfraproject.wlan.client.models.events.realtime.ClientAuthEvent(
                 clientAuthEvent.getTimestampMs());
-        clientEvent.setSessionId(clientAuthEvent.getSessionId());
+        clientEvent.setSessionId(Long.toUnsignedString( clientAuthEvent.getSessionId()));
         clientEvent.setSsid(clientAuthEvent.getSsid());
         clientEvent.setClientMacAddress(MacAddress.valueOf(clientAuthEvent.getStaMac()));
         clientEvent.setRadioType(OvsdbToWlanCloudTypeMappingUtility
@@ -352,7 +352,7 @@ public class RealtimeEventPublisher {
         com.telecominfraproject.wlan.client.models.events.realtime.ClientAssocEvent clientEvent = new com.telecominfraproject.wlan.client.models.events.realtime.ClientAssocEvent(
                 clientAssocEvent.getTimestampMs());
 
-        clientEvent.setSessionId(clientAssocEvent.getSessionId());
+        clientEvent.setSessionId(Long.toUnsignedString( clientAssocEvent.getSessionId()));
         clientEvent.setSsid(clientAssocEvent.getSsid());
         clientEvent.setClientMacAddress(MacAddress.valueOf(clientAssocEvent.getStaMac()));
         clientEvent.setRadioType(OvsdbToWlanCloudTypeMappingUtility
@@ -403,7 +403,7 @@ public class RealtimeEventPublisher {
         com.telecominfraproject.wlan.client.models.events.realtime.ClientFailureEvent clientEvent = new com.telecominfraproject.wlan.client.models.events.realtime.ClientFailureEvent(
                 clientFailureEvent.getTimestampMs());
 
-        clientEvent.setSessionId(clientFailureEvent.getSessionId());
+        clientEvent.setSessionId(Long.toUnsignedString( clientFailureEvent.getSessionId()));
         clientEvent.setClientMacAddress(MacAddress.valueOf(clientFailureEvent.getStaMac()));
         clientEvent.setSsid(clientFailureEvent.getSsid());
 
@@ -430,7 +430,7 @@ public class RealtimeEventPublisher {
         com.telecominfraproject.wlan.client.models.events.realtime.ClientFirstDataEvent clientEvent = new com.telecominfraproject.wlan.client.models.events.realtime.ClientFirstDataEvent(
                 clientFirstDataEvent.getTimestampMs());
 
-        clientEvent.setSessionId(clientFirstDataEvent.getSessionId());
+        clientEvent.setSessionId(Long.toUnsignedString( clientFirstDataEvent.getSessionId()));
         clientEvent.setClientMacAddress(MacAddress.valueOf(clientFirstDataEvent.getStaMac()));
 
         if (clientFirstDataEvent.hasFdataTxUpTsInUs()) {
@@ -457,7 +457,7 @@ public class RealtimeEventPublisher {
         com.telecominfraproject.wlan.client.models.events.realtime.ClientIdEvent clientEvent = new com.telecominfraproject.wlan.client.models.events.realtime.ClientIdEvent(
                 clientIdEvent.getTimestampMs());
 
-        clientEvent.setSessionId(clientIdEvent.getSessionId());
+        clientEvent.setSessionId(Long.toUnsignedString( clientIdEvent.getSessionId()));
         clientEvent.setClientMacAddress(MacAddress.valueOf(clientIdEvent.getCltMac()));
         if (clientIdEvent.hasCltId()) {
             clientEvent.setUserId(clientIdEvent.getCltId());
@@ -478,7 +478,7 @@ public class RealtimeEventPublisher {
         com.telecominfraproject.wlan.client.models.events.realtime.ClientIpAddressEvent clientEvent = new com.telecominfraproject.wlan.client.models.events.realtime.ClientIpAddressEvent(
                 clientIpEvent.getTimestampMs());
 
-        clientEvent.setSessionId(clientIpEvent.getSessionId());
+        clientEvent.setSessionId(Long.toUnsignedString( clientIpEvent.getSessionId()));
         clientEvent.setClientMacAddress(MacAddress.valueOf(clientIpEvent.getStaMac()));
         if (clientIpEvent.hasIpAddr()) {
             try {
@@ -505,7 +505,7 @@ public class RealtimeEventPublisher {
         com.telecominfraproject.wlan.client.models.events.realtime.ClientTimeoutEvent clientEvent = new com.telecominfraproject.wlan.client.models.events.realtime.ClientTimeoutEvent(
                 clientTimeoutEvent.getTimestampMs());
 
-        clientEvent.setSessionId(clientTimeoutEvent.getSessionId());
+        clientEvent.setSessionId(Long.toUnsignedString( clientTimeoutEvent.getSessionId()));
         clientEvent.setClientMacAddress(MacAddress.valueOf(clientTimeoutEvent.getStaMac()));
         if (clientTimeoutEvent.hasRCode()) {
             clientEvent.setTimeoutReason(clientTimeoutEvent.getRCode().equals(CTReasonType.CTR_IDLE_TOO_LONG)
@@ -861,7 +861,7 @@ public class RealtimeEventPublisher {
             cloudSipCallReportEvent.setEventType(RealTimeEventType.SipCallReport);
 
             cloudSipCallReportEvent.setSipCallId(callReport.getWifiSessionId());
-            cloudSipCallReportEvent.setAssociationId(callReport.getSessionId());
+            cloudSipCallReportEvent.setAssociationId(Long.toUnsignedString( callReport.getSessionId()));
 
             if (callReport.hasReason()) {
                 cloudSipCallReportEvent.setReportReason(getCallReportReason(callReport.getReason()));
@@ -927,11 +927,11 @@ public class RealtimeEventPublisher {
             }
 
             if (apCallStart.hasSessionId()) {
-                cloudSipCallStartEvent.setAssociationId(apCallStart.getSessionId());
+                cloudSipCallStartEvent.setAssociationId(Long.toUnsignedString( apCallStart.getSessionId()));
             }
 
             if (apCallStart.hasWifiSessionId()) {
-                cloudSipCallStartEvent.setAssociationId(apCallStart.getWifiSessionId());
+                cloudSipCallStartEvent.setAssociationId(Long.toUnsignedString( apCallStart.getWifiSessionId()));
             }
 
             if (apCallStart.getCodecsCount() > 0) {
@@ -991,7 +991,7 @@ public class RealtimeEventPublisher {
 
             if (apCallStop.hasSessionId()) {
 
-                cloudSipCallStopEvent.setAssociationId(apCallStop.getSessionId());
+                cloudSipCallStopEvent.setAssociationId(Long.toUnsignedString(  apCallStop.getSessionId()));
 
             }
 
@@ -1055,11 +1055,11 @@ public class RealtimeEventPublisher {
             }
 
             if (apStreamVideoServer.hasSessionId()) {
-                rtsStartEvent.setSessionId(apStreamVideoServer.getSessionId());
+                rtsStartEvent.setSessionId(Long.toUnsignedString( apStreamVideoServer.getSessionId()));
             }
 
             if (apStreamVideoServer.hasVideoSessionId()) {
-                rtsStartEvent.setVideoSessionId(apStreamVideoServer.getVideoSessionId());
+                rtsStartEvent.setVideoSessionId(Long.toUnsignedString(  apStreamVideoServer.getVideoSessionId()));
             }
 
             eventsList.add(rtsStartEvent);
@@ -1179,7 +1179,7 @@ public class RealtimeEventPublisher {
             }
 
             if (apStreamVideoSessionStart.hasSessionId()) {
-                rtsStartSessionEvent.setSessionId(apStreamVideoSessionStart.getSessionId());
+                rtsStartSessionEvent.setSessionId(Long.toUnsignedString( apStreamVideoSessionStart.getSessionId()));
 
             }
 
@@ -1190,7 +1190,7 @@ public class RealtimeEventPublisher {
             }
 
             if (apStreamVideoSessionStart.hasVideoSessionId()) {
-                rtsStartSessionEvent.setVideoSessionId(apStreamVideoSessionStart.getVideoSessionId());
+                rtsStartSessionEvent.setVideoSessionId(Long.toUnsignedString( apStreamVideoSessionStart.getVideoSessionId()));
             }
             eventsList.add(rtsStartSessionEvent);
         }
@@ -1220,7 +1220,7 @@ public class RealtimeEventPublisher {
             }
 
             if (apStreamVideoStop.hasSessionId()) {
-                rtsStopEvent.setSessionId(apStreamVideoStop.getSessionId());
+                rtsStopEvent.setSessionId(Long.toUnsignedString( apStreamVideoStop.getSessionId()));
             }
 
             if (apStreamVideoStop.hasStreamingVideoType()) {
@@ -1235,7 +1235,7 @@ public class RealtimeEventPublisher {
             }
 
             if (apStreamVideoStop.hasVideoSessionId()) {
-                rtsStopEvent.setVideoSessionId(apStreamVideoStop.getVideoSessionId());
+                rtsStopEvent.setVideoSessionId(Long.toUnsignedString(  apStreamVideoStop.getVideoSessionId()));
             }
 
             eventsList.add(rtsStopEvent);

opensync-ext-cloud/src/test/java/com/telecominfraproject/wlan/opensync/external/integration/OpensyncExternalIntegrationCloudTest.java

@@ -176,7 +176,7 @@ public class OpensyncExternalIntegrationCloudTest {
         location.setDetails(details);
         location.setName("Location-UT");
         location.setLocationType(LocationType.BUILDING);
-        Mockito.when(locationServiceInterface.get(8L)).thenReturn(location);
+        Mockito.when(locationServiceInterface.getOrNull(Mockito.anyLong())).thenReturn(location);
         Customer customer = new Customer();
         customer.setId(2);
         CustomerDetails customerDetails = new CustomerDetails();
@@ -232,7 +232,7 @@ public class OpensyncExternalIntegrationCloudTest {
         opensyncExternalIntegrationCloud.apConnected("Test_Client_21P10C68818122", createConnectNodeInfo());
 
         Mockito.verify(firmwareServiceInterface).getDefaultCustomerTrackSetting();
-        Mockito.verify(locationServiceInterface).get(8L);
+        Mockito.verify(locationServiceInterface).getOrNull(ArgumentMatchers.anyLong());
 
     }
 
@@ -246,7 +246,7 @@ public class OpensyncExternalIntegrationCloudTest {
         location.setDetails(details);
         location.setName("Location-UT");
         location.setLocationType(LocationType.BUILDING);
-        Mockito.when(locationServiceInterface.get(8L)).thenReturn(location);
+        Mockito.when(locationServiceInterface.getOrNull(8L)).thenReturn(location);
 
         Customer customer = new Customer();
         customer.setId(2);
@@ -326,7 +326,7 @@ public class OpensyncExternalIntegrationCloudTest {
         Mockito.verify(customerServiceInterface).getOrNull(ArgumentMatchers.anyInt());
         Mockito.verify(equipmentServiceInterface).getByInventoryIdOrNull("Test_Client_21P10C68818122");
         Mockito.verify(firmwareServiceInterface).getDefaultCustomerTrackSetting();
-        Mockito.verify(locationServiceInterface, Mockito.times(2)).get(ArgumentMatchers.anyLong());
+        Mockito.verify(locationServiceInterface, Mockito.times(2)).getOrNull(ArgumentMatchers.anyLong());
 
     }
 

opensync-ext-interface/src/main/java/com/telecominfraproject/wlan/opensync/external/integration/OpensyncExternalIntegrationInterface.java

@@ -54,4 +54,6 @@ public interface OpensyncExternalIntegrationInterface {
     void nodeStateDbTableUpdate(List<Map<String, String>> nodeStateAttributes, String apId);
 
     void clearEquipmentStatus(String apId);
+    
+    void processMqttMessage(String topic, Report report);
 }

opensync-ext-interface/src/main/java/com/telecominfraproject/wlan/opensync/external/integration/OvsdbSession.java

@@ -1,7 +1,5 @@
 package com.telecominfraproject.wlan.opensync.external.integration;
 
-import java.util.Objects;
-
 import com.vmware.ovsdb.service.OvsdbClient;
 
 public class OvsdbSession {
@@ -9,7 +7,6 @@ public class OvsdbSession {
     private String apId;
     private long routingId;
     private long equipmentId;
-    private long mostRecentStatsTimestamp;
     
     public OvsdbClient getOvsdbClient() {
         return ovsdbClient;
@@ -35,34 +32,5 @@ public class OvsdbSession {
     public void setEquipmentId(long equipmentId) {
         this.equipmentId = equipmentId;
     }
-    public long getMostRecentStatsTimestamp() {
-        return mostRecentStatsTimestamp;
-    }
-    public void setMostRecentStatsTimestamp(long mostRecentStatsTimestamp) {
-        this.mostRecentStatsTimestamp = mostRecentStatsTimestamp;
-    }
-    @Override
-    public int hashCode() {
-        return Objects.hash(apId, equipmentId, mostRecentStatsTimestamp, ovsdbClient, routingId);
-    }
-    @Override
-    public boolean equals(Object obj) {
-        if (this == obj)
-            return true;
-        if (obj == null)
-            return false;
-        if (getClass() != obj.getClass())
-            return false;
-        OvsdbSession other = (OvsdbSession) obj;
-        return Objects.equals(apId, other.apId) && equipmentId == other.equipmentId && mostRecentStatsTimestamp == other.mostRecentStatsTimestamp
-                && Objects.equals(ovsdbClient, other.ovsdbClient) && routingId == other.routingId;
-    }
-    
-    @Override
-    public String toString() {
-        return "OvsdbSession [ovsdbClient=" + ovsdbClient + ", apId=" + apId + ", routingId=" + routingId + ", equipmentId=" + equipmentId
-                + ", mostRecentStatsTimestamp=" + mostRecentStatsTimestamp + "]";
-    }
-
  
 }

opensync-gateway/src/main/java/com/telecominfraproject/wlan/opensync/mqtt/OpensyncMqttClient.java

@@ -11,10 +11,6 @@ import org.fusesource.mqtt.client.MQTT;
 import org.fusesource.mqtt.client.Message;
 import org.fusesource.mqtt.client.QoS;
 import org.fusesource.mqtt.client.Topic;
-import org.fusesource.mqtt.client.Tracer;
-import org.fusesource.mqtt.codec.MQTTFrame;
-import org.fusesource.mqtt.codec.PINGREQ;
-import org.fusesource.mqtt.codec.PINGRESP;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -36,8 +32,7 @@ import com.netflix.servo.monitor.Stopwatch;
 import com.netflix.servo.monitor.Timer;
 import com.netflix.servo.tag.TagList;
 import com.telecominfraproject.wlan.cloudmetrics.CloudMetricsTags;
-import com.telecominfraproject.wlan.opensync.external.integration.OvsdbSession;
-import com.telecominfraproject.wlan.opensync.external.integration.OvsdbSessionMapInterface;
+import com.telecominfraproject.wlan.opensync.external.integration.OpensyncExternalIntegrationInterface;
 import com.telecominfraproject.wlan.opensync.external.integration.utils.StatsPublisherInterface;
 import com.telecominfraproject.wlan.opensync.util.ZlibUtil;
 
@@ -63,10 +58,7 @@ public class OpensyncMqttClient implements ApplicationListener<ContextClosedEven
     private final Timer timerMessageProcess = new BasicTimer(MonitorConfig.builder("osgw-mqtt-messageProcessTimer").withTags(tags).build());
 
     @Autowired
-    private StatsPublisherInterface statsPublisher;
-    
-    @Autowired
-    private OvsdbSessionMapInterface ovsdbSessionMapInterface;
+    private OpensyncExternalIntegrationInterface opensyncExternalIntegrationInterface;
 
     // dtop: use anonymous constructor to ensure that the following code always
     // get executed,
@@ -193,18 +185,8 @@ public class OpensyncMqttClient implements ApplicationListener<ContextClosedEven
                                 // Only supported protobuf on the TIP opensync APs is Report
                                 Report statsReport = Report.parseFrom(payload);
                                 mqttMsg.ack();
-                                String apId = extractApIdFromTopic(mqttMsg.getTopic());
-                                if (apId != null) {
-                                    OvsdbSession ovsdbSession = ovsdbSessionMapInterface.getSession(extractApIdFromTopic(mqttMsg.getTopic()));
-                                    if (ovsdbSession != null) {
-                                        ovsdbSession.setMostRecentStatsTimestamp(System.currentTimeMillis());
-                                        LOG.debug("Last metrics received from AP updated to {}",ovsdbSession.toString());
-                                    } else {
-                                        LOG.debug("No ovsdb session exists for this AP {}",apId);
-                                    }
-                                }
                                 MQTT_LOG.info("Topic {}\n{}", mqttMsg.getTopic(), jsonPrinter.print(statsReport));
-                                statsPublisher.processMqttMessage(mqttMsg.getTopic(), statsReport);                           
+                                opensyncExternalIntegrationInterface.processMqttMessage(mqttMsg.getTopic(), statsReport);                           
                                 LOG.debug("Dispatched report for topic {} to backend for processing", mqttMsg.getTopic());
 
                             } catch (Exception e) {
@@ -245,25 +227,4 @@ public class OpensyncMqttClient implements ApplicationListener<ContextClosedEven
         }
     }
 
-    /**
-     * @param topic
-     * @return apId extracted from the topic name, or null if it cannot be
-     *         extracted
-     */
-    static String extractApIdFromTopic(String topic) {
-        // Topic is formatted as
-        // "/ap/"+clientCn+"_"+ret.serialNumber+"/opensync"
-        if (topic == null) {
-            return null;
-        }
-
-        String[] parts = topic.split("/");
-        if (parts.length < 3) {
-            return null;
-        }
-
-        // apId is the third element in the topic
-        return parts[2];
-    }
-    
 }

opensync-gateway/src/main/java/com/telecominfraproject/wlan/opensync/util/OvsdbStringConstants.java

@@ -13,6 +13,7 @@ public class OvsdbStringConstants {
     public static final String FW_IMAGE_NAME_KEY = "FW_IMAGE_NAME";
     public static final String FW_IMAGE_ACTIVE_KEY = "FW_IMAGE_ACTIVE";
     public static final String FW_IMAGE_INACTIVE_KEY = "FW_IMAGE_INACTIVE";
+    public static final String FW_IMAGE_DATE = "DATE";
 
     // AWLAN_Node values which can be placed in firmware_url column to trigger
     // behavior other than firmware download/flash