scottk/wlan-cloud-owprov
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/wlan-cloud-owprov.git synced 2025-11-01 19:17:47 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

Code analyzer fixes.

Browse Source
This commit is contained in:
stephb9959
2022-03-25 11:50:01 -07:00
parent 84376a07c9
commit c6efb7a80b
49 changed files with 205 additions and 174 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/RESTAPI/RESTAPI_map_handler.cpp
View File

@@ -45,7 +45,7 @@ namespace OpenWifi{
return OK();
}
static auto ValidateVisibility(const std::string &V) {
static bool ValidateVisibility(const std::string &V) {
return (V=="private" || V=="public" || V=="select");
}
@@ -65,6 +65,10 @@ namespace OpenWifi{
return BadRequest( RESTAPI::Errors::NameMustBeSet);
}
if(!ValidateVisibility(NewObject.visibility)) {
return BadRequest("Invalid visibility attribute");
}
if(RawObject->has("entity")) {
if(!NewObject.entity.empty() && !StorageService()->EntityDB().Exists("id",NewObject.entity))
return BadRequest(RESTAPI::Errors::EntityMustExist);
@@ -108,10 +112,10 @@ namespace OpenWifi{
}
if(Existing.creator != UserInfo_.userinfo.id) {
if(Existing.visibility == ProvObjects::PRIVATE) {
if(Existing.visibility == "private") {
return UnAuthorized(RESTAPI::Errors::InsufficientAccessRights, ACCESS_DENIED);
}
if(Existing.visibility == ProvObjects::SELECT) {
if(Existing.visibility == "select") {
for(const auto &i:Existing.access.list) {
for(const auto &j:i.users.list) {
if(j==UserInfo_.userinfo.id) {